| [23:49:38] | * Torando has joined #farmos |
| [23:58:17] | * Torando has left #farmos () |
| [07:31:21] | * calbasi[m] has joined #farmos |
| [07:34:58] | * peko[m] has joined #farmos |
| [11:24:00] | <mstenta[m]> | Discovered a bug with the new birth quick form: https://github.com/farmOS/farmOS/pull/682 |
| [11:24:30] | <mstenta[m]> | paul121: if that fix looks OK to you I'll do a 2.1.1 release today |
| [11:24:49] | <mstenta[m]> | tl;dr: if you don't have the group module enabled there's a fatal error |
| [11:25:03] | <mstenta[m]> | (missed that in testing because i had the module enabled) |
| [11:27:52] | <symbioquine[m]> | mstenta[m]: The bug fix seems fine, but I wonder if the behavior of defaulting to the mother's group should happen when building the form... |
| [11:28:23] | <symbioquine[m]> | The way it's written, it looks like there's no way to not have the child in a group if the mother is in one. |
| [11:28:49] | <symbioquine[m]> | Whereas if the form were just pre-populated with the mother's group, then the value could just be cleared to achieve that case. |
| [11:29:24] | <mstenta[m]> | That is true - and was an intentional decision (albeit a shortcut - because autopopulating that field would take more work) - that should be a followup feature request IMO |
| [11:30:49] | <mstenta[m]> | Thanks for reviewing symbioquine ! |
| [14:13:10] | <mstenta[m]> | farmOS 2.1.1 has been released! 😄🎉 https://github.com/farmOS/farmOS/releases/tag/2.1.1 |
| [14:13:29] | <mstenta[m]> | ^ this only fixes a bug with the new birth quick form - so if you aren't using that you don't need 2.1.1 |
| [14:15:02] | <FarmerEd[m]> | Is it just a bug if you don't have groups installed? |
| [14:16:54] | <mstenta[m]> | yes |
| [14:17:07] | <mstenta[m]> | if you have the group module installed, there's no issue |
| [14:20:40] | <FarmerEd[m]> | Sure you need the groups module with livestock anyway 😁 |
| [14:22:05] | <mstenta[m]> | yea this may be somewhat of an edge-case bug haha - but a bug nonetheless... and now it's squashed. :-) |
| [17:02:42] | * guillermo-farmos has joined #farmos |