| [09:43:26] | <mstenta[m]> | paul121 symbioquine I opened a PR for this old forgotten issue: https://www.drupal.org/project/farm/issues/3249201 |
| [10:03:36] | <symbioquine[m]> | I guess you decided not to do the typed argument approach like Paul was suggesting? |
| [10:04:37] | <symbioquine[m]> | What you did definitely seems like a less intrusive change though so 🤷 |
| [10:26:07] | <mstenta[m]> | Well... things have changed since we last discussed this... BUT as I was replying to this I realized the geojson View is still broken (which Paul pointed out originally) - I forgot to test that |
| [10:26:54] | <mstenta[m]> | farm_ui_views_add_bundle_handlers became farm_ui_views_add_handlers (IIRC), which then became FarmUiViewsHelper::addHandlers() |
| [10:28:07] | <mstenta[m]> | I'll look back to find the exact commits, but I think that we dropped the $bundle argument back then... so the idea of making that argument a EntityTypeInterface no longer applies |
| [10:28:52] | <mstenta[m]> | But the spirit of Paul's suggestion still applies: |
| [10:28:52] | <mstenta[m]> | > That way the caller of the method needs to make sure they have a correct bundle. |
| [10:29:45] | <mstenta[m]> | And I only tested the original Views, not the geojson one (the only other place in core that we call FarmUiViewsHelper::addHandlers()) |
| [10:29:56] | <mstenta[m]> | I'll push a fix for that as well... |
| [10:32:38] | <mstenta[m]> | mstenta[m]: https://github.com/farmOS/farmOS/commit/34616cc0419729afaaa678dbfc718a99... |
| [10:38:05] | <mstenta[m]> | added a commit to also fix geojson views: https://github.com/farmOS/farmOS/pull/1048/changes/fb7ae9696bceaee1a58ce... |
| [10:39:29] | <mstenta[m]> | I don't think we need to do more than that at this point... this is a very low impact bug |
| [10:40:36] | <mstenta[m]> | You have to request non-existent bundles by crafting the URL manually... it doesn't occur anywhere on its own in the UI. |