| [02:54:39] | * explore has joined #farmos |
| [08:07:02] | <mstenta[m]> | I'm adding some more folks to the farmOS-community-blog repository with the "Read" role - because I think that will allow them to become "reviewers" of blog posts |
| [08:07:14] | <mstenta[m]> | If anyone is interested (and you didn't receive an invite already), let me know! |
| [08:07:45] | <mstenta[m]> | Would be great to have a big list of reviewers! |
| [08:09:55] | <mstenta[m]> | oh wait hmm maybe Read role isn't enough 🤔 |
| [08:10:02] | <mstenta[m]> | https://docs.github.com/en/organizations/managing-user-access-to-your-or... |
| [08:10:46] | <symbioquine[m]> | ACTION uploaded an image: (4KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/wOsMwNfUGHD... > |
| [08:11:30] | <symbioquine[m]> | ACTION uploaded an image: (11KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/jmFZPZcVsYa... > |
| [08:11:53] | <symbioquine[m]> | Matches my expectation that you can review PRs even if you don't have write access... |
| [08:11:58] | <symbioquine[m]> | What were you looking at? |
| [08:12:24] | <mstenta[m]> | yea... but "Approve or request changes to a pull request with required reviews" is only available to "Write", "Maintain", and "Admin" |
| [08:12:29] | <mstenta[m]> | for the blog, we need 2 approvals to merge |
| [08:12:37] | <symbioquine[m]> | Ah, yeah that makes sense |
| [08:13:09] | <mstenta[m]> | maybe we open up to more "Write" users, but use branch protection rules more? |
| [08:13:20] | <symbioquine[m]> | Seems reasonable |
| [08:13:24] | <mstenta[m]> | we can discuss this on the next monthly call |
| [08:14:56] | <mstenta[m]> | in either case, symbioquine paul121 can I get some reviews on these PRs so I can publish the quick form blog posts? :-) |
| [08:15:06] | <mstenta[m]> | https://github.com/farmOS/farmOS.org/pull/81 |
| [08:15:14] | <mstenta[m]> | https://github.com/farmOS/farmOS.org/pull/83 |
| [08:15:23] | <mstenta[m]> | https://github.com/farmOS/farmOS-community-blog/pull/16 |
| [08:17:59] | <symbioquine[m]> | Code changes seem fine. Reading posts now... |
| [08:18:13] | <mstenta[m]> | Thanks!! |
| [08:26:30] | <symbioquine[m]> | What about something like chickens where the birth/genetic mother isn't necessarily known/tracked? |
| [08:26:51] | <symbioquine[m]> | I'm assuming you can't specify a group (i.e. the flock group) as the parent... |
| [08:28:20] | <mstenta[m]> | Hmm yea birth quick form wouldn't work in it's current form for that |
| [08:28:30] | <mstenta[m]> | Mother is required |
| [08:29:00] | <mstenta[m]> | Might be able to make it optional in a future iteration |
| [08:29:22] | <symbioquine[m]> | Or might make sense to have a separate "Hatching quick form" |
| [08:29:39] | <mstenta[m]> | Yea that might make more sense |
| [08:46:34] | <symbioquine[m]> | <mstenta[m]> "https://github.com/farmOS/farmOS..." <- Left a few comments |
| [09:02:16] | <mstenta[m]> | Great! Just need one more review :-) |
| [09:02:22] | <mstenta[m]> | Approval I mean |
| [09:38:35] | <mstenta[m]> | Thanks for the approval wotnak! |
| [09:39:01] | <mstenta[m]> | symbioquine: FYI yea it looks like @wotnak's review (with "Triage" role) isn't enough to meet the PR requirements... |
| [09:39:06] | <mstenta[m]> | ACTION uploaded an image: (10KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/YuiUUWKccNx... > |
| [09:42:45] | <mstenta[m]> | I think granting everyone Write role, along with branch protections that require a PR with two approvals, would work fine |
| [09:42:59] | <mstenta[m]> | these are the current branch protections: |
| [09:43:39] | <mstenta[m]> | ACTION uploaded an image: (97KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/BIZBhZUzICk... > |
| [09:44:02] | <mstenta[m]> | ACTION uploaded an image: (102KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/CvGyhLYhwWZ... > |
| [09:45:13] | <mstenta[m]> | I'll start a forum topic to discuss |
| [09:52:00] | <mstenta[m]> | https://farmos.discourse.group/t/adding-more-people-to-the-community-blo... |
| [10:34:27] | * explore has quit (Quit: Connection closed for inactivity) |
| [12:33:27] | <paul121[m]> | hey symbioquine how do you the "suggested change" diffs in github code reviews? |
| [12:34:06] | <mstenta[m]> | ACTION wondered that too (still haven't tried out the features to commit them directly too...) |
| [12:36:24] | <paul121[m]> | * do you do the "suggested |
| [13:07:50] | <symbioquine[m]> | ACTION uploaded a video: (186KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/AOvnXYSJvdX... > |
| [13:12:34] | <mstenta[m]> | wow! |
| [16:05:18] | * farmBOT has joined #farmos |
| [19:51:56] | * explore has joined #farmos |
