| [10:54:31] | * symbioquine[m] has joined #farmos |
| [10:54:32] | <symbioquine[m]> | I released farmOS-map 2.3.0, but in the process noticed that the release procedures aren't clear about whether we mean just running npm audit fix or something more thorough to "Confirm all dependencies are up-to-date" |
| [10:55:24] | <symbioquine[m]> | afaik npm audit fix only updates minor versions - so, for example, it doesn't cover the possibly much larger task of upgrading to a newer major version of OpenLayers... |
| [10:56:20] | <symbioquine[m]> | I think that might be the right level of upgrading for a release prerequisite, but perhaps should be spelled out more explicitly. What do folks think? |
| [10:56:57] | <symbioquine[m]> | (happy to update the procedure thread if so, just trying to make sure we're on the same page) |
| [10:57:12] | <mstenta[m]> | Yea I think that makes sense... |
| [10:57:36] | <mstenta[m]> | Just minor updates for a minor release |
| [10:57:40] | <symbioquine[m]> | * I released farmOS-map 2.3.0, but in the process noticed that the [release procedures](https://farmos.discourse.group/t/3-x-release-procedure/1070/4) aren't clear about whether we mean just running `npm audit fix` or something more thorough to "Confirm all dependencies are up-to-date" |
| [10:57:49] | <symbioquine[m]> | https://farmos.discourse.group/t/3-x-release-procedure/1070/4 (for those not familiar) |
| [11:02:21] | <symbioquine[m]> | Done: |
| [11:02:24] | <symbioquine[m]> | ACTION uploaded an image: (120KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/cDuUSYyMhDrZuNAO... > |
| [11:04:16] | <mstenta[m]> | Also saw your comment about farm_map_google... got me thinking... maybe we plan to add a farm_map_google module to farmOS 4.x (Drupal 11) and deprecate the contrib farm_map_google (leaving its version constraint to farmos/farmos:^3) |
| [11:04:56] | <mstenta[m]> | I'm also thinking about using 4.x as an opportunity to make Composer the recommended installation method (alongside Docker)... and drop support for "packaged releases" that are not managed by composer |
| [11:05:40] | <symbioquine[m]> | mstenta[m]: Sounds good to me. Some of the change will also need to be in farmOS-map IMHO (to add the layer type) |
| [11:06:19] | <mstenta[m]> | Is it a new layer type? Not just XYZ? |
| [11:07:33] | <symbioquine[m]> | mstenta[m]: Makes sense. That does seem to be one of the major sources of support requests that could be avoided. |
| [11:07:49] | <symbioquine[m]> | mstenta[m]: Probably - unless we want to duplicate a lot of this: https://github.com/openlayers/openlayers/blob/7245d80e118b462cd613c8f556... |
| [11:16:58] | <mstenta[m]> | paul121 fosten: https://github.com/farmOS/farmOS/issues/805#issuecomment-2098676772 |
| [11:27:21] | <mstenta[m]> | symbioquine: Good timing on the farmOS-map release. I'm working towards a new minor release of farmOS this week. :-) |
| [11:28:11] | <mstenta[m]> | Only two things left I might try to include... 1) updating `simple_oauth` (needs a patch re-roll by paul121 or myself), and 2) the CSV export column bug |
| [11:28:12] | <symbioquine[m]> | Just trying to follow through on https://github.com/farmOS/farmOS-map/pull/200#issuecomment-2090446705 |
| [11:29:36] | <symbioquine[m]> | overall a pretty simple change, but I haven't end-to-end tested that the map still works... which is the only thing blocking me moving [the PR](https://github.com/farmOS/farmOS/pull/841) out of draft |
| [11:29:57] | <symbioquine[m]> | which in turn got me thinking that maybe we should document minimal smoke testing steps for different kinds of changes... |
| [11:30:38] | <symbioquine[m]> | i.e. changing a dependency requires an export FARMOS_REPO=... + docker build -t ... + ... |
| [11:30:56] | <symbioquine[m]> | I always seem to have to reinvent that stuff each time |
| [11:31:04] | <symbioquine[m]> | not hard, but takes time |
| [11:32:10] | <mstenta[m]> | yea agreed... i forget too |
| [11:33:01] | <mstenta[m]> | wonder if there's a way to do that with tugboat already? cc paul121 :thinking: |
| [11:33:19] | <symbioquine[m]> | mstenta[m]: That would be awesome |
| [11:33:23] | <mstenta[m]> | (eg: click a button to spin up a testing instance at a certain branch) |
| [11:34:38] | <symbioquine[m]> | I think the main challenge is that the branch is in my fork right now so (I think) there's some security issues with just allowing anybody to spin up instances with (potentially) arbitrary code |
| [11:34:57] | <symbioquine[m]> | Could maybe have some sort of whitelist I guess |
| [11:35:16] | <mstenta[m]> | ah yea true |
| [11:35:37] | <symbioquine[m]> | or some sort of "bring your own instance" mechanism |
| [11:36:15] | <symbioquine[m]> | * your own <del>instance, * instance</del>Tugboat account" mechanism |
| [11:59:29] | <symbioquine[m]> | <symbioquine[m]> "I always seem to have to..." <- For now I just added my smoke testing procedure to [the PR](https://github.com/farmOS/farmOS/pull/841) so I can repeat it next time (that was the second place I looked after https://farmos.org/development/environment/) |
| [12:00:22] | <mstenta[m]> | awesome |
| [12:01:11] | <symbioquine[m]> | <symbioquine[m]> "overall a pretty simple change..." <- anyway, that should be ready to go (be reviewed) now |
| [13:14:49] | <mstenta[m]> | symbioquine: what are the nested square brackets in the changelog for? |
| [13:15:10] | <mstenta[m]> | > [add [the] ability to use custom stroke colors #201](https://github.com/farmOS/farmOS-map/issues/201) [in custom map layers] |
| [13:15:55] | <mstenta[m]> | Ooh I see... the issue didn't have the word "the" |
| [13:16:24] | <mstenta[m]> | Could we change them to parentheses? Or does that break the markdown? 🤔 |
| [13:16:43] | <mstenta[m]> | > > [add (the) ability to use custom stroke colors #201](https://github.com/farmOS/farmOS-map/issues/201) (in custom map layers) |
| [13:16:59] | <mstenta[m]> | Or even just omit them entirely |
| [13:17:14] | <mstenta[m]> | > [add the ability to use custom stroke colors #201](https://github.com/farmOS/farmOS-map/issues/201) (in custom map layers) |
| [13:18:41] | <mstenta[m]> | Do you mind if I change it to that last one? |
| [13:19:00] | <mstenta[m]> | (obviously a minor nit... happy to commit as-is too) |
| [16:31:37] | * gbathree[m] has joined #farmos |
| [16:31:38] | <gbathree[m]> | <fosten[m]> "Yeah, fees, ugh. I think the..." <- Holler if you want jitty gritty details. We use it in goat and there's good, bad and ugly for sure depending on your goals. |
