| [15:15:12] | <mstenta[m]> | wotnak: I'm testing out the work you did on the `farm_eggs` module 2.x port - awesome work! |
| [15:16:18] | <mstenta[m]> | I'm thinking through what the future of the farm_eggs module will be... but in the near term I have a few Farmier-hosted instances that are still on v1 because they need the eggs module. |
| [15:17:33] | <mstenta[m]> | It seems that the first commit on your main branch is exactly what I need to get them over the finish line |
| [15:18:00] | <mstenta[m]> | So I'm thinking: maybe we can open a new 2.x branch in the official repo, and start with just that first commit |
| [15:18:40] | <mstenta[m]> | Then we can think about next steps moving forward... |
| [15:20:29] | <mstenta[m]> | FYI the "first commit" I'm referring to is: `update module to work with farmOS v2 ` => https://github.com/mstenta/farm_eggs/commit/7b1ce619e9c87b160a3178dd4e33... |
| [15:21:14] | <mstenta[m]> | There is only one other small change I need beyond that: I want to make the farm_group module optional (the sites I host that use the module don't currently have group enabled) |
| [15:22:13] | <mstenta[m]> | I wanted to see what you think about this... basically I am proposing: |
| [15:22:13] | <mstenta[m]> | 1. Open a new `2.x` branch in https://github.com/farmOS/farm_eggs |
| [15:22:13] | <mstenta[m]> | 2. Cherry pick your commit: https://github.com/mstenta/farm_eggs/commit/7b1ce619e9c87b160a3178dd4e33... |
| [15:22:13] | <mstenta[m]> | 3. Add one more commit that makes `farm_group` dependency optional |
| [15:23:48] | <mstenta[m]> | I sort of see this as a temporary solution. It would allow me to migrate the remaining Farmier sites to v2. But I probably won't make the farm_eggs module available to everyone yet. |
| [15:24:49] | <mstenta[m]> | Longer-term, I've been putting some work into a new feature in farmOS core: "configurable quick forms" |
| [15:25:26] | <mstenta[m]> | Basically, a framework that allows quick forms to save configuration in a standard way. The egg module was one of the main motivations for that, actually. |
| [15:26:00] | <mstenta[m]> | Rather than adding a produces_eggs field to all animal and group assets, we could make that a configuration option specific to the quick form. |
| [15:26:19] | <mstenta[m]> | So maybe that would be the future of a simple egg quick form... |
| [15:27:49] | <mstenta[m]> | I remember you said in the forum: |
| [15:27:49] | <mstenta[m]> | > At this point I should probably just change the namespace of my fork and maybe contribute back parts of it to the main repo. |
| [15:27:49] | <mstenta[m]> | https://farmos.discourse.group/t/contrib-modules-tools-list/1531/9 |
| [15:28:03] | <mstenta[m]> | So... maybe your module could become the advanced egg quick form module? :-) |
| [15:29:41] | <mstenta[m]> | If we do end up adding a simple egg quick form to farmOS core, then we could deprecate farm_eggs and I would essentially help the farms I host move over to the core form. |
| [15:29:53] | <mstenta[m]> | wotnak: What do you think? |
| [15:43:13] | <wotnak[m]> | <mstenta[m]> "wotnak: What do you think?" <- looks like a good plan, it will quickly get us egg quick form feature parity with the v1, and then further improvements can be introduced later |
| [15:43:13] | <wotnak[m]> | including simple egg quick form with basic functionality that most users will find useful in core and keeping more advanced options that only some will need in contrib also makes sense |
| [15:43:35] | <mstenta[m]> | Awesome! |
| [15:44:40] | <mstenta[m]> | I have a fork that I just pushed my commits to: https://github.com/mstenta/farm_eggs/tree/2.x |
| [15:44:53] | <mstenta[m]> | I found a small bug with the permission, so I fixed that too |
| [15:46:12] | <mstenta[m]> | If it looks good to you, I'll push to https://github.com/farmOS/farm_eggs |
| [15:46:22] | <mstenta[m]> | And make 2.x the default branch there |
| [15:48:49] | <wotnak[m]> | looks good |
| [15:49:06] | <mstenta[m]> | Thanks! |