| [03:32:17] | * farmBOT has joined #farmos |
| [10:50:34] | <mstenta[m]> | symbioquine paul121 I responded to your comments in both PRs (#568 + #622) |
| [10:51:06] | <mstenta[m]> | I think #568 (and related #577) are ready to go. |
| [10:51:12] | <mstenta[m]> | #622 seems like it's going to require more thought. |
| [12:30:26] | <mstenta[m]> | Update: tests are passing on Drupal 9.5.x - I think this is ready to merge too: https://github.com/farmOS/farmOS/pull/621 |
| [16:13:36] | <mstenta[m]> | Thanks for reviewing those PRs symbioquine paul121 ! |
| [16:13:57] | <paul121[m]> | one sec, looking at group membership now.. might have one issue |
| [16:14:10] | <mstenta[m]> | Oh cool - was just going to ask about that one. :-) |
| [16:14:36] | <mstenta[m]> | I'm still trying to think up options for the CSV one... feeling a bit stumped on it |
| [16:21:27] | <paul121[m]> | left a comment |
| [16:22:28] | <paul121[m]> | basically, are we covering the original simple/non-recursive case reported in #541?... (full message at <https://libera.ems.host/_matrix/media/v3/download/libera.chat/f5cad63a21...) |
| [16:22:40] | <paul121[m]> | where log.group == log.asset |
| [16:23:40] | <mstenta[m]> | oh! well i'll be... 🤦 |
| [16:23:41] | <mstenta[m]> | i'll add a test for that |
| [16:23:48] | <mstenta[m]> | good catch paul121 |
| [16:24:50] | <symbioquine[m]> | It's always the edge cases :) |
| [16:25:54] | <paul121[m]> | cool, didn't see a test and wasn't sure if it was covered elsewhere! |
| [16:28:46] | <mstenta[m]> | in this case the "edge case" is the original case haha |
| [16:28:46] | <mstenta[m]> | yea i did add tests for this generally, but not for that case one specifically |
| [16:36:46] | <paul121[m]> | And I wonder, is this same thing needed for location? |
| [16:40:13] | <mstenta[m]> | Was just going to ask that |