| [21:22:45] | * Owsley has joined #farmos |
| [21:23:03] | * Owsley is now known as polo |
| [21:56:55] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [04:19:00] | * ionitatelecom[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:00] | * r3c4ll[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:00] | * paul121[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:00] | * ander[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:00] | * Mo[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:00] | * RafatKhashan[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:01] | * perfectinfoseeke has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:03] | * jgaehring[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:03] | * GudjonEinarMagnu has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:03] | * evered[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:03] | * symbioquine[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:04] | * FarmerEd[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:04] | * mstenta[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:04] | * dazinism[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:19:08] | * scrdcow[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [04:24:33] | * calbasi[m] has joined #farmos |
| [04:43:47] | * dazinism[m] has joined #farmos |
| [04:43:47] | * spitz234[m] has joined #farmos |
| [04:43:48] | * ChinchillaWashin has joined #farmos |
| [04:43:59] | * mstenta[m] has joined #farmos |
| [04:43:59] | * paul121[m] has joined #farmos |
| [04:43:59] | * FarmerEd[m] has joined #farmos |
| [04:43:59] | * symbioquine[m] has joined #farmos |
| [04:43:59] | * RafatKhashan[m] has joined #farmos |
| [04:43:59] | * jgaehring[m] has joined #farmos |
| [04:43:59] | * scrdcow[m] has joined #farmos |
| [04:43:59] | * r3c4ll[m] has joined #farmos |
| [04:44:00] | * ander[m] has joined #farmos |
| [04:44:00] | * gbathree[m] has joined #farmos |
| [04:44:00] | * evered[m] has joined #farmos |
| [04:44:00] | * Mo[m] has joined #farmos |
| [04:44:01] | * perfectinfoseeke has joined #farmos |
| [04:44:01] | * GudjonEinarMagnu has joined #farmos |
| [04:44:01] | * ionitatelecom[m] has joined #farmos |
| [06:49:08] | * nzsnowman[m] has joined #farmos |
| [06:49:09] | <nzsnowman[m]> | hi there. |
| [06:49:09] | <farmBOT> | que tal |
| [06:49:22] | * AnasHaddad[m] has joined #farmos |
| [06:49:36] | * kunigunde[m] has joined #farmos |
| [06:49:54] | * farmtech[m] has joined #farmos |
| [06:50:04] | <nzsnowman[m]> | Anyone here ? |
| [06:50:04] | <nzsnowman[m]> | I'm completely new to farmOS, and I need some help.... |
| [06:50:06] | * postmanpat[m] has joined #farmos |
| [06:50:19] | * munjoma[m] has joined #farmos |
| [06:50:31] | * IyarkaiTechLab[m has joined #farmos |
| [06:50:44] | * Adam[m]12 has joined #farmos |
| [06:50:56] | * CarlosAlberto[m] has joined #farmos |
| [06:51:01] | <nzsnowman[m]> | is this the right place for user enquiries ? |
| [06:51:09] | * runfastthinkslow has joined #farmos |
| [06:51:21] | * nickhudson[m] has joined #farmos |
| [06:51:34] | * SpencerOnazi[m] has joined #farmos |
| [06:51:48] | * OmkarEkbote[m] has joined #farmos |
| [06:52:01] | * petednz[m] has joined #farmos |
| [06:52:13] | * and712[m] has joined #farmos |
| [06:52:26] | * Anonymous[m]12 has joined #farmos |
| [06:52:39] | * davd[m] has joined #farmos |
| [06:52:51] | * frederike[m] has joined #farmos |
| [06:53:04] | * goldi[m] has joined #farmos |
| [06:53:17] | * gretel[m] has joined #farmos |
| [06:53:29] | * gunter[m] has joined #farmos |
| [06:53:41] | * harry[m]1 has joined #farmos |
| [06:53:53] | * hra38192639[m] has joined #farmos |
| [06:54:07] | * iuresearcherpw[m has joined #farmos |
| [06:54:20] | * mindcls[m] has joined #farmos |
| [06:54:32] | * olaf[m]1 has joined #farmos |
| [06:54:44] | * phantomse[m] has joined #farmos |
| [06:54:56] | * raul[m] has joined #farmos |
| [06:55:08] | * skipper_is[m] has joined #farmos |
| [06:55:20] | * steinfarm[m] has joined #farmos |
| [06:55:33] | * AllanMacGregor[m has joined #farmos |
| [06:55:46] | * qoyyuum[m] has joined #farmos |
| [06:55:58] | * shane_aldrich[m] has joined #farmos |
| [06:56:10] | * toino[m] has joined #farmos |
| [06:56:24] | * aislinnpearson[m has joined #farmos |
| [06:56:36] | * JanSonntag[m] has joined #farmos |
| [06:56:50] | * ludwa6[m] has joined #farmos |
| [06:57:03] | * thattechguy[m] has joined #farmos |
| [06:57:15] | * Noaht[m] has joined #farmos |
| [06:57:27] | * ChristophWolfes[ has joined #farmos |
| [06:57:39] | * matrixtrix[m] has joined #farmos |
| [06:57:51] | * sgoodall[m] has joined #farmos |
| [06:58:08] | * oliverp44[m] has joined #farmos |
| [06:58:20] | * FreshiesFarmsLLC has joined #farmos |
| [06:58:32] | * RogerioMbuli[m] has joined #farmos |
| [06:58:45] | * MarcosCarballal[ has joined #farmos |
| [06:58:57] | * FeiWang[m] has joined #farmos |
| [06:59:09] | * UgeshB[m] has joined #farmos |
| [06:59:21] | * margeo[m] has joined #farmos |
| [06:59:33] | * donblair[m] has joined #farmos |
| [06:59:45] | * justgav[m] has joined #farmos |
| [06:59:59] | * JustGav[m]1 has joined #farmos |
| [07:00:11] | * m035[m] has joined #farmos |
| [07:00:23] | * TheSlurpee[m] has joined #farmos |
| [07:00:35] | * EvanKelley[m] has joined #farmos |
| [07:00:47] | * ZaneBelkhayat[m] has joined #farmos |
| [07:01:02] | * elpronto[m] has joined #farmos |
| [07:01:15] | * dzfarmer[m] has joined #farmos |
| [07:01:28] | * courtneylking[m] has joined #farmos |
| [07:01:40] | * testuser769[m] has joined #farmos |
| [07:01:54] | * GuilhermePerotta has joined #farmos |
| [07:02:06] | * monkeyflowerfarm has joined #farmos |
| [07:02:19] | * botlfarm[m] has joined #farmos |
| [07:02:31] | * MattFletcher[m] has joined #farmos |
| [07:02:44] | * tool172[m] has joined #farmos |
| [07:02:56] | * ggcc18[m] has joined #farmos |
| [07:03:08] | * thattechguy99[m] has joined #farmos |
| [07:03:20] | * ThimmZwiener[m] has joined #farmos |
| [07:03:33] | * leku[m] has joined #farmos |
| [07:03:46] | * sandg100[m] has joined #farmos |
| [07:03:58] | * eddieironsmith[m has joined #farmos |
| [07:04:10] | * GerardoLisboa[m] has joined #farmos |
| [07:04:22] | * JustinCampbell[m has joined #farmos |
| [07:04:35] | * KarsonWynne[m] has joined #farmos |
| [07:04:47] | * BrandonSmith[m] has joined #farmos |
| [07:04:59] | * leogaggl[m] has joined #farmos |
| [07:24:50] | <mstenta[m]> | Welcome nzsnowman |
| [07:25:00] | <mstenta[m]> | Sure! |
| [07:34:26] | <mstenta[m]> | Ah just saw your forum post - will follow up there |
| [08:00:05] | * farmBOT has quit (Ping timeout: 252 seconds) |
| [08:00:30] | * farmBOT has joined #farmos |
| [09:10:27] | <mstenta[m]> | paul121: shall we pull the trigger? https://github.com/farmOS/farmOS/pull/566 |
| [10:38:04] | <paul121[m]> | Yeah, if it's all working, don't see why not |
| [10:38:50] | <paul121[m]> | I'll have time today to test it a bit. but it would be easier if we merge it in first |
| [10:39:15] | <mstenta[m]> | Yea I'm thinking we merge it then test locally to make sure nothing obvious is broken |
| [10:39:26] | <mstenta[m]> | I trust it, for the most part |
| [10:39:39] | <mstenta[m]> | All tests are passing, so that's a good indication |
| [10:40:08] | <paul121[m]> | Yeah same. The functionality of dependencies that are not under our test coverage is mostly what I think of |
| [10:40:34] | <mstenta[m]> | Well if this uncovers anything it will be a good reason to add test coverage! |
| [10:40:50] | <mstenta[m]> | I'll go ahead and merge |
| [10:40:57] | <mstenta[m]> | Also, I'm playing with PHPStan... :-) |
| [10:41:43] | <paul121[m]> | Oh cool! re: PHP 8? |
| [10:43:24] | <mstenta[m]> | Yea that's what inspired it... but might add it before then as a compliment to our normal codesniffer step in GitHub Actions |
| [10:43:35] | <mstenta[m]> | But yea, I'm curious if it will catch any potential PHP 8 issues |
| [10:44:48] | <mstenta[m]> | paul121: Dunno if you saw this morning but PHP GEOS support PHP 8 now! |
| [10:45:11] | <mstenta[m]> | So the only remaining blocker is (afaik): https://www.drupal.org/project/farm/issues/3282186 |
| [10:45:46] | <paul121[m]> | oh wonderful |
| [10:46:05] | <mstenta[m]> | (sarcasm? hahaha) |
| [10:46:17] | <paul121[m]> | I'm not that far down my email yet 🤣 |
| [10:46:25] | <paul121[m]> | no that's great! |
| [10:46:56] | <mstenta[m]> | i rebased my simple oauth branch and pushed to the d.o issue as a MR so we can work on it there |
| [10:46:56] | <paul121[m]> | mstenta[m]: oh.... |
| [10:48:25] | <paul121[m]> | well they also just released 6.0.0-alpha3 Sept 1 |
| [10:48:34] | <paul121[m]> | I'm not sure if that means it is close to be ready, or still a ways out |
| [10:48:44] | <paul121[m]> | but maybe we could jump straight to that |
| [10:49:33] | <mstenta[m]> | whoa |
| [10:49:40] | <mstenta[m]> | that's a full re-write, yea? |
| [10:51:36] | <paul121[m]> | 5.2 might not be too hard to figure out though. Last I remember I couldn't even get their tests to run in my environment, so it wasn't really possible to write/debug tests extending their logic. Our test logic basically re-runs their tests with the customizations we add to `consumer` entities |
| [10:51:48] | <paul121[m]> | mstenta[m]: at least partially |
| [10:51:57] | <paul121[m]> | still oauthlib under the hood |
| [10:52:21] | <paul121[m]> | but making the scope control much more flexible (not only tied to roles) |
| [10:55:52] | <mstenta[m]> | Ah yea, that rings a bell re: simple_oauth 5.2 tests |
| [10:55:59] | <mstenta[m]> | that's awesome re: v6 |
| [10:56:18] | <mstenta[m]> | maybe we can sprint on 5.2 a little during this week's dev call? |
| [10:56:34] | <mstenta[m]> | FYI PHPStan results: https://github.com/mstenta/farmOS/runs/8308477439?check_suite_focus=true |
| [10:56:41] | <mstenta[m]> | lots of stuff to fix 😅 |
| [10:56:51] | <mstenta[m]> | but kinda exciting! |
| [11:00:35] | <paul121[m]> | that's great. not sure why the "\Drupal calls should be avoided..." wasn't caught with codesniffer? |
| [11:00:44] | <paul121[m]> | Maybe the drupal code sniffer only checks that in some classes? |
| [11:01:04] | <mstenta[m]> | hmm not sure - haven't looked closely at everything yet... opening an issue for adding this generally |
| [11:02:13] | <mstenta[m]> | https://www.drupal.org/project/farm/issues/3309234 |
| [11:03:08] | <paul121[m]> | this Gin "modern horizontal" toolbar is great! |
| [11:03:17] | <paul121[m]> | ACTION uploaded an image: (178KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/PUaHanPKsYo... > |
| [11:03:21] | <paul121[m]> | I think that is new? |
| [11:04:08] | <paul121[m]> | re: the logo CSS, it would be nice if we didn't need anything custom... |
| [11:04:28] | <paul121[m]> | Ideally Gin's css can work with most images to make them fit |
| [11:04:41] | <paul121[m]> | this would also make it easier to add custom non-farmos logos :-) |
| [11:05:03] | <paul121[m]> | just to say - before adding/changing CSS, lets try removing our CSS and see how it looks :-) |
| [11:05:34] | <mstenta[m]> | Sounds good - IIRC we added the CSS because Gin beta made it look bad |
| [11:13:59] | <mstenta[m]> | paul121: Ah looks like they just marked simple_oauth 5.0.6 unsupported - so now a big red error appears :-P |
| [11:14:31] | <mstenta[m]> | ACTION uploaded an image: (30KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/jmAlwZieIqm... > |
| [11:17:18] | <paul121[m]> | :-/ |
| [11:50:58] | <mstenta[m]> | Huh... paul121 I wonder why PHPStan doesn't like this: |
| [11:50:59] | <mstenta[m]> | ACTION sent a code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/6deb123ff7... |
| [11:51:17] | <mstenta[m]> | Oooh... the `@internal` bit... |
| [11:51:31] | <mstenta[m]> | Guess we might need to ignore that, since we take responsibility for it |
| [11:52:18] | <mstenta[m]> | ACTION sent a code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/8df2048a88... |
| [12:25:28] | <symbioquine[m]> | Interesting Subrequests bug: https://www.drupal.org/project/subrequests/issues/3059582#comment-14690001 |
| [12:36:31] | <symbioquine[m]> | And the fun change that's blocked on it... 😅 https://github.com/symbioquine/farmOS_asset_link/blob/cc7149e4f666dc8c56... |
| [12:41:48] | <mstenta[m]> | wow! |
| [12:42:23] | <mstenta[m]> | grateful that you are steeped in the Drupal core issue process now symbioquine 😅 |
| [12:42:39] | <mstenta[m]> | * Drupal core/contrib issue |
| [12:43:01] | <mstenta[m]> | if it seems like that patch is going to be accepted, we could potentially include it in farmOS before it's merged |
| [12:48:57] | <symbioquine[m]> | Let's wait a little bit and see if I get a response on that issue... |
| [13:23:11] | <paul121[m]> | Nice! |
| [13:23:34] | <paul121[m]> | <symbioquine[m]> "Let's wait a little bit and..." <- maybe mark it Reviewed & tested? |
| [13:26:33] | <mstenta[m]> | > that's great. not sure why the "\Drupal calls should be avoided..." wasn't caught with codesniffer? |
| [13:26:33] | <mstenta[m]> | it seems that PHPStan catches more.... but still not all of them. if I search the codebase for `Drupal::` (just inside `*.php` files, to avoid hooks), I still get a bunch |
| [13:28:47] | <mstenta[m]> | for example, this one gets flagged: https://github.com/farmOS/farmOS/blob/b495cdb840bd0bc662c1c57205ebcec8f1... |
| [13:29:15] | <mstenta[m]> | but this one does not: https://github.com/farmOS/farmOS/blob/b495cdb840bd0bc662c1c57205ebcec8f1... |
| [13:30:23] | <mstenta[m]> | i'm actually a bit curious what the "right" way to fix the `MapRenderEvent` one is... just add a $entity_type_manager` param to the constructor? And then pass it in where we instantiate it? https://github.com/farmOS/farmOS/blob/b495cdb840bd0bc662c1c57205ebcec8f1... |
| [13:30:44] | <mstenta[m]> | s/$/`$/ |
| [13:33:01] | <paul121[m]> | interesting... |
| [13:35:43] | <paul121[m]> | I wonder if it can just implement `ContainerInjectionInterface` and then use the `public static function create($container)` |
| [13:36:11] | <paul121[m]> | I know that is available for for controller classes |
| [13:36:44] | <paul121[m]> | (plugins use `ContainerFactoryPluginInterface`, basically the same) |
| [13:36:59] | <paul121[m]> | but not sure if you slap that interface onto just any class you create.... |
| [13:37:08] | <paul121[m]> | * if you can slap that |
| [13:37:41] | <mstenta[m]> | yea hmm |
| [13:38:48] | <paul121[m]> | s/for// |
| [14:38:44] | <mstenta[m]> | paul121: Any idea what this means? |
| [14:38:47] | <mstenta[m]> | ACTION sent a code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/215609c773... |
| [14:39:18] | <mstenta[m]> | https://github.com/farmOS/farmOS/blob/b495cdb840bd0bc662c1c57205ebcec8f1... |
| [14:45:12] | <mstenta[m]> | Nevermind found this... https://github.com/mglaman/phpstan-drupal/issues/113 |
| [14:48:47] | <mstenta[m]> | Hmm... sounds like we need to call `alterInfo()` in the `__construct()`?? 🤔 |
| [14:52:15] | <mstenta[m]> | Something like this maybe? https://git.drupalcode.org/project/drupal/-/blob/35ba1d5ce77318926c043b6... |
| [15:06:12] | <mstenta[m]> | Ah found another contrib module that dealt with this... looks like we can just do something similar: |
| [15:06:21] | <mstenta[m]> | https://www.drupal.org/project/facets/issues/2981799 |
| [15:06:23] | <mstenta[m]> | https://git.drupalcode.org/project/facets/-/commit/d3016d2c0c23fdbc34c60... |
| [16:45:01] | <paul121[m]> | oh interesting. So this makes it sound like your plugin definition MUST be alterable. That is not how I interpreted the phpstan message |
| [16:45:19] | <mstenta[m]> | Yea |
| [16:45:42] | <mstenta[m]> | I think it's not a great PHPStan message, but that is the case it seems |
| [16:45:43] | <paul121[m]> | I had the impression the `alterInfo()` bit was optional - why add the complexity if we don't need it? |
| [16:45:48] | <paul121[m]> | but we can play nice and include it :-) |
| [16:45:48] | <mstenta[m]> | Yea |
| [16:45:54] | <mstenta[m]> | I have a commit that adds it |
| [16:46:04] | <mstenta[m]> | I'm slowly but surely working my way through all the PHPStan complaints :-) |
| [16:46:11] | <paul121[m]> | awesome!! |
| [16:46:38] | <paul121[m]> | does anyone have thoughts/opinions on this Gin issue re: centering the logo: https://www.drupal.org/project/gin/issues/3309260#comment-14690332 |
| [16:47:29] | <paul121[m]> | I have kinda always thought you would just want the logo centered by default. We've done numerous custom sites/modules and that's what we've always ended up with |
| [16:48:11] | <paul121[m]> | But I do see how a logo that is not a wide rectangle could look nice if it is not centered, and does not expand with the toolbar |
| [16:49:09] | <paul121[m]> | I really want to just upload logo files and not write any CSS code!!! it's seems crazy to me :-) |
| [16:49:20] | <paul121[m]> | s/'s// |
| [17:08:21] | <paul121[m]> | It seems there are maybe 3 logo options:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/fe46ccdf3a...) |
| [18:51:22] | * Owsley has joined #farmos |
| [19:11:40] | * Owsley has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [19:47:08] | <paul121[m]> | ooh! Gin has a hook for providing additional content form routes! https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/gin.api.php#L13-37 |
| [19:47:19] | <paul121[m]> | we may be able to add those sidebars now |
| [19:48:59] | <paul121[m]> | I believe this would also make that Gin description toggle work |
| [19:51:15] | <mstenta[m]> | > would it be reasonable to expose a UI with 2 checkboxes to "Turn on" options 2 and 3? Is that something we might want in farmOS core or no? |
| [19:51:15] | <mstenta[m]> | feels to me like this is outside the scope of farmOS |
| [19:51:59] | <mstenta[m]> | maybe a contrib `farm_whitelabel` module could provide it? or Gin itself |
| [19:51:59] | <paul121[m]> | > <@mstenta:matrix.org> > would it be reasonable to expose a UI with 2 checkboxes to "Turn on" options 2 and 3? Is that something we might want in farmOS core or no? |
| [19:51:59] | <paul121[m]> | > |
| [19:52:00] | <paul121[m]> | > feels to me like this is outside the scope of farmOS |
| [19:52:00] | <paul121[m]> | do I need to make a new module? 😢 |
| [19:52:42] | <mstenta[m]> | feels like it should be Gin if anything |
| [19:53:43] | <paul121[m]> | yeah. well, I think I got the css figured out pretty well. It just needs a home |
| [19:54:44] | <mstenta[m]> | i don't think farmOS should be responsible for making sure this works |
| [19:54:45] | <mstenta[m]> | (unless we make "whitelabeling" a more officially supported use-case i suppose - but i don't feel like that's a core priority right now) |
| [19:58:46] | <mstenta[m]> | sorry caught me at a bad time maybe haha - i've been digging through so much code for PHPStan that i'm in the mindset of "NO MORE CODE" lol |
