| [15:06:42] | <mstenta[m]> | symbioquine: https://github.com/farmOS/farmOS/pull/441 |
| [15:06:49] | <mstenta[m]> | What do you think about this? When you get a chance... |
| [15:07:46] | <mstenta[m]> | paul121 and I were debugging a testing issue in a custom module, and ultimately it was happening because of the different `www-data` user ID in the `www` vs `test-runner` services... |
| [15:08:14] | <mstenta[m]> | Then I couldn't remember why we needed both... so I dug up the old issue: https://www.drupal.org/project/farm/issues/3183687 |
| [15:08:33] | <mstenta[m]> | It was just for disabling XDebug (right?) |
| [15:08:56] | <mstenta[m]> | Then I realized we have another option for doing that now that we're using XDebug 3! The `XDEBUG_MODE` environment variable :-) |
| [15:09:27] | <symbioquine[m]> | Nice 👍 |
| [15:09:37] | <mstenta[m]> | So this PR sketches up that approach, and removes the `test-runner` |
| [15:09:37] | <symbioquine[m]> | mstenta[m]: I think so... |
| [15:09:51] | <symbioquine[m]> | That sounds awesome! |
| [15:10:10] | <mstenta[m]> | Yea - wanted to make sure I wasn't forgetting anything else :-) |
| [15:10:42] | <mstenta[m]> | Tests are running on the PR now... so we can see the speed... I just ran them on my fork and they were as fast (if not faster) than the `test-runner`: https://github.com/mstenta/farmOS/actions/runs/1195369843 |
| [15:11:02] | <mstenta[m]> | (Not a whole lot slower, which is the important thing) |
| [15:12:49] | <symbioquine[m]> | Yeah... happy to look at it closer when I get back to my computer this evening if the PR is still open then, but no pressure either way... :) |
| [15:12:58] | <mstenta[m]> | cool! no rush |
| [15:13:04] | <mstenta[m]> | i need to sign off soon anyway |