| [00:30:43] | * PhongPham[m] has joined #farmos |
| [15:52:26] | <mstenta[m]> | symbioquine: hey just realized we need to add some updates to farmOS-map changelog |
| [15:52:45] | <mstenta[m]> | gotta remember to make that part of PR review process :-) |
| [15:52:48] | <mstenta[m]> | or something |
| [15:53:25] | <mstenta[m]> | OH WAIT |
| [15:53:26] | <mstenta[m]> | nevermind! |
| [15:53:32] | <mstenta[m]> | i was looking at 1.x branch... |
| [15:53:41] | <mstenta[m]> | which is still the default branch on GitHub. I'll update that... |
| [15:53:54] | <mstenta[m]> | (i think?) |
| [15:55:36] | <symbioquine[m]> | 😁 yeah. Maybe we should tag a non-alpha release version before changing the default branch...? |
| [15:55:42] | <mstenta[m]> | yea was just thinking that too |
| [15:55:51] | <mstenta[m]> | any reason to remain in alpha, do you think? |
| [16:02:15] | <symbioquine[m]> | Nothing specific. Might be good for us to reach a conclusion on the dependencies question that was raised in https://github.com/farmOS/farmOS-map/pull/124 |
| [16:03:47] | <symbioquine[m]> | I was also planning to make PRs to automate the push to npm and push to GH pages... But those don't have to be blockers... |
| [16:04:57] | <mstenta[m]> | oh right - thanks for the bump on that! i'll take a look... |
| [16:06:49] | <symbioquine[m]> | That PR itself doesn't need to be a blocker though, just the dependencies question :) |
| [16:07:47] | <mstenta[m]> | paul121: can you remind me... there was a composer package you found that seemed like it might make it possible for us to avoid asset-packagist altogether, is that right? |
| [16:08:51] | <paul121[m]> | oh yeah.. trying to remember how that worked.. |
| [16:08:59] | <paul121[m]> | but I gotta run right now!! |
| [16:09:09] | <mstenta[m]> | cool no rush! |
| [16:09:27] | <mstenta[m]> | at any rate... maybe that will be worth considering, and would sort of sidestep this dependency issue |
| [16:09:41] | <mstenta[m]> | i've never really liked the asset-packagist composer stuff |
| [16:10:15] | <paul121[m]> | IIRC we thought this other solution wouldn't be ideal for contrib modules? |
| [16:10:25] | <mstenta[m]> | if we avoided asset-packagist, then our npm packages wouldn't need to include a built copy of farmOS-map.js too, i think |
| [16:10:38] | <mstenta[m]> | hmm yea maybe |
| [16:10:48] | <mstenta[m]> | might be worth finding the conversation in the logs for this room |
| [16:10:52] | <mstenta[m]> | irc.farmos.org |
| [16:11:08] | <paul121[m]> | it's out there somewhere :D |
| [16:11:28] | <mstenta[m]> | we can copy it into a new github issue for discussion perhaps |
| [16:22:07] | <mstenta[m]> | found it: https://irc.farmos.org/bot/log/farmOS/2021-06-17#T65062 |
| [16:22:24] | <mstenta[m]> | jeez was that really 2.5 months ago?? |
| [16:25:36] | <mstenta[m]> | https://www.drupal.org/project/farm/issues/3230933 |