| [21:30:25] | <symbioquine[m]> | Awesome, thanks for merging all those pull requests mstenta ! |
| [08:49:49] | <mstenta[m]> | symbioquine: hmm I just noticed something... it appears that sqlite3 is being used for all three of the "Test Drush site install" tasks |
| [08:49:50] | <mstenta[m]> | https://github.com/farmOS/farmOS/runs/1727889231?check_suite_focus=true |
| [08:54:16] | <mstenta[m]> | It appears that maybe `${{ matrix.DB_URL }}` is ending up as `sqlite://localhost/sites/default/files/db.sqlite` in all three... |
| [08:54:34] | <mstenta[m]> | Which means that it may actually be running tests on SQLite in all cases as wel? |
| [08:56:39] | <mstenta[m]> | ACTION sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/gjpwfUAIfFSmYIRX... > |
| [09:02:16] | <mstenta[m]> | I just pushed a `2.x-test` branch that will simply `echo ${{ matrix.dbms }} && echo ${{ matrix.DB_URL }}` |
| [09:02:53] | <mstenta[m]> | However, it appears that GitHub Actions is "experiencing degraded performance" - so might need to wait to see results: https://www.githubstatus.com/ |
| [10:25:31] | <symbioquine[m]> | <mstenta[m] "symbioquine: hmm I just noticed "> :( I'll take a look... |
| [10:31:02] | <mstenta[m]> | Looks like GH Actions is back up |
| [10:31:09] | <mstenta[m]> | I just pushed my `2.x-test` branch again: https://github.com/mstenta/farmOS/actions/runs/496341740 |
| [10:31:47] | <mstenta[m]> | Yea... looks like `matrix.DB_URL` is the same in all three |
| [10:32:28] | <symbioquine[m]> | I think I found the issue |
| [10:35:15] | <symbioquine[m]> | Testing now... https://github.com/symbioquine/farmOS/commit/50a077e5f31a3dc87429e1f3386... |
| [10:38:01] | <symbioquine[m]> | I think it's working; https://github.com/symbioquine/farmOS/runs/1728732878?check_suite_focus=... |
| [10:39:03] | <symbioquine[m]> | ACTION uploaded an image: image.png (13KiB) < https://matrix.org/_matrix/media/r0/download/matrix.org/ZlMQNnntgoiictPO... > |
| [10:39:26] | <symbioquine[m]> | ACTION uploaded an image: image.png (16KiB) < https://matrix.org/_matrix/media/r0/download/matrix.org/JnpbWizmdtiCLtRb... > |
| [10:48:51] | <symbioquine[m]> | How do you feel about that logging mstenta ? I can PR as-is or remove that part first... |
| [10:53:07] | <symbioquine[m]> | https://github.com/farmOS/farmOS/pull/402 |
| [10:59:43] | <mstenta[m]> | symbioquine: hey sorry getting caught up - I have calls all morning :-) |
| [10:59:48] | <mstenta[m]> | about to hop on another |
| [10:59:59] | <symbioquine[m]> | No worries/rush :) |
| [11:00:33] | <mstenta[m]> | Re: logs - doesn't hurt to have them i suppose! |
| [11:00:38] | <mstenta[m]> | i'll merge this - looks good - thanks! |
| [11:01:24] | <mstenta[m]> | (gonna wait to confirm the PR test passes... thanks again @paul121 for fixing that!) |
| [11:02:22] | <symbioquine[m]> | That's awesome! I guess I wasn't following as closely as I thought - last I saw you were reverting something related to that... |
| [11:03:07] | <mstenta[m]> | Oh yea just one of the two commits got reverted |
| [11:03:12] | <mstenta[m]> | The first commit is what fixed the PR testing |
| [11:03:25] | <symbioquine[m]> | Cool |
| [11:03:42] | <paul121[m]> | tests are lookin gooooood! 👏 |
| [11:04:12] | <mstenta[m]> | yea so happy to have all this testing infra in place :-D |
| [11:04:19] | <mstenta[m]> | just generally |
| [11:06:08] | <mstenta[m]> | Oh symbioquine and paul121 small request: when applicable (single commit PRs) can you make sure it has the issue/PR # at the end? so it's easy to link back to it and relevent discussions in the future |
| [11:24:18] | <mstenta[m]> | For multi-commit PRs, generally what I'll do is a `--no-ff` merge, so that a merge commit gets created, and add the issue name/number as the merge commit message, which helps to show in the history what a group of changes was for |
| [11:24:52] | <mstenta[m]> | (these commit message formats differ for GitHub issues vs Drupal.org issues, but same basic idea) |
| [11:32:09] | <symbioquine[m]> | Maybe that should be in https://github.com/farmOS/farmOS/blob/7.x-1.x/CONTRIBUTING.md ? |
| [11:32:33] | <mstenta[m]> | indeed! good point |
| [11:33:16] | <symbioquine[m]> | I assume that file will get copied over to the 2.x branch too at some point... |
| [11:33:56] | <mstenta[m]> | yes! https://www.drupal.org/project/farm/issues/3162606 |
