| [06:01:17] | * farmBOT has joined #farmos |
| [08:02:54] | * farmtech[m] has quit (Ping timeout: 258 seconds) |
| [08:02:56] | * abugida[m] has quit (Ping timeout: 240 seconds) |
| [08:02:56] | * wombat83[m] has quit (Ping timeout: 240 seconds) |
| [08:03:05] | * jolau[m] has quit (Ping timeout: 240 seconds) |
| [08:03:06] | * jonzet[m] has quit (Ping timeout: 240 seconds) |
| [08:03:06] | * zedrickr11[m] has quit (Ping timeout: 240 seconds) |
| [08:03:06] | * jgaehring[m] has quit (Ping timeout: 240 seconds) |
| [08:03:12] | * munjoma[m] has quit (Ping timeout: 244 seconds) |
| [08:03:12] | * symbioquine[m] has quit (Ping timeout: 244 seconds) |
| [08:03:13] | * sydney_zimbotech has quit (Ping timeout: 244 seconds) |
| [08:03:17] | * spitz234[m] has quit (Ping timeout: 258 seconds) |
| [08:03:17] | * jcalonso[m] has quit (Ping timeout: 258 seconds) |
| [08:03:17] | * mstenta[m] has quit (Ping timeout: 260 seconds) |
| [08:03:38] | * generalredneck[m has quit (Ping timeout: 264 seconds) |
| [08:03:38] | * lauriexwayne[m] has quit (Ping timeout: 264 seconds) |
| [08:03:39] | * kunigunde[m] has quit (Ping timeout: 258 seconds) |
| [08:03:43] | * braught[m] has quit (Ping timeout: 244 seconds) |
| [08:03:43] | * leogaggl[m] has quit (Ping timeout: 244 seconds) |
| [08:03:45] | * calbasi_matrix has quit (Ping timeout: 268 seconds) |
| [08:03:45] | * spiffyman[m] has quit (Ping timeout: 268 seconds) |
| [08:03:45] | * paul121[m] has quit (Ping timeout: 268 seconds) |
| [08:05:25] | * JulianF has quit (Ping timeout: 240 seconds) |
| [08:05:26] | * dazinism has quit (Ping timeout: 240 seconds) |
| [08:23:16] | * spiffyman[m] has joined #farmos |
| [08:28:52] | * kunigunde[m] has joined #farmos |
| [08:28:53] | * spitz234[m] has joined #farmos |
| [08:34:25] | * spiffyman[m] has quit (Ping timeout: 240 seconds) |
| [08:35:04] | * kunigunde[m] has quit (Ping timeout: 240 seconds) |
| [08:40:11] | * spitz234[m] has quit (Ping timeout: 260 seconds) |
| [08:53:49] | * farmtech[m] has joined #farmos |
| [08:55:34] | * abugida[m] has joined #farmos |
| [08:55:35] | * wombat83[m] has joined #farmos |
| [08:55:48] | * mstenta[m] has joined #farmos |
| [08:55:52] | * jcalonso[m] has joined #farmos |
| [08:56:43] | * JulianF has joined #farmos |
| [08:56:56] | * dazinism has joined #farmos |
| [08:57:45] | * jolau[m] has joined #farmos |
| [08:57:47] | * zedrickr11[m] has joined #farmos |
| [08:57:47] | * jonzet[m] has joined #farmos |
| [08:57:51] | * jgaehring[m] has joined #farmos |
| [08:58:04] | * munjoma[m] has joined #farmos |
| [08:58:05] | * symbioquine[m] has joined #farmos |
| [08:58:07] | * sydney_zimbotech has joined #farmos |
| [08:58:18] | * generalredneck[m has joined #farmos |
| [08:58:18] | * lauriexwayne[m] has joined #farmos |
| [08:58:23] | * paul121[m] has joined #farmos |
| [08:58:39] | * leogaggl[m] has joined #farmos |
| [08:58:39] | * braught[m] has joined #farmos |
| [08:59:12] | * calbasi_matrix has joined #farmos |
| [09:03:14] | * spiffyman[m] has joined #farmos |
| [09:03:31] | * spitz234[m] has joined #farmos |
| [09:05:43] | * kunigunde[m] has joined #farmos |
| [11:41:51] | <mstenta[m]> | symbioquine: question about `paratest`... |
| [11:42:27] | <mstenta[m]> | i see the PR uses the `--functional` flag |
| [11:43:16] | <mstenta[m]> | > Given you have few testcases (classes) with many long running methods, you should use the `-f` option to enable the `functional mode` and allow different methods of the same class to be executed in parallel. Keep in mind that the default is per-testcase-parallelization to address inter-testmethod dependencies. Note that in most projects, using `-f` is slower since each test method will need to be bootstrapped separately. |
| [11:43:20] | <mstenta[m]> | https://github.com/paratestphp/paratest |
| [11:43:37] | <mstenta[m]> | Did you happen to test without that? Curious what difference it makes... |
| [11:43:53] | <mstenta[m]> | (Not a blocker to merging this PR, but maybe worth following up?) |
| [11:45:12] | <mstenta[m]> | The other question: in the first PR, it had `--processes=16` - but not in the second PR. Should that be included? |
| [11:46:47] | <symbioquine[m]> | I dropped the `--processes=16` because it didn't seem to be making a big difference on the GitHub actions run times - locally it made a huge difference but I assume that's because I have more cores available than the GitHub actions have allocated for each job. |
| [11:47:10] | <mstenta[m]> | Gotcha - cool |
| [11:47:45] | <symbioquine[m]> | And I assume there must have been different bottlenecks where more parallel jobs without more cores didn't help the GitHub actions throughput. |
| [11:49:22] | <symbioquine[m]> | I vaguely seem to recall the `--functional` flag did improve performance, but haven't tested that in a while. Can we make that a follow-up change? I'm happy to test again and send another PR to remove the flag if it isn't helping performance... |
| [11:49:39] | <mstenta[m]> | Sure! Sounds good! |
| [11:49:52] | <mstenta[m]> | Yea didn't really look at it last time but noticed it and was curious |
| [11:50:10] | <mstenta[m]> | It'll be easier to test if that makes a difference in a followup |
| [11:50:53] | <symbioquine[m]> | yep |
| [11:52:41] | <mstenta[m]> | merge the `composer-project` PR - gonna test the `farmOS` commit on my fork now |
| [11:52:45] | <mstenta[m]> | * merged the `composer-project` PR - gonna test the `farmOS` commit on my fork now |
| [11:53:01] | <symbioquine[m]> | Cool |