| [23:00:17] | * farmBOT has joined #farmos |
| [15:37:11] | <barkerd427[m]> | Here's a PR for farmos.py to fix some nits: https://github.com/farmOS/farmOS.py/pull/71 |
| [16:12:43] | <mstenta[m]> | Awesome thanks barkerd427! |
| [16:14:00] | <mstenta[m]> | I'll try to manually test soon... |
| [16:15:04] | <mstenta[m]> | Makes me think... I wonder how hard it would be to modify our tests so that they run once w/ new tests but not changes, and once with tests+changes... to be able to quickly see that both a) the tests demonstrate the issue, and b) the fix fixes it. |
| [16:15:50] | <mstenta[m]> | Drupal.org has the option for module tests I believe... I have to imagine we could do the same in Python / GitHub Actions... |
| [16:38:36] | <barkerd427[m]> | Hmmm, so the tests should fail on the original code but pass on the new code? |
| [16:38:53] | <mstenta[m]> | Yea ideally! |
| [16:39:35] | <barkerd427[m]> | I have never done that, but it seems like a useful view. |
| [16:39:38] | <mstenta[m]> | I mean yes: they should always do that in order to prove (a) and (b). But ideally we could demonstrate that automatically with GitHub Actions... :-) |
| [16:39:54] | <mstenta[m]> | This is outside the scope of your PR of course... |
| [16:40:03] | <mstenta[m]> | Just thinking about how to make processes easier, as always :-) |
| [16:43:13] | <barkerd427[m]> | Yep, agreed. It seems like it would be pretty easy, but I haven't been in the GitHub space in years, so I'm not quite sure how it all behaves. |
| [16:45:47] | <barkerd427[m]> | I also pushed small updates to farm_digest and farmhand today. Mostly bug fixes and tagging the 1.0.0 on farm_digest. I'm learning how to get the farm_digest module onto the drupal listings, but I'm not sure what is appropriate today before approvals//acceptance. |
| [16:46:24] | <mstenta[m]> | We don't have this for our farmOS tests either... (I've just seen that Drupal.org offers it as an option) so I'm mainly just curious to think about how it would work, and if it would be easy to implement in both contexts |
| [16:46:55] | <mstenta[m]> | Oh cool! Yea I was going to mention that at some point: there are benefits to creating an official project on drupal.org... |
| [16:47:10] | <mstenta[m]> | 1. You get translations through localize.drupal.org automatically for UI strings |
| [16:47:36] | <mstenta[m]> | 2. Users can install simply with `composer require drupal/farm_digest` |
| [16:48:03] | <mstenta[m]> | 3. You can add it to the "farmOS ecosystem" https://www.drupal.org/project/farm/ecosystem |
| [16:49:06] | <barkerd427[m]> | Ah, cool. I was mostly thinking it would be easier to install, but the others are great, too. |