| [23:55:17] | * farmBOT has joined #farmos |
| [10:21:28] | <mstenta[m]> | symbioquine paul121 what do you think about merging https://github.com/farmOS/farmOS/pull/849 and then working on the farm asset bulk assignment form changes in a separate PR? |
| [10:21:48] | <mstenta[m]> | That's the only remaining piece |
| [10:23:51] | <mstenta[m]> | We have a pretty good plan for the bulk assignment logic, I think, but it probably warrants some more dedicated thought and discussion |
| [10:24:40] | <mstenta[m]> | And IMO it doesn't need to hold up the organization PR. |
| [10:25:15] | <symbioquine[m]> | I think that makes sense. Just to be clear, the organization PR would go forward with just the existing admin form? |
| [10:25:34] | <mstenta[m]> | (part of my motivation here is just trying to simplify things in my head... I'm trying to get other PRs ready to merge, but everything is held up on the org PR) |
| [10:25:46] | <symbioquine[m]> | and that would get removed in a subsequent PR which introduces the bulk form/logic we were talking about? |
| [10:25:54] | <symbioquine[m]> | all of this pre-4.0? |
| [10:26:04] | <mstenta[m]> | symbioquine: There is a bulk assignment form included in the PR... the only issue is that users may hit the constraints when they use it |
| [10:26:38] | <mstenta[m]> | So really the only thing left is easing some of that... which only really affects a hypothetical subset of users |
| [10:27:11] | <mstenta[m]> | 1. Those who want to install this module on an existing instance with assets that they want to assign to a farm. |
| [10:27:39] | <mstenta[m]> | 2. Those who accidentally forget to assign assets to a farm when they create them, and then run into the constraints when they try to later. |
| [10:28:32] | <mstenta[m]> | symbioquine[m]: What do you mean by "existing admin form"? I proposed an admin form in the PR but never created it. We have an existing bulk assignment form, but it's somewhat limited by the constraint logic now. |
| [10:29:09] | <symbioquine[m]> | mstenta[m]: Ah, okay that makes sense. I think I got that backwards in my head. |
| [10:29:40] | <mstenta[m]> | symbioquine[m]: Ideally we'd add logic to the bulk assignment form to work around the constraints pre-4.0 yes, but whether or not that's a hard 4.0.0 blocker is open for debate |
| [10:29:48] | <symbioquine[m]> | That all sounds good then. |
| [10:30:20] | <symbioquine[m]> | Yeah, doesn't need to be pre-4.0 then since we'd just be relaxing a constraint - which arguably isn't a breaking change. |
| [10:31:17] | <mstenta[m]> | Yea exactly. |
| [10:31:24] | <symbioquine[m]> | We should get that PR preventing revision reversion in pre-4.0 though I guess. |
| [10:31:42] | <mstenta[m]> | Yea agreed |
| [10:33:28] | <symbioquine[m]> | I guess I should skim through it since I'm not sure I've even read all the current code outside of a dev-call screenshare... |
| [10:33:41] | <symbioquine[m]> | I'll try to do that this morning. |
| [10:33:43] | <mstenta[m]> | The org PR you mean? |
| [10:33:48] | <symbioquine[m]> | yes |
| [10:33:56] | <mstenta[m]> | Cool |
| [10:34:47] | <mstenta[m]> | Yea, it's pretty isolated generally... two new modules: modules/core/organization (which is pretty much just copied from asset) and modules/organization/farm (the farm organization bundle) |
| [10:35:33] | <mstenta[m]> | But also adding support for the new organization entity type in a bunch of other places |
| [10:37:15] | <mstenta[m]> | I'm around if you want to go through it together (or on the dev call) |
| [10:38:49] | <symbioquine[m]> | Cool, I'm trying to finish something else up first. If I don't get to it before then, I'll look over it during the dev call. |
| [10:39:31] | <mstenta[m]> | I'll try to dig a bit deeper into the revision PR |
| [11:51:00] | <mstenta[m]> | @room The farmOS weekly dev call starts in 10 minutes - all are welcome! https://meet.jit.si/farmos-dev |
| [15:32:24] | <mstenta[m]> | The organization PR is merged! 🎉 |
| [15:32:38] | <mstenta[m]> | I'm in the process of rebasing my other branches, and opening new PRs... |
| [15:32:59] | <mstenta[m]> | I will open a draft PR with the work I have started on the farm bulk assignment action improvements, so we can continue that effort... |
| [15:33:40] | <mstenta[m]> | My first priority is getting a few cleanup PRs merged, since they touch a lot of code, so it doesn't make sense to do much else until they are done. |
| [15:33:45] | <mstenta[m]> | Here is the first: https://github.com/farmOS/farmOS/pull/1005 |
| [15:34:08] | <mstenta[m]> | After that, I have a branch for using service autowiring |
| [15:34:19] | <mstenta[m]> | And one that refactors all our procedural hooks into Hook classes |
| [15:35:27] | * aapi[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:35:27] | * symbioquine[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:35:27] | * chhoeunchamroeun[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:35:27] | * jk[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:35:27] | * FarmerEd[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:35:27] | * NancyRussell[m] has quit (reticulum.oftc.net helix.oftc.net) |
| [15:36:42] | * aapi[m] has joined #farmos |
| [15:36:42] | * symbioquine[m] has joined #farmos |
| [15:36:42] | * chhoeunchamroeun[m] has joined #farmos |
| [15:36:42] | * jk[m] has joined #farmos |
| [15:36:42] | * FarmerEd[m] has joined #farmos |
| [15:36:42] | * NancyRussell[m] has joined #farmos |
| [16:04:42] | * symbioquine[m] has joined #farmos |
| [16:36:10] | * chhoeunchamroeun[m] has joined #farmos |
| [16:36:46] | * aapi[m] has joined #farmos |
| [16:59:06] | <mstenta[m]> | Here is the second: https://github.com/farmOS/farmOS/pull/1006 |
| [17:03:41] | * jk[m] has joined #farmos |
| [17:04:22] | * NancyRussell[m] has joined #farmos |
| [17:14:38] | * FarmerEd[m] has joined #farmos |
| [17:32:12] | <mstenta[m]> | And the third: https://github.com/farmOS/farmOS/pull/1007 |