| [10:11:18] | <MiriamNugent[m]> | paul121 mstenta I applied the updated organization PR and tweaked farm_multitenant so it works with the latest changes. The new farm_worker permissions work perfectly. Thanks! |
| [10:16:19] | <mstenta[m]> | Great! |
| [10:16:40] | <mstenta[m]> | FYI paul121 symbioquine I found this yesterday: https://www.drupal.org/node/3521395 |
| [10:16:59] | <mstenta[m]> | tl;dr: I think when we update to PHP 8.4 we'll also need to update to PHPUnit 11. |
| [10:19:04] | <symbioquine[m]> | Out of curiosity, were you finding stuff breaking without it? |
| [10:19:36] | <mstenta[m]> | I haven't tried PHP 8.4 yet. |
| [10:21:25] | <mstenta[m]> | Also FYI the two things we tried yesterday didn't fix the failing tests :-/ |
| [10:21:26] | <mstenta[m]> | https://github.com/mstenta/farmOS/actions/runs/15070038551/job/42365400865 |
| [10:22:37] | <mstenta[m]> | The mink args tweak did help a little... because the sed command worked this time... but instead of the tests being skipped they failed. Seems like chrome couldn't be reached. |
| [10:23:06] | <symbioquine[m]> | Hmmm, maybe multiple issues there |
| [10:23:31] | <mstenta[m]> | (Curious too... should we consider switching to Firefox? Wonder if we could finally resolve this: https://github.com/farmOS/farmOS/issues/514) |
| [10:24:21] | <mstenta[m]> | Yea. I'll be traveling until next week so can't look into it anymore. If either of you want to experiment with it you can just clone my 4.x-d11 branch and push to your own fork to run tests. |
| [10:25:22] | <mstenta[m]> | Regarding the other warnings (PHPUnit complaining that classes that end with `*Test`): I got the sed command to successfully add the `<exclude>` lines... but it seems that they didn't work as expected. |
| [10:25:26] | <mstenta[m]> | To be continued... |
| [10:27:49] | <symbioquine[m]> | mstenta[m]: I love Firefox, but that seems like an overreaction unless we have concrete reasons to think Firefox will work better / break less... |
| [10:29:17] | * farmBOT has joined #farmos |
| [10:56:35] | <MiriamNugent[m]> | I've created a beta version of the [farm_multitenant](https://www.drupal.org/project/farm_multitenant) module. It would be great to get some eyes on it. A [core patch](https://www.drupal.org/project/drupal/issues/2920527) for the postgres driver is needed for installation, which I mention on the project page on d.o. I'm not available next week but will be back on the 26th if anyone has questions or suggestions :) |
| [12:17:37] | <paul121[m]> | <mstenta[m]> "The mink args tweak did help a..." <- So... I think chrome driver and etc is working fine. I forgot that I had noticed this earlier - when browser tests run by `paratest` fail, they crash very badly. But when run... (full message at <https://matrix.org/oftc/media/v1/media/download/AUMN4ERl59mc6uzFNUeQu8oF...) |
| [12:18:17] | <paul121[m]> | > <@mstenta:matrix.org> The mink args tweak did help a little... because the sed command worked this time... but instead of the tests being skipped they failed. Seems like chrome couldn't be reached.... (full message at <https://matrix.org/oftc/media/v1/media/download/AaHS6smc-cvnACJTSbqff88T...) |
| [12:19:59] | <paul121[m]> | * So... I think chrome driver and etc is working fine. I forgot that I had noticed this earlier - when browser tests are run by `paratest` and fail, they crash very badly. But when run with just `phpunit` they do not crash... (full message at <https://matrix.org/oftc/media/v1/media/download/AWzd0a-GX9uZnWehBYic6CgT...) |
| [12:23:41] | <paul121[m]> | <MiriamNugent[m]> "paul121 mstenta I applied the..." <- Great! I haven't used the group module before so I'm eager to see how this works. Just was taking a quick look at the repo and noticed you're implementing various views things, mostly for access filtering/handling? |
| [12:23:41] | <paul121[m]> | If you are interested, another PR on general views access changes for farmOS core is here :-): https://github.com/farmOS/farmOS/pull/965 |
| [12:30:17] | <paul121[m]> | Miriam Nugent: I also noticed that at least in one place you are only checking for "organization assets" via the `log.asset` asset reference field. It might be good to include the `log.location` field as well. In farmOS core we generally treat these two fields as both "first class" log asset reference fields used in various ways (the "logs associated with an asset" view uses asset or location reference). Other fields like `log.equipment` do |
| [12:30:17] | <paul121[m]> | not support this, tho |
| [12:59:12] | <paul121[m]> | <mstenta[m]> "Regarding the other warnings (..." <- rats. looks like `exclude` is only a valid element within the `source` element: https://docs.phpunit.de/en/10.5/configuration.html#the-exclude-element |
| [12:59:13] | <paul121[m]> | I see that Drupal core sets the `source.exclude` to do something similar to what we want. I'll try that now.. |
| [14:17:44] | <paul121[m]> | <paul121[m]> "rats. looks like `exclude` is..." <- > <@paul121:matrix.org> rats. looks like `exclude` is only a valid element within the `source` element: https://docs.phpunit.de/en/10.5/configuration.html#the-exclude-element... (full message at <https://matrix.org/oftc/media/v1/media/download/AdOvwwPzxzfwe8uk3kfuWNIa...) |