| [23:06:47] | * nxnxhd7337[m] has joined #farmos |
| [23:07:16] | <nxnxhd7337[m]> | 𝐌𝐄𝐒𝐒𝐀𝐆𝐄 BlackHat_Nexus 𝐅𝐎𝐑 𝐀𝐍𝐘 𝐊𝐈𝐍𝐃 𝐎𝐅 𝐒𝐄𝐑𝐕𝐈𝐂𝐄 𝐑𝐄𝐂𝐎𝐕𝐄𝐑 𝐘𝐎𝐔𝐑 𝐀𝐂𝐂𝐎𝐔𝐍𝐓... (full message at <https://matrix.org/oftc/media/v1/media/download/ARA0NnUXtPI6TU_Vx6gd-cNT...) |
| [07:02:52] | <mstenta[m]> | paul121: Something seems to have changed upstream and now PHPStan tests are failing: https://github.com/farmOS/farmOS/actions/runs/14124821656/job/39572703233 |
| [07:03:52] | <mstenta[m]> | They are all coming from our classes that provide field formatters: |
| [07:03:52] | <mstenta[m]> | `Access to an undefined property Drupal\Core\Field\FieldItemInterface::$value.` |
| [07:04:30] | <mstenta[m]> | Quick search revealed that this was a previous issue with phpstan-drupal, but it sounds like it was solved years ago: https://github.com/mglaman/phpstan-drupal/issues/147 |
| [07:04:35] | <mstenta[m]> | So maybe it's a regression. |
| [07:09:29] | <mstenta[m]> | I just replicated locally after running `composer update` (`phpstan` did not show the error locally before `composer update`). Here is what changed:... (full message at <https://matrix.org/oftc/media/v1/media/download/ARc6Ca_GnIxscv-7uouhQNvZ...) |
| [07:11:38] | <mstenta[m]> | Replacing `$item->value` with `$item->getValue()` seems to fix it. I'll open a PR for review. |
| [07:14:30] | <mstenta[m]> | https://github.com/farmOS/farmOS/pull/943 |
| [10:33:17] | * farmBOT has joined #farmos |