| [12:01:01] | <symbioquine[m]> | farmOS dev call on now: https://meet.jit.si/farmos-dev All are welcome! |
| [12:01:44] | * mstenta[m] has joined #farmos |
| [12:01:45] | <mstenta[m]> | I think paul121 will |
| [12:01:45] | <mstenta[m]> | I have to attend an OpenTEAM ag data wallet session so I won't be on today! |
| [13:07:38] | <mstenta[m]> | symbioquine paul121 quick question... |
| [13:08:50] | <mstenta[m]> | If we were to merge docker/dev/Dockerfile into docker/Dockerfile, such that the dev image could be build by specifying docker build ... --target development docker (instead of docker build .. docker/dev), would you consider that a breaking change? |
| [16:24:50] | * paul121[m] has joined #farmos |
| [16:24:51] | <paul121[m]> | TIL about --target options! This is great |
| [16:26:13] | <paul121[m]> | I suppose it is a breaking change. But only for a full "build process" running that command to build a dev env... I think it's semi unlikely many ppl have these things automated? 🤔 |
| [16:27:49] | <paul121[m]> | It seems like theres potentially some breaking changes in the docker images themselves like "no recommended" dependencies. But in these cases I think we recommend that you don't use the latest docker image, and I think that would apply when using docker images in automated builds, too? So ideally someone needs to manually update the docker tag to also get these "breaking" changes? 🤔 |
| [17:03:48] | <mstenta[m]> | Yea it feels like a "mild" breaking change, and would only affect downstream processes that are building a dev image. And the "break" is that they will build a production image instead (xdebug etc will not be installed). So it feels like that won't cause any catastrophic issues. But might require some users to update scripts. It could be argued that dev images are not really covered by semantic versioning guidelines (although in general I |
| [17:03:48] | <mstenta[m]> | would always strive to). But in this case it feels low risk. 🤷 |
| [17:04:06] | <mstenta[m]> | Curious if symbioquine or anyone else has stronger feelings. |
| [17:10:10] | <mstenta[m]> | > It seems like theres potentially some breaking changes in the docker images themselves like "no recommended" dependencies. |
| [17:10:10] | <mstenta[m]> | Hmm still reading through your comments, but do you mean in the branch I started? Or in the changes in the original PR? |
| [17:12:50] | <paul121[m]> | mstenta[m]: > <@mstenta:matrix.org> > It seems like theres potentially some breaking changes in the docker images themselves like "no recommended" dependencies.... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/COoWRMUyYkAoFSYZ...) |
| [17:13:33] | <mstenta[m]> | Ah didn't even notice that big 😆 |
| [17:14:02] | <mstenta[m]> | s/big/bit/ |