| [01:03:55] | <symbioquine[m]> | <mstenta[m]> "Have you seen this work before..." <- I seem to recall it working before with the import feature of the land drawing tool... |
| [01:04:25] | <symbioquine[m]> | and I think I got a minimal-ish example working in this sandbox: https://codesandbox.io/s/geojson-forked-8vb4on?file=/main.js |
| [01:05:18] | <symbioquine[m]> | symbioquine[m]: https://github.com/symbioquine/farmOS_land_drawing_tool/blob/a5067047ad2... (Mostly the same code for KML though so I could be remembering that.) |
| [03:57:56] | <toino[m]> | No one is going to kick this spammer from here? |
| [04:01:25] | <FarmerEd[m]> | No one here will be |
| [04:16:17] | * farmBOT has joined #farmos |
| [08:41:21] | <symbioquine[m]> | <toino[m]> "No one is going to kick this..." <- You can click the three little dot menu next to one of their messages, then click "report" and check the box to ignore all their messages. This does double duty of making it more likely they'll get banned from the whole Matrix home server and making it so you don't have to see their messages any more. |
| [08:45:51] | <toino[m]> | symbioquine[m]: Already did that, I only asked that because last week he posted the same thing and it looks like a official telegram link but it could be someone posting phishing links or somekind of honeypot, if a admin here kicked him there would be no risk of clicking on it by mistake. |
| [08:48:45] | <mstenta[m]> | I kicked him this time. Didnt see the previous one |
| [10:27:02] | <jgaehring[m]> | not sure if this would interest any farmers here, but should be a great course: |
| [10:27:02] | <jgaehring[m]> | https://platform.coop/events/learning-from-what-works-agriculture/ |
| [11:08:58] | <mstenta[m]> | symbioquine paul121 mind if I tag a v2.2.0 release of farmOS-map? |
| [11:10:51] | <mstenta[m]> | > > This will help to simplify the farmOS PR I opened last week for refreshing the edit layer when WKT is pasted (which currently has to use a funky workaround to get features out of WKT) |
| [11:10:51] | <mstenta[m]> | > |
| [11:10:51] | <mstenta[m]> | > On a related note... This PR revealed a small bug in the modify interaction (I think) - unrelated to this PR specifically, and somewhat edge-case-y. I don't think it needs to block any of these things, but maybe we can take a look together on the dev call this week. |
| [11:10:51] | <mstenta[m]> | Also, if either of you have some time today, would you be interested in taking a look at this with me? |
| [11:11:12] | <mstenta[m]> | We can also wait until Thursday :-) |
| [11:12:31] | <symbioquine[m]> | I could hop on Jitsi for a few minutes... |
| [11:13:06] | <paul121[m]> | I could now as well, but don't have much time the rest of the day |
| [11:13:36] | <mstenta[m]> | Cool! It's quick to demo - I'll hop into https://meet.jit.si/farmos-dev |
| [12:23:21] | <mstenta[m]> | symbioquine paul121 This is where the measure behavior kicks off when it gets added: https://github.com/farmOS/farmOS-map/blob/73a597c9ffdf4b43545975c27f858c... |
| [12:24:27] | <mstenta[m]> | Might be worth digging in there next time together... |
| [12:25:32] | <mstenta[m]> | Maybe there are just some events we're missing listeners for |
| [12:26:06] | <mstenta[m]> | I wonder if we should hold off on farmOS-map v2.2.0 and see if we can fix this first |
| [12:26:13] | <symbioquine[m]> | mstenta[m]: I suspect one of the issues is that [this code](https://github.com/farmOS/farmOS-map/blob/73a597c9ffdf4b43545975c27f858c...) uses farmOS-map "events" instead of watching the vector layer for changes more directly... |
| [12:27:58] | <symbioquine[m]> | I think that means that you change the features without causing a "drawstart", "drawend", "modifystart"; it will be somewhat broken. |
| [12:28:30] | <mstenta[m]> | Ahhh |
| [12:28:59] | <symbioquine[m]> | We should probably be watching for add/change events on the feature collection: https://openlayers.org/en/latest/apidoc/module-ol_Collection-Collection.... |
| [12:29:32] | <mstenta[m]> | Aha that makes sense |
| [12:29:33] | <symbioquine[m]> | (and maybe the included features - can't remember if the change events bubble up, but I think they do...) |
| [12:31:12] | <mstenta[m]> | Oh wow look what I found: https://github.com/farmOS/farmOS-map/issues/84 |
| [12:31:27] | <mstenta[m]> | > If you try to add the measure behavior to multiple layers (eg: in the "current location" and "new location" layers in the animal move quick form map: https://www.drupal.org/project/farm/issues/3156713), it works at first (both layers show their measurements), but if you then try to edit a layer then the other one disappears. |
| [12:31:37] | <mstenta[m]> | from 2020 😄 |
| [12:32:07] | <symbioquine[m]> | Seems like it might be worth a bit of a rewrite for that behaviour. |
| [12:32:14] | <mstenta[m]> | Not exactly related... just that it came up on the same quick form back then too |
| [12:32:17] | <mstenta[m]> | Yup |
| [12:33:59] | <mstenta[m]> | Might be worth reviewing https://github.com/farmOS/farmOS-map/issues/94 at some point too - I wonder if any of it is still relevant in farmOS v2 |
| [12:40:11] | <paul121[m]> | mstenta: I think I saw that you recently observed this issue as well: https://github.com/farmOS/farmOS-map/issues/174 |
| [12:40:55] | <mstenta[m]> | Yes - that was happening in the old WKT Refresh logic... before we had readFeatures() available |
| [12:41:28] | <mstenta[m]> | Because without that, the workaround was to add a "hidden" layer to read the WKT, then copy those features to the real layer, then remove the hidden layer. But the LayerSwitcher still showed it in the list. |
| [12:41:28] | <paul121[m]> | ah yeah, when layers were added/removed |
| [12:41:55] | <mstenta[m]> | So no longer an issue... at least not for this. But more generally it is. |
| [15:45:15] | <mstenta[m]> | We need a better autocomplete widget in farmOS core :-( |