| [22:38:53] | * heartburn has quit (Read error: Connection reset by peer) |
| [22:39:12] | * heartbur1 has joined #farmos |
| [22:50:08] | * heartbur1 is now known as heartburn |
| [22:54:33] | * heartburn has quit (Quit: Reconnecting) |
| [22:57:14] | * heartburn has joined #farmos |
| [14:33:00] | <mstenta[m]> | > Why does the breadcrumb say "edit []", but the page looks like the "view" page? |
| [14:33:00] | <mstenta[m]> | symbioquine paul121 I confirmed locally that's an existing issue - never noticed it before! |
| [14:33:06] | <mstenta[m]> | I'll take a quick look |
| [14:33:39] | <mstenta[m]> | But in the meantime, symbioquine how do you feel about me merging https://github.com/farmOS/farmOS/pull/661 ? |
| [14:34:26] | <mstenta[m]> | Also, I added another commit to https://github.com/farmOS/farmOS/pull/654 that introduces the `QuickFormElementsTrait` with a `buildInlineContainer()` method. Does that look ready to merge paul121 ? |
| [14:44:00] | <mstenta[m]> | > Why does the breadcrumb say "edit []", but the page looks like the "view" page? |
| [14:44:00] | <mstenta[m]> | Looks like this is a Gin issue: https://www.drupal.org/project/gin/issues/3281984 |
| [16:26:45] | <paul121[m]> | fwiw another breadcrumb issue "Back to site" 😄 https://farmos.discourse.group/t/back-to-site-breadcrumb/1396 |
| [16:38:18] | <paul121[m]> | > <@mstenta:matrix.org> > Why does the breadcrumb say "edit []", but the page looks like the "view" page? |
| [16:38:18] | <paul121[m]> | > |
| [16:38:18] | <paul121[m]> | > Looks like this is a Gin issue: https://www.drupal.org/project/gin/issues/3281984 |
| [16:38:18] | <paul121[m]> | Cool, didn't review code but maybe we just need to test this out and give it RTBC? |
| [16:39:12] | <paul121[m]> | If not, maybe we just override what Gin does and provide these ourselves. Then we have control |
| [17:08:58] | <mstenta[m]> | Yea I looked at the Gin code. Both the "Edit [entity-type]" and "Back to site" are added by the same breadcrumb preprocess function |
| [17:10:11] | <mstenta[m]> | We can add our own preprocess, along with a hook to ensure ours runs after Gin's, and modify what Gin produces |
| [17:10:36] | <mstenta[m]> | Might be a bit fragile if Gin changes anything |
| [17:14:03] | <mstenta[m]> | But I was thinking the same thing ... lets change "Back to site" :-) |
| [17:28:56] | <paul121[m]> | ya! |