| [08:41:04] | <lordeddi[m]> | tried to configure the table on the logs page using JS only in frontend. there's still some bugs, but it semi works... not very happy with the outcome, but was worth a try |
| [08:41:35] | <lordeddi[m]> | ACTION uploaded an image: (11KiB) < https://libera.ems.host/_matrix/media/v3/download/oblak.be/gTJFEDoLxAbiX... > |
| [08:41:46] | <lordeddi[m]> | ACTION uploaded an image: (27KiB) < https://libera.ems.host/_matrix/media/v3/download/oblak.be/sPKfbLfpGBuoG... > |
| [08:42:17] | <lordeddi[m]> | ACTION uploaded an image: (23KiB) < https://libera.ems.host/_matrix/media/v3/download/oblak.be/tRTSowYqcqfpf... > |
| [08:42:31] | <lordeddi[m]> | ACTION uploaded an image: (30KiB) < https://libera.ems.host/_matrix/media/v3/download/oblak.be/hNNXRbpwVLjiR... > |
| [08:43:35] | <lordeddi[m]> | 1. have a lock to hide or show config options |
| [08:43:35] | <lordeddi[m]> | 2. unlocked: show config arrows/checkboxes/buttons |
| [08:43:35] | <lordeddi[m]> | 3. hide some columns using checkboxes and move some columns (assets, location) |
| [08:43:35] | <lordeddi[m]> | 4. lock which updates the view-ish |
| [08:44:01] | <lordeddi[m]> | code can be downloaded (incl icons): https://upload.disroot.org/r/myTNqfB5#IhnlISfXU6QtKJHOKKG4y2ceFMsrEC44Q1... |
| [08:44:07] | <lordeddi[m]> | it's just a small zip containing 1 js file and the icons |
| [08:44:19] | <lordeddi[m]> | and... yeah.. it's not very pretty 😅 |
| [08:47:17] | <mstenta[m]> | wow! |
| [08:47:56] | <mstenta[m]> | i'm impressed lordeddi! i thought it would be overly difficult to do this! |
| [08:49:37] | <mstenta[m]> | unrelated but i opened a bug report for a minor CSS issue on farmOS.org that is pretty annoying: https://github.com/farmOS/farmOS.org/issues/69 |
| [08:50:39] | <mstenta[m]> | i wonder if this is an easy fix? jgaehring maybe you could recommend where in the code this might need adjustment? |
| [08:51:30] | <mstenta[m]> | i'm still learning the structure of farmOS.org's new codebase |
| [08:52:18] | <mstenta[m]> | this feels like a dumb question but... where is the CSS? 😅 |
| [08:53:02] | <mstenta[m]> | (showing my Vue-noob status) |
| [08:54:20] | <mstenta[m]> | * my Vue/gatsby(?)-noob status) |
| [09:05:01] | <wotnak[m]> | <mstenta[m]> "i wonder if this is an easy fix?..." <- applying `scroll-padding-top: 64px;` to the <html> element should fix this |
| [09:05:47] | <wotnak[m]> | <mstenta[m]> "this feels like a dumb question..." <- farmOS.org uses React.js (through Gatsby), styles are manged using material-ui library, some are inherited by using premade components and custom ones are added per component using hook api https://v4.mui.com/styles/basics/#hook-api, for example on the blog page https://github.com/farmOS/farmOS.org/blob/main/src/pages/blog.js#L12 |
| [09:07:02] | <mstenta[m]> | wow thanks for the explanation wotnak ! |
| [09:40:09] | <jgaehring[m]> | <mstenta[m]> "i wonder if this is an easy fix?..." <- Oh yea, I always notice that and have been meaning to open an issue, thanks Mike |
| [09:41:21] | <jgaehring[m]> | Should just be a little adjustment to account for the app bar's height |
| [09:45:02] | <mstenta[m]> | wotnak to the rescue! 😄 https://github.com/farmOS/farmOS.org/pull/70 |
| [09:46:40] | <mstenta[m]> | how does that look to you jgaehring? good to merge? |
| [09:46:48] | <mstenta[m]> | the deploy preview looks good to me! |
| [09:52:26] | <mstenta[m]> | PS thanks for working on https://github.com/farmOS/farmOS.org/pull/68 too wotnak !! |
| [10:01:53] | <jgaehring[m]> | <mstenta[m]> "wotnak to the rescue! 😄 https..." <- oh nice! didn't know about the `padding-scroll-top` CSS property, need to remember that one |
| [10:02:01] | <jgaehring[m]> | <mstenta[m]> "how does that look to you..." <- yep, looks good! |
| [10:03:42] | <mstenta[m]> | huzzah! |
| [10:06:01] | <mstenta[m]> | i love simple fixes. this is small but makes a big difference too :-) |
| [10:40:52] | <wotnak[m]> | the earlier fix didn't fix the anchor links issue completely, it works well for using anchor links on the page, but the problem is still present when linking to a specific section (anchor) from an external site or by pasting/typing anchor link directly in the new browser tab/window, created pr that changes the solution a bit to fix the problem for both cases https://github.com/farmOS/farmOS.org/pull/71 |
| [10:41:29] | <mstenta[m]> | ah interesting - good find wotnak I forgot to test that case specifically on the previous PR |
| [10:41:49] | <mstenta[m]> | can you help me understand what '[id], [name]': { means? |
| [10:42:10] | <mstenta[m]> | the previous PR was just html, which was easy for me to understand :-) |
| [10:42:27] | <mstenta[m]> | what will it target now, in HTML terms? |
| [10:43:16] | <wotnak[m]> | it selects all elements that have id or name attribute set, this attributes values can be used for creating anchor links |
| [10:43:17] | <mstenta[m]> | every HTML element with an id or name attribute? |
| [10:43:24] | <mstenta[m]> | gotcha |
| [10:43:28] | <wotnak[m]> | * it selects all elements that have id or name attribute set, these attributes values can be used for creating anchor links |
| [10:44:21] | <mstenta[m]> | i wonder if it would make sense to further target only h1, h2, h3 etc tags? |
| [10:44:47] | <mstenta[m]> | i don't know if that's necessary... or if there are any risks to targeting all elements broadly |
| [10:44:57] | <mstenta[m]> | I think the issue is only with h# tags |
| [11:03:31] | <wotnak[m]> | in this case there shouldn't be any risks of targeting all elements for which anchors can be created, currently on the site anchor links are created only for headings, but if in the future someone creates an anchor link for some other element general attribute based selector will automatically apply scroll margin to it, if we limit selector to only headings we might have to in the feature update it to support other elements |
| [11:04:52] | <mstenta[m]> | makes sense! i'll approve the PR, but will wait for one more approval from jgaehring paul121 or symbioquine before merging, just to get other eyes on it :-) |
| [11:04:56] | <mstenta[m]> | thanks again wotnak ! |
| [11:05:49] | <mstenta[m]> | i'll copy these comments in there for future reference too |
| [11:50:50] | <symbioquine[m]> | <wotnak[m]> "in this case there shouldn't..." <- I'm trying to wrap my head around this... let me know if I've got it right; "The `scroll-margin-top` CSS property will apply to basically all the elements that *could* be scrolled to, but that only has an effect visible to the user/viewer when the browser is instructed to scroll to one of those elements - as in the case of clicking an anchor or programmatic call to `el.scrollIntoView()`"? |
| [11:59:01] | <wotnak[m]> | yes, that's right, the effect may also be visible on normal page scroll when using scroll snap, but it isn't used on the farmOS.org website |
| [14:13:48] | <mstenta[m]> | curl wttr.in 🌦️🤯 |
| [15:49:09] | <paul121[m]> | <lordeddi[m]> "tried to configure the table..." <- this is a cool approach!! It's really nice being able to modify that by dragging around "in-place". Although this could be quite challenging on mobile... but perhaps there could be two ways to modify this column configuration, this being one of them! |
| [15:51:46] | <paul121[m]> | Maybe we could have a button that opens a "column form" modal on top of the table... instead of trying to fit this form into the existing UI, just drop it on top when needed... (but need to see how modal works on mobile) |
| [15:55:19] | <mstenta[m]> | While we're on this farmOS.org PR spree - what do y'all think of this one? https://github.com/farmOS/farmOS.org/pull/61 |
| [15:58:15] | <mstenta[m]> | We approved this a while ago, but haven't moved forward with it yet: https://farmos.discourse.group/t/funding-proposal-buttondown-email-basic... |
| [16:00:21] | <mstenta[m]> | Maybe we should open a funding proposal to sponsor someone's time on a blog->newsletter integration like we discussed (somewhere)... |
| [16:00:40] | <mstenta[m]> | eg: publish a blog post with a special "newsletter" flag and it auto-sends |
| [16:00:41] | <mstenta[m]> | via buttondown API |
| [16:01:13] | <paul121[m]> | That would be a great addition. In the short-term, yes, include the signup form 👍️ |
| [16:01:37] | <mstenta[m]> | Cool yea I figure doesn't hurt to at least let people start signing up - even if we aren't sending anything yet :-) |
| [16:03:33] | <mstenta[m]> | I'll add "Newsletter+Blog integration - funding proposal?" to the agenda for the next monthly call |
| [16:24:33] | <symbioquine[m]> | <mstenta[m]> "Just needs an approval from paul..." <- Btw; I merged this yesterday evening after Paul approved it: https://farmos.org/blog/2023/introducing-asset-link-contrib-module-video |
| [16:29:17] | <mstenta[m]> | Cool! I'll microblog it on Monday! |
| [16:29:18] | <mstenta[m]> | Would be nice to automate that too :-) |
| [16:31:10] | <mstenta[m]> | On that note... and related to auto-sending newsletters... I think one of the challenges is: knowing when a new post is "published" and triggering off of that |
