| [10:45:10] | <EricLarese[m]> | Hi all, it looks like https://github.com/farmOS/farmOS/pull/630 needs a maintainer to approve running the workflows, can anybody do that for me ? |
| [10:46:04] | <mstenta[m]> | Oh sure! Will do... |
| [10:46:23] | <mstenta[m]> | I am still planning on tackling the same change on the `log` module soon Eric Larese ;-) |
| [10:47:22] | <mstenta[m]> | I imagine the tests will pass just fine - I don't think we have any tests checking that bit of code specifically 😅 |
| [10:48:15] | <EricLarese[m]> | Do we use threads here? Also do you want me to submit a change for that? I don't know how hard it is for outsiders to submit a change to Drupal. |
| [10:48:15] | <mstenta[m]> | Ah but the changelog check failed... |
| [10:51:40] | <mstenta[m]> | I tend to find threads confusing haha, and I'm not sure how well they jive with our chat archive: https://irc.farmos.org/ |
| [10:51:42] | <mstenta[m]> | Guess we'll find out now, eh? |
| [10:51:59] | <mstenta[m]> | Ah they work! |
| [10:52:02] | <mstenta[m]> | Neat :-) |
| [10:52:31] | <mstenta[m]> | First step is opening a drupal.org issue here: https://www.drupal.org/project/log |
| [10:52:56] | <mstenta[m]> | You're welcome to get that started! But if it's a pain I can do it pretty quick so no worries. |
| [10:53:26] | <mstenta[m]> | PRs check to make sure that a change was added to CHANGELOG.md - you can see how we format them - generally just a link to the PR |
| [10:56:37] | <mstenta[m]> | Hey all I think I know why the drupal.org usage statistics aren't working... https://www.drupal.org/project/farm/issues/3336698 |
| [11:58:40] | <mstenta[m]> | farmOS dev call in ~1 minute! |
| [11:58:40] | <mstenta[m]> | https://meet.jit.si/farmos-dev |
| [11:59:11] | <mstenta[m]> | Aislinn from Rothamsted with be joining along with some folks from PearGIS - they are interested in learning more about symbioquine's WFS module so that will probably be one of the main topics today |
| [12:02:01] | <symbioquine[m]> | Ah... just a sec |
| [12:15:10] | <EricLarese[m]> | I updated the changelog on https://github.com/farmOS/farmOS/pull/630 to fix the failing workflow, it looks like it needs approval again to re-run the workflows, thanks ! |
| [12:18:12] | <mstenta[m]> | Browser crashed brb :-) |
| [12:50:28] | <EricLarese[m]> | Thanks mstenta ! I used threads extensively in my old life, it was nice because it kept things grouped, like this discussion. I can see though that the logger seems to flatten everything, so maybe it's annoying and I should stop. At any rate though, I created a drupal.org account and opened https://www.drupal.org/project/log/issues/3336721 -- I'll see about submitting code for it next |
| [12:52:20] | <EricLarese[m]> | It looks like PHPStan is failing on 4 errors (https://github.com/farmOS/farmOS/actions/runs/4017457712/jobs/6902076810) that don't seem related to my PR #630, is that a known issue? Or did I do something wrong? Should I open an issue for that? Or should I change something to fix it in my PR ? |
| [12:55:49] | <mstenta[m]> | Ah I think I know what's causing that - thanks Eric Larese |
| [12:55:51] | <mstenta[m]> | https://github.com/mglaman/phpstan-drupal/issues/474 |
| [12:56:02] | <mstenta[m]> | We were ignoring some lines that it was flagging - but they fixed the bug, so I think if we remove those ignores then it will fix it. |
| [12:56:19] | <mstenta[m]> | I'll take a look at that ASAP |
| [12:57:22] | <EricLarese[m]> | Do you want me to add it to this PR? Or is that bad form to stuff unrelated changes in. |
| [14:34:29] | <EricLarese[m]> | I went ahead and pushed another commit that removes the unneeded ignores, it needs another workflow approval (https://github.com/farmOS/farmOS/pull/630). Let me know if you want me to roll that commit back or put it under a separate PR ! |