| [22:16:12] | * polo has quit (Remote host closed the connection) |
| [22:32:04] | * polo has joined #farmos |
| [23:54:46] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [00:17:14] | * polo has joined #farmos |
| [00:19:35] | * polo has quit (Changing host) |
| [00:19:35] | * polo has joined #farmos |
| [00:54:50] | * polo has quit (Quit: Textual IRC Client: www.textualapp.com) |
| [01:46:14] | * polo has joined #farmos |
| [01:56:57] | * polo has quit (Read error: Connection reset by peer) |
| [02:24:15] | * polo has joined #farmos |
| [03:04:57] | * polo has quit (Read error: Connection reset by peer) |
| [03:25:40] | * polo_ has joined #farmos |
| [03:29:56] | * polo_ has quit (Read error: Connection reset by peer) |
| [03:31:40] | * polo_ has joined #farmos |
| [04:27:18] | * polo_ has quit (Ping timeout: 240 seconds) |
| [04:29:10] | * Guest6642 has joined #farmos |
| [05:06:06] | * Guest6642 has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [05:43:53] | * polo_ has joined #farmos |
| [06:15:49] | * polo_ has quit (Changing host) |
| [06:15:49] | * polo_ has joined #farmos |
| [06:15:52] | * polo_ is now known as polo |
| [08:05:51] | * polo is now known as Guest6276 |
| [08:06:23] | * Guest6276 has quit (Read error: Connection reset by peer) |
| [08:06:56] | * polo has joined #farmos |
| [08:18:51] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [08:46:02] | <mstenta[m]> | OK I think I got it to work with this:... (full message at <https://libera.ems.host/_matrix/media/r0/download/libera.chat/2ea49812d1...) |
| [08:46:16] | <mstenta[m]> | The update completes successfully and the `consumer__client_id` table is removed from the database. |
| [08:46:54] | <mstenta[m]> | Now just need to do a final test of it with the Consumer update hooks |
| [08:55:55] | <mstenta[m]> | Tested and it works! Details: https://www.drupal.org/project/farm/issues/3311264#comment-14710887 |
| [09:05:25] | * polo has joined #farmos |
| [09:15:22] | * polo has quit (Read error: Connection reset by peer) |
| [09:17:41] | * polo has joined #farmos |
| [09:28:13] | <evered[m]> | Good morning. |
| [09:28:13] | <evered[m]> | It's 2:28pm in Ireland. |
| [09:28:53] | <symbioquine[m]> | Good morning! |
| [09:29:31] | <evered[m]> | ACTION waves to symbioquine sunrise here in Santa Barbara. |
| [09:31:18] | <mstenta[m]> | Morning! |
| [09:36:54] | <evered[m]> | Good morning, mstenta ! |
| [09:39:16] | * polo has quit (Quit: Textual IRC Client: www.textualapp.com) |
| [09:58:08] | <mstenta[m]> | Ouch paul121 be careful about building/deploying any new farmOS images today! I just got hit with this bug when I deployed the Rothamsted update: https://www.drupal.org/project/gin/issues/3312324 |
| [09:58:23] | <mstenta[m]> | It is being fixed in Drupal core as we speak: https://www.drupal.org/project/drupal/issues/3312270 |
| [09:59:09] | <mstenta[m]> | Sounds like they plan to release a new version of Drupal core with a fix later today (thank goodness - just in time for our 2.0.0-beta7 release) |
| [09:59:34] | <mstenta[m]> | I was able to hotfix it by pinning `twig/twig` to `2.15.2` |
| [10:04:24] | <evered[m]> | 2.0.0 beta?! Love it |
| [10:06:23] | <mstenta[m]> | Yea! Hopefully releasing 2.0.0-beta7 this week :-) |
| [10:07:00] | <evered[m]> | Yes! |
| [10:07:10] | <evered[m]> | Well done. |
| [10:22:30] | * polo has joined #farmos |
| [10:29:09] | <mstenta[m]> | symbioquine: What do you think about https://github.com/farmOS/farmOS-map/pull/173 and https://github.com/farmOS/farmOS-map/pull/182 (and related: https://www.drupal.org/project/farm/issues/3243922) - should we try to get those into 2.0.0-beta7 as well? |
| [10:29:22] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [10:29:55] | <mstenta[m]> | I don't have a strong opinion. |
| [10:30:13] | <mstenta[m]> | I think those are the only remaining PRs to consider. |
| [10:33:52] | <symbioquine[m]> | I didn't get back to those yesterday. I'll take another look in a minute... |
| [10:34:36] | <mstenta[m]> | Cool! Not urgent... just planning ahead :-) |
| [10:35:26] | <symbioquine[m]> | #173 is an easy "yes" |
| [10:36:34] | <mstenta[m]> | (The other implied work involved would be tagging a new release and updating farmOS core to use it - I can help with that stuff) |
| [10:36:41] | <symbioquine[m]> | The other one I need to look at again, but it seemed reasonable when I skimmed it before. |
| [10:37:25] | <mstenta[m]> | OK! Well maybe I'll leave that to you and paul121 to decide on. Can we decide today whether or not to merge it ahead of 2.0.0-beta7? |
| [10:38:12] | <mstenta[m]> | I have some other work to focus on today. I can tag 2.0.0-beta7 as early as this afternoon I think. But can also wait until tomorrow. Tomorrow might be my last window though. Headed to GOAT next week. |
| [10:44:47] | <paul121[m]> | <mstenta[m]> "Tested and it works! Details..." <- Great! Were you able to try that case where we have our update hook before the consumers hooks are included? |
| [10:45:09] | <mstenta[m]> | Yes, and we should NOT do that. |
| [10:45:10] | <mstenta[m]> | :-) |
| [10:45:18] | <mstenta[m]> | It basically runs both our update hooks regardless |
| [10:45:23] | <mstenta[m]> | Which would result in loss of data. |
| [10:45:38] | <mstenta[m]> | So we need to wait until Consumers tags a new release before we merge this |
| [10:46:38] | <mstenta[m]> | Drupal's update hook dependency logic must consider the dependencies optional - meaning if it doesn't find the other module it will still go ahead and run the existing updates |
| [10:59:03] | <symbioquine[m]> | paul121: Left a comment on https://git.drupalcode.org/project/farm/-/merge_requests/73/diffs Puzzled as to how the change would work with multiple installs under a single domain or in subpaths... |
| [10:59:35] | <symbioquine[m]> | I might just be missing something there. |
| [11:00:10] | <paul121[m]> | good catch, I think that is just a poor comment |
| [11:01:06] | <paul121[m]> | First it gets the libraries path (which is relative to base path)... (full message at <https://libera.ems.host/_matrix/media/r0/download/libera.chat/4ab5de93a1...) |
| [11:01:31] | <paul121[m]> | (in the Drupal URL context the "absolute" path includes `https://.....` which I don't think we need) |
| [11:01:40] | <symbioquine[m]> | ah, so the second (#3) line actually does include the base path? |
| [11:02:06] | <symbioquine[m]> | Yeah, we don't want the `https://domain:port` part of the url |
| [11:02:29] | <paul121[m]> | Yes. `Url::fromUri()` requires a "scheme" prefix, one of which is "base:", quite convenient! |
| [11:02:43] | <symbioquine[m]> | symbioquine[m]: just an absolute path on the server. i.e. a path that starts with `/` |
| [11:02:53] | <symbioquine[m]> | paul121[m]: Cool |
| [11:06:16] | <paul121[m]> | better?... (full message at <https://libera.ems.host/_matrix/media/r0/download/libera.chat/284e26c0ee...) |
| [11:06:45] | <paul121[m]> | I gotta run will be back later! |
| [11:07:04] | <symbioquine[m]> | > <@paul121:matrix.org> better?... (full message at <https://libera.ems.host/_matrix/media/r0/download/libera.chat/fb0272a977...) |
| [11:14:50] | <symbioquine[m]> | <mstenta[m]> "(The other implied work involved..." <- How about I create the farmOS-map release and you can point at it? |
| [11:15:01] | <mstenta[m]> | Sure thing! |
| [11:15:12] | <mstenta[m]> | Thanks symbioquine ! |
| [11:15:26] | <mstenta[m]> | We also have to wait for a new release of Drupal core today so that we can get the twig fix... |
| [11:34:17] | <symbioquine[m]> | <symbioquine[m]> "How about I create the farmOS-..." <- v2.0.8 has been released :) |
| [11:37:02] | <mstenta[m]> | FYI symbioquine we discovered a bug with the input/material migration :-( |
| [11:37:13] | <mstenta[m]> | https://github.com/farmOS/farmOS/issues/579 |
| [11:37:13] | <mstenta[m]> | I wonder if you were affected |
| [11:37:37] | <mstenta[m]> | That issue doesn't fully describe it yet... but basically:L |
| [11:37:41] | <symbioquine[m]> | I saw that, but I don't think I was affected. |
| [11:37:41] | <mstenta[m]> | * That issue doesn't fully describe it yet... but basically: |
| [11:37:56] | <symbioquine[m]> | I didn't use the material taxonomy in 1.x |
| [11:38:09] | <mstenta[m]> | It affects input logs that referenced multiple materials |
| [11:38:23] | <symbioquine[m]> | Instead I was using a custom material entity type there so the migration was more a straight 1:1 asset migration... |
| [11:38:30] | <mstenta[m]> | That's good |
| [11:38:57] | <symbioquine[m]> | ACTION sent a yml code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/2a4b4ac486... |
| [11:39:02] | <mstenta[m]> | Hopefully this hasn't impacted many... I am going to scan the instances I host to see |
| [11:39:30] | <symbioquine[m]> | s/entity/asset/ |
| [11:39:30] | <mstenta[m]> | We will fix the issue, and if we need to we'll try to write a followup migration/script to fix it on existing sites (if possible) |
| [12:00:11] | * GudjonEinarMagnu has quit (Quit: You have been kicked for being idle) |
| [12:21:32] | * polo has joined #farmos |
| [12:24:23] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [13:14:12] | <mstenta[m]> | There it is! There it is! https://www.drupal.org/sa-core-2022-016 |
| [14:34:26] | * EricLarese[m] has joined #farmos |
| [15:32:31] | * jonasbits has quit (Remote host closed the connection) |
| [15:56:34] | <mstenta[m]> | That was fun! |
| [15:56:38] | <mstenta[m]> | I wish we had a lot more time!! |
| [16:02:55] | * polo has joined #farmos |
| [16:04:10] | <paul121[m]> | ya that was good! |
| [16:13:57] | * jonasbits has joined #farmos |
| [16:47:11] | * polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| [18:28:00] | * polo_ has joined #farmos |
| [18:30:03] | * polo_ has quit (Client Quit) |