IRC logs for #farmOS, 2022-09-16 (GMT)

2022-09-15
2022-09-17
TimeNickMessage
[20:09:56]* polo__ has joined #farmos
[20:12:23]* polo has quit (Ping timeout: 252 seconds)
[21:17:03]* polo__ is now known as polo
[21:21:23]* polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
[21:29:37]* Guest133 has joined #farmos
[21:29:43]* Guest133 has quit (Changing host)
[21:29:43]* Guest133 has joined #farmos
[21:29:48]* Guest133 is now known as polo
[21:43:45]* polo is now known as Guest1013
[21:43:45]* Guest1013 has quit (Killed (platinum.libera.chat (Nickname regained by services)))
[22:00:57]* polo__ has joined #farmos
[22:02:51]* polo__ has quit (Changing host)
[22:02:51]* polo__ has joined #farmos
[22:02:55]* polo__ is now known as polo
[22:08:46]* polo has quit (Quit: Textual IRC Client: www.textualapp.com)
[23:00:36]* polo has joined #farmos
[23:16:05]* polo has quit (Ping timeout: 252 seconds)
[23:27:34]* polo has joined #farmos
[23:31:48]* Guest3660 has joined #farmos
[23:31:49]* polo has quit (Killed (tungsten.libera.chat (Nickname regained by services)))
[23:31:49]* Guest3660 is now known as polo
[23:51:41]* polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
[00:19:43]* Guest5177 has joined #farmos
[00:19:46]* Guest5177 has quit (Changing host)
[00:19:46]* Guest5177 has joined #farmos
[00:20:42]* Guest5177 is now known as polo
[00:29:09]* polo has quit (Quit: Textual IRC Client: www.textualapp.com)
[01:42:51]* Guest3317 has joined #farmos
[01:43:02]* Guest3317 has quit (Changing host)
[01:43:02]* Guest3317 has joined #farmos
[01:43:05]* Guest3317 is now known as polo
[01:54:18]* polo has quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
[01:56:55]* polo__ has joined #farmos
[02:05:08]* polo__ has quit (Remote host closed the connection)
[02:34:00]* polo has joined #farmos
[03:01:57]* polo has quit (Ping timeout: 252 seconds)
[03:03:04]* polo has joined #farmos
[03:09:24]* polo has quit (Ping timeout: 264 seconds)
[03:13:16]* polo__ has joined #farmos
[03:18:54]* polo__ has quit (Ping timeout: 265 seconds)
[04:21:45]* Guest3519 has joined #farmos
[04:21:47]* Guest3519 is now known as polo
[04:25:24]* polo has quit (Killed (platinum.libera.chat (Nickname regained by services)))
[07:35:42]* polo has joined #farmos
[07:42:11]* polo has quit (Ping timeout: 255 seconds)
[07:42:55]* owsley has joined #farmos
[07:42:56]* owsley has quit (Client Quit)
[07:44:03]* polo has joined #farmos
[07:53:07]* polo__ has joined #farmos
[07:54:25]* owsley has joined #farmos
[07:55:14]* polo has quit (Ping timeout: 255 seconds)
[07:58:00]* polo__ has quit (Ping timeout: 264 seconds)
[07:58:33]<mstenta[m]>paul121 symbioquine since we didn't get to look at the rest of the `2.x-phpstan` branch together yesterday, I'll summarize them here so you can review asynchronously... I'd love to get the branch merged ASAP so we can move forward (sorry in advance everyone for the flood of chat messages to come...)
[07:59:12]<mstenta[m]>We left off on this one: https://github.com/mstenta/farmOS/commit/f7f97dd64d1e35bb487f6cdcb78c78c...
[07:59:14]* owsley has quit (Ping timeout: 265 seconds)
[08:00:57]<mstenta[m]>I think I explained that on the last call before I had to jump off, but tl;dr: `phayes/geophp` is not being maintained, so it was forked to `itamair/geophp` and a new release was made with PHP 8 support. The `geofield` module changed from requiring `phayes/geophp` to `itamair/geophp`, which meant farmOS was pulling BOTH into `vendor`. So with this commit we are ONLY using `itamair/geophp`.
[08:01:34]<mstenta[m]>https://github.com/mstenta/farmOS/commit/1cd9df9faba4903c3bc1db1a4d132d2...
[08:02:53]<mstenta[m]>^ This is pretty self-explanatory. Adds `protected $user` to two test classes, and makes the way we check `isEmpty()` more type-strict in `IdTagItem` and `InventoryItem` field type classes
[08:03:09]<mstenta[m]>https://github.com/mstenta/farmOS/commit/79b3fb9ff8c9fbd593d38d1b71d4b14...
[08:03:55]<mstenta[m]>^ This adds missing `accessCheck(FALSE)` to two entity queries per https://www.drupal.org/node/3201242
[08:04:31]<mstenta[m]>https://github.com/mstenta/farmOS/commit/9e829fc3749de0e182eddce4c59a045...
[08:06:45]<mstenta[m]>^ This one is a followup related to the previous `accessCheck()` commit. PHPStan was saying that `accessCheck()` was missing in all of our instances of `getAggregateQuery()` even though we DID have it. I think it's a bug so I opened this upstream issue: https://github.com/mglaman/phpstan-drupal/issues/474, and added `@phpstan-ignore-next-line`s in the places we need it alongside `@todo`s to remove them when that issue is resolved.
[08:07:24]<mstenta[m]>A lot of the rest of the commits address deprecations...
[08:07:29]<mstenta[m]>(with some exceptions)
[08:10:42]<mstenta[m]>I'll skip explaining those... most are just simple changes or refactors to use new service methods provided by Drupal core instead of older procedural functions (eg: the following functions are deprecated: `taxonomy_term_load_multiple_by_name()`, `file_save_data()`, `file_create_url()`, `module_load_include()`)
[08:11:09]<mstenta[m]>https://github.com/mstenta/farmOS/commit/ca1d19d80fb4d22666e1a7ec2aab49b...
[08:11:35]<mstenta[m]>^ Super simple undefined variable fix - just needed to shift where `$exposed_filters` was getting defined so that the code that uses it has access to it.
[08:11:47]<mstenta[m]>https://github.com/mstenta/farmOS/commit/757399438f5283fe16cc0cb78daab0c...
[08:13:40]<mstenta[m]>^ This one is necessary because the GeoPHP library (both `phayes/geophp` and `itamair/geophp`) is old and doesn't use namespaces, so PHPStan complained about being unable to find the classes we use (see the commit message for specific errors). This simply adds a line to the `phpstan.neon` config file to tell it to scan the `geoPHP` directory during analysis. See
[08:13:41]<mstenta[m]>https://phpstan.org/user-guide/discovering-symbols#third-party-code-outs...
[08:14:04]<mstenta[m]>https://github.com/mstenta/farmOS/commit/5b06c00e1c13504d4ed2f1525db9040...
[08:14:59]<mstenta[m]>^ This just removes an unnecessary constructor argument from `QuickFormMenuLink` plugin class
[08:23:14]<mstenta[m]>https://github.com/mstenta/farmOS/commit/cc4006aecfcbfffd6161342d034d1b3...
[08:23:32]<mstenta[m]>^ Lastly, this is the one that @paul121 already looked at and I think we landed on this as the best approach.
[08:24:13]<mstenta[m]>paul121 symbioquine if you have a chance to skim through those and provide a thumbs up (or ask further questions) I'd appreciate it! Not urgent of course, just eager to get it merged. :-)
[09:46:30]<paul121[m]>We got through most of these on the dev call! Meant to say something, all looked good
[09:46:41]<mstenta[m]>Oh awesome! Thanks guys!
[09:47:01]<mstenta[m]>Did you have any questions about anything?
[09:48:48]<paul121[m]><mstenta[m]> "^ This just removes an unnecessa..." <- I was curious about this. I think we have a bug where individual quick forms are not shown in the menu, shouldn't they show on hover? At first I thought this change might fix it but I don't think that is the case. Seeing this just reminded me
[09:49:41]<symbioquine[m]>is `$this->id` supposed to be equivalent to `$this->get('id')->getValue()` or was that an actual bug - RE: https://github.com/mstenta/farmOS/commit/1cd9df9faba4903c3bc1db1a4d132d2...
[09:50:32]<mstenta[m]>> we have a bug where individual quick forms are not shown in the menu, shouldn't they show on hover
[09:50:33]<mstenta[m]>Oh yea, I think that is a result of the way we're building the menu items... haven't looked closely, but I don't think it's related to that commit above
[09:50:56]<mstenta[m]>Like, we might need to set the parent item to "expanded" or something? I dunno... but I don't think it's a "bug" as much as lacking the proper menu definitions
[09:51:36]<mstenta[m]>Maybe I'll take a quick look at that separately... because yea it would be nice to expand the quick form menu on hover I agree... I think there are other menus like that too?
[09:52:52]<mstenta[m]>> is `$this->id` supposed to be equivalent to `$this->get('id')->getValue()` or was that an actual bug
[09:52:52]<mstenta[m]>yes, `$this->id` DOES work... it uses the "magic" `__get()` method to essentially do `$this->get('id')->getValue()`... but the latter is more explicit, which PHPStan prefers
[09:53:17]<mstenta[m]>I had the parent class open... let me see if I can find it again
[09:54:15]<mstenta[m]>(side note, I've been making a lot more use of PHPStorm's Ctrl+N feature, which lets you quickly search by class name)
[09:56:45]<mstenta[m]>https://git.drupalcode.org/project/drupal/-/blob/a642dc228469d49b5cb9e66...
[09:57:23]<mstenta[m]> * https://git.drupalcode.org/project/drupal/-/blob/a642dc228469d49b5cb9e66...
[10:08:46]<mstenta[m]>Alright! Well if it's alright with you I'll go ahead and merge this!
[10:09:08]<mstenta[m]>Then rebase the PHP8 branch on top and see if anything new gets flagged
[11:20:42]* polo__ has joined #farmos
[11:33:19]* polo__ has quit (Ping timeout: 250 seconds)
[11:34:17]* polo has joined #farmos
[11:53:13]* polo has quit (Ping timeout: 244 seconds)
[12:29:34]* polo______ has joined #farmos
[12:35:35]* polo______ has quit (Ping timeout: 244 seconds)
[13:38:42]<mstenta[m]>> I think I explained that on the last call before I had to jump off, but tl;dr: `phayes/geophp` is not being maintained, so it was forked to `itamair/geophp` and a new release was made with PHP 8 support. The `geofield` module changed from requiring `phayes/geophp` to `itamair/geophp`, which meant farmOS was pulling BOTH into `vendor`. So with this commit we are ONLY using `itamair/geophp`.
[13:38:42]<mstenta[m]>doh! apparently `views_geojson` ALSO depends on `phayes/geophp`, so we still end up with both 🤦
[13:41:23]<mstenta[m]>I wonder if we can patch that... maybe not because it's a patch to a `composer.json` file, which wouldn't happen until AFTER the dependencies are all downloaded I think
[14:35:03]<paul121[m]>your issue just got merged! 🎉 https://www.drupal.org/project/views_geojson/issues/3310157
[14:43:26]* Guest9878 has joined #farmos
[14:43:45]* Guest9878 is now known as polo
[14:47:04]<mstenta[m]>wow!!
[14:47:16]<mstenta[m]>that's the fastest turnaround I think I've ever experienced in a drupal issue queue haha
[14:47:29]<mstenta[m]>(or maybe any issue queue for that matter)
[14:50:31]* polo is now known as Guest8543
[14:50:31]* Guest8543 has quit (Killed (platinum.libera.chat (Nickname regained by services)))
[14:57:50]* polo___ has joined #farmos
[15:32:03]* polo___ has quit (Quit: Textual IRC Client: www.textualapp.com)