| [10:16:34] | <symbioquine[m]> | There's an interesting question of default asset ownership on [PR #537](https://github.com/farmOS/farmOS/pull/537) if other folks are interested in chiming in too... |
| [10:29:56] | <mstenta[m]> | Woke up early today and got caught up with farmOS PRs :-) |
| [10:29:57] | <mstenta[m]> | felt good! |
| [10:31:28] | <mstenta[m]> | The following issues are ready for review before merging: |
| [10:31:28] | <mstenta[m]> | - https://www.drupal.org/project/farm/issues/3305724 |
| [10:31:28] | <mstenta[m]> | - https://www.drupal.org/project/farm/issues/3306227 (this might not be necessary, but curious thoughts) |
| [10:31:28] | <mstenta[m]> | - https://github.com/farmOS/farmOS/pull/537 |
| [10:39:09] | <FarmerEd[m]> | Personally don't require a default ownership of Assets on my farm as all assets would be mine, so by default the preference for me would be to assume all assets are either mine or simply the farms. Would there be an argument for a profile checkbox for default owner? |
| [10:39:09] | <FarmerEd[m]> | Like Manager, worker and "Owner" |
| [10:41:46] | <FarmerEd[m]> | One could go nuts, and have multiple default owners definable by modules for different owner types? Equipment owner, Livestock owner, plant etc |
| [10:42:09] | <mstenta[m]> | Post these ideas in the github thread Farmer Ed 😄 |
| [10:42:45] | <mstenta[m]> | It sounds like most opinions are against auto-populating right now (which is good - means it's pretty much ready to merge) |
| [10:42:54] | <FarmerEd[m]> | can do, just thinking out loud first, don't want to build a Bradly tank either |
| [10:48:08] | <FarmerEd[m]> | Not sure, if the rest of the world has a definition of "Livestock Keeper". Here a keeper is legally responsible for the wellbeing and record keeping of a herd or flock on a farm. |
| [10:51:04] | <FarmerEd[m]> | There can be only one keeper per livestock type on a farm |
| [10:51:04] | <FarmerEd[m]> | So could have different keepers for Cattle, Sheep, pigs, poultry etc. |
| [10:51:04] | <FarmerEd[m]> | So could be useful for different default owners on mixed farms. |
| [10:51:04] | <FarmerEd[m]> | But I'm sure that PR is probably been held up enough already. |
| [10:51:36] | <mstenta[m]> | Ha! Yea we punted on what "owner" means and said that other modules can make those assumptions |
| [10:51:45] | <mstenta[m]> | This is just about adding a field :-P |
| [10:51:59] | <FarmerEd[m]> | The keeper does not need to be the actual owner either. |
| [10:52:28] | <mstenta[m]> | Yea we discussed that "legal owner" might need to be a different thing entirely |
| [10:52:38] | <mstenta[m]> | I'm thinking of this right now as "owner of the record" |
| [10:53:05] | <mstenta[m]> | (which MAYBE is also "owner of the asset" - but that's up to the user) |
| [10:54:11] | <FarmerEd[m]> | exactly, owner makes sense generally, something like keeper would be too specific to livestock (and possibly Regions) |
| [10:57:18] | <FarmerEd[m]> | Anyway, I guess owner field empty by default would be best to close the PR. Can probably achieve my ramblings by implemeting a Keeper/owner module utilizing that field in the future. |
| [11:10:42] | <FarmerEd[m]> | I like this one https://www.drupal.org/project/farm/issues/3306227, events for assets could be useful, I'm trying to automate as much as possible synchronization of livestock assets between the the Department of Ag database and farmOS, could be useful for certain logs to be generated when a new Asset is created. Like a birth log if a new calf is added with a mother already in my herd, I can already achieve this externally but the simpler |
| [11:10:43] | <FarmerEd[m]> | the better. |
| [11:13:29] | <FarmerEd[m]> | Although if it is being worked on upstream already, I can probably wait for that anyway. |
| [11:13:30] | <mstenta[m]> | Great! I'm open to adding it |
| [11:13:44] | <mstenta[m]> | We'll have to deal with the upstream merge with Log entities anyway, so it's not a huge deal either way |
| [11:13:55] | <mstenta[m]> | Post your comment in that thread, if you don't mind |
| [11:16:30] | <FarmerEd[m]> | done |
| [11:23:45] | <mstenta[m]> | paul121: any objections to merging this one? https://www.drupal.org/project/farm/issues/3306227 |
| [11:23:55] | <mstenta[m]> | I'm about to sign off but I'm in the mood to merge something 😆 |
| [11:24:27] | <paul121[m]> | haha looking now |
| [11:25:12] | <mstenta[m]> | (definitely not urgent) |
| [11:25:47] | <mstenta[m]> | going to try to figure out the failing test (missing schema) on the asset owner PR now... |
| [11:26:37] | <paul121[m]> | yeah LGTM. it's quite simple |
| [11:28:17] | <mstenta[m]> | great! thanks! yea it's a simple one - copied directly from the log module + search and replace s/log/asset :-) |
| [17:54:47] | <paul121[m]> | Implemented collapsible filters today! https://www.drupal.org/project/farm/issues/3306344 |
| [17:54:47] | <paul121[m]> | It would be nice if folks could test it to make sure it works and looks fine across different browsers. There is a tugboat instance that was created from the MR and should be live for a few days, all you gotta do is login here w/ credentials manager/manager and try it out! https://mr68-dwjlsz92zrggtuwoxchdywemmvfnxpbd.tugboatqa.com/assets |
| [17:55:27] | <paul121[m]> | I learned about the views display extender plugin. A really cool tool.... check the video I uploaded to that issue |