| [01:16:59] | * FarmerEd[m] has quit (*.net *.split) |
| [01:16:59] | * symbioquine[m] has quit (*.net *.split) |
| [01:16:59] | * jgaehring[m] has quit (*.net *.split) |
| [01:16:59] | * paul121[m] has quit (*.net *.split) |
| [01:16:59] | * mstenta[m] has quit (*.net *.split) |
| [01:20:18] | * FarmerEd[m] has joined #farmos |
| [01:20:51] | * paul121[m] has joined #farmos |
| [01:20:51] | * jgaehring[m] has joined #farmos |
| [01:20:51] | * mstenta[m] has joined #farmos |
| [01:20:51] | * symbioquine[m] has joined #farmos |
| [02:43:16] | * farmBOT has joined #farmos |
| [10:11:04] | <mstenta[m]> | paul121: Codesniffer tests just started failing... |
| [10:11:15] | <mstenta[m]> | Throwing a bunch of `Unused static variable` warnings all over the place. |
| [10:11:22] | <mstenta[m]> | Have you encountered this? |
| [10:11:27] | <mstenta[m]> | https://github.com/farmOS/farmOS/runs/7839166676?check_suite_focus=true |
| [11:11:31] | <paul121[m]> | Yeah I got a bunch of emails over the weekend... just looking now |
| [11:11:40] | <paul121[m]> | same thing: https://github.com/paul121/farm_farmlab/runs/7834231507?check_suite_focu... |
| [11:11:51] | <mstenta[m]> | Huh something must have changed upstream |
| [11:11:59] | <mstenta[m]> | No recent releases of drupal.org/project/coder... |
| [11:12:32] | <paul121[m]> | Wonder if we can run `phpcs` with a flag that includes the sniff name |
| [11:24:39] | <paul121[m]> | hmm pulled the latest 2.x-dev image and did a diff with the `phpcs.xml` that I already had. its the same: |
| [11:24:39] | <paul121[m]> | `$ diff phpcs.xml /var/farmOS/phpcs.xml ` |
| [11:25:05] | <mstenta[m]> | IIRC there was a new codesniffer dependency package added recently... I wonder if it's related to that |
| [11:27:34] | <paul121[m]> | ah yeah, this: https://github.com/farmOS/farmOS/pull/542 |
| [11:27:34] | <paul121[m]> | So drupal/coder depends on this `phpcodesniffer-composer-installer` composer plugin |
| [11:27:59] | <paul121[m]> | maybe this is the issue: https://github.com/farmOS/farmOS/runs/7839071435?check_suite_focus=true#... |
| [11:29:38] | <mstenta[m]> | Hmm so we do have this line in our dev `Dockerfile`: https://github.com/farmOS/farmOS/blob/fc77c86abe6b142702e7b103cd85e0c207... |
| [11:29:54] | <mstenta[m]> | But none of this broke when we merged #542 earlier |
| [11:33:00] | <paul121[m]> | And this had a release two days ago: https://github.com/sirbrillig/phpcs-variable-analysis/releases |
| [11:33:29] | <mstenta[m]> | https://github.com/sirbrillig/phpcs-variable-analysis/pull/267 |
| [11:33:46] | <mstenta[m]> | https://github.com/sirbrillig/phpcs-variable-analysis/issues/272 |
| [11:33:58] | <mstenta[m]> | Looks like that's it |
| [11:35:10] | <paul121[m]> | replicated on my local, using -s for the sniffs:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/c48b83982e...) |
| [11:38:13] | <paul121[m]> | ha, yeah `DrupalPractice.CodeAnalysis.VariableAnalysis` simply extends that dependency |
| [11:38:34] | <paul121[m]> | V |
| [11:38:43] | <paul121[m]> | https://git.drupalcode.org/project/coder/-/blob/8.3.x/coder_sniffer/Drup... |
| [12:08:27] | <mstenta[m]> | Alright - so maybe this will just get fixed upstream in a patch release to `sirbrillig/phpcs-variable-analysis` soon? |
| [12:08:45] | <mstenta[m]> | > Sorry for the regression! Thanks for the fix, @arkener! I'll put out a patch release shortly as soon as I check out #271 |
| [12:08:45] | <mstenta[m]> | - @sirbrillig |
| [12:24:59] | <paul121[m]> | ah yeah, sounds like it |
| [15:01:53] | <symbioquine[m]> | https://farmos.discourse.group/t/asset-link-dev-log/1175/20?u=symbioquine |