| [02:14:33] | * _Votes78 has quit (Quit: ZNC 1.8.2 - https://znc.in) |
| [02:14:59] | * Votes78 has joined #farmos |
| [02:16:22] | * jonasbits has joined #farmos |
| [08:13:39] | <mstenta[m]> | Farmer Ed paul121 any objections to this? https://github.com/farmOS/farmOS/pull/555#issuecomment-1213047719 |
| [08:30:34] | <FarmerEd[m]> | No objections here. |
| [08:35:04] | <FarmerEd[m]> | I can have a go the general notifications module too, if that's of help. |
| [08:56:33] | <mstenta[m]> | I've got the branches ready to push |
| [08:56:53] | <mstenta[m]> | Do you mean generalizing some of the logic from `data_stream_notification` into `farm_notification`? That would be great to start exploring! |
| [08:57:00] | <mstenta[m]> | I can't speak to the complexity of that, paul121 did all that code |
| [10:35:13] | <FarmerEd[m]> | Yes, perhaps a big hole to bury myself in but can give it a look, if paul121: doesn't already have a plan. |
| [10:37:32] | <FarmerEd[m]> | I want to reuse some of the logic for other notifications module I'm working on anyway. And it may be the right place for some of the logic I've been working on for notifications methods other than email. |
| [10:50:11] | <mstenta[m]> | jgaehring: https://twitter.com/prestonso/status/1558086908919545859 |
| [11:47:51] | <paul121[m]> | <FarmerEd[m]> "I want to reuse some of the..." <- I 100% support this! Making this more general crossed our minds but we didn't have specific use-cases or funding to go beyond doing email notifications for parity with v1. So I'm really excited that you have use-cases now Farmer Ed and the ability to help implement it! |
| [11:47:52] | <paul121[m]> | Before abstracting things out we just need to make sure we do so in a sensible way. If you could gather some of your thoughts/requirements that would be really helpful. I think the data stream notification config schema should be helpful at seeing how things are laid out: https://github.com/farmOS/farmOS/tree/2.x/modules/core/data_stream/modul... |
| [11:47:52] | <paul121[m]> | It seems like we might need to add some concept of "notification_type"... but not sure. Overall I hope the existing `condition` and `delivery` plugin design will still work. Ideally the `delivery` plugins are designed to be compatible with any "notification_type". But I think it's natural that `condition` plugins might need to be specific for each "notification_type'. |
| [11:50:05] | <paul121[m]> | There are also two open issues that would be worth reading, not sure if you already have: |
| [11:50:05] | <paul121[m]> | - https://www.drupal.org/project/farm/issues/3230362 |
| [11:50:05] | <paul121[m]> | - https://www.drupal.org/project/farm/issues/3230360 |
| [11:50:05] | <paul121[m]> | The token replacement one would be *really* cool. Farmer Ed I'm not sure if you've seen this in drupal before, but its a cool way to add dynamic information when typing in a `textarea`. Basically you can add "tokens", so your email notification could include a link to the log with: `View the log here: [log:5:link]` (something like that) |
| [11:50:47] | <paul121[m]> | and iirc I have a start on the token replacement for email delivery somewhere.. |
| [11:51:25] | <paul121[m]> | <mstenta[m]> "Farmer Ed paul121 any objections..." <- going to leave a quick review, couple things |
| [11:58:06] | <paul121[m]> | going to be busy for the next few hours but lets continue thinking about this Farmer Ed :-) |
| [11:58:25] | <mstenta[m]> | Thanks for the review paul121 ! Good catches! |
| [11:58:41] | <mstenta[m]> | I'll take another pass when I have a chance |
| [11:59:25] | <paul121[m]> | andddd we should document notifications, sorry :-) |
| [11:59:45] | <paul121[m]> | (not in that PR just in general) |
| [12:01:07] | <FarmerEd[m]> | Cool Paul, I'll look through those when I get back to my computer later. |
| [12:01:07] | <FarmerEd[m]> | I can start a thread in the forum to share thoughts on this. |
| [12:01:07] | <FarmerEd[m]> | I'm busy myself for the next few hours |
| [12:01:20] | <FarmerEd[m]> | ACTION uploaded an image: (229KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/rLqjWSqsevt... > |
| [12:01:45] | <FarmerEd[m]> | Can't find a PHP fix for this🤔 |
| [12:02:32] | <FarmerEd[m]> | Oh and agree on the documention |
| [12:08:30] | <mstenta[m]> | `./phpcbf` |
| [12:23:26] | * Votes78 has quit (K-Lined) |
| [12:26:21] | * Votes78 has joined #farmos |
| [12:26:37] | * Votes78 has quit (K-Lined) |
| [15:22:58] | * Votes78 has joined #farmos |
| [15:23:07] | * Votes78 has quit (K-Lined) |
| [15:27:13] | * Votes78 has joined #farmos |
| [15:27:27] | * Votes78 has quit (K-Lined) |
| [18:37:02] | * Votes78 has joined #farmos |
| [18:37:17] | * Votes78 has quit (K-Lined) |
