| [23:01:41] | * FreshiesFarmsLLC has quit (K-Lined) |
| [23:01:44] | * skipper_is[m] has quit (K-Lined) |
| [23:01:45] | * MarcosCarballal[ has quit (K-Lined) |
| [23:01:45] | * symbioquine[m] has quit (K-Lined) |
| [23:01:45] | * qoyyuum[m]1 has quit (K-Lined) |
| [23:01:46] | * coilWinder[m] has quit (K-Lined) |
| [23:01:46] | * mstenta[m] has quit (K-Lined) |
| [23:01:46] | * sgoodall[m] has quit (K-Lined) |
| [23:01:46] | * paul121[m] has quit (K-Lined) |
| [23:01:46] | * Noaht[m] has quit (K-Lined) |
| [23:01:47] | * jgaehring[m] has quit (K-Lined) |
| [23:01:47] | * scrdcow[m] has quit (K-Lined) |
| [23:39:54] | * spitz234[m] has joined #farmos |
| [23:39:54] | * Anonymous[m]12 has joined #farmos |
| [23:39:55] | * raul[m] has joined #farmos |
| [23:39:55] | * CoilWindernovuso has joined #farmos |
| [23:40:06] | * IyarkaiTechLab[m has joined #farmos |
| [23:40:06] | * farmtech[m] has joined #farmos |
| [23:40:06] | * paul121[m] has joined #farmos |
| [23:40:06] | * iuresearcherpw[m has joined #farmos |
| [23:40:06] | * mindcls[m] has joined #farmos |
| [23:40:06] | * postmanpat[m] has joined #farmos |
| [23:40:06] | * symbioquine[m] has joined #farmos |
| [23:40:06] | * SpencerOnazi[m] has joined #farmos |
| [23:40:06] | * kunigunde[m] has joined #farmos |
| [23:40:06] | * mstenta[m] has joined #farmos |
| [23:40:06] | * frederike[m] has joined #farmos |
| [23:40:06] | * munjoma[m] has joined #farmos |
| [23:40:06] | * davd[m] has joined #farmos |
| [23:40:06] | * olaf[m] has joined #farmos |
| [23:40:06] | * gunter[m] has joined #farmos |
| [23:40:06] | * phantomse[m] has joined #farmos |
| [23:40:07] | * OmkarEkbote[m] has joined #farmos |
| [23:40:07] | * and712[m] has joined #farmos |
| [23:40:07] | * qoyyuum[m] has joined #farmos |
| [23:40:07] | * gretel[m] has joined #farmos |
| [23:40:07] | * aislinnpearson[m has joined #farmos |
| [23:40:07] | * steinfarm[m] has joined #farmos |
| [23:40:07] | * matrixtrix[m] has joined #farmos |
| [23:40:07] | * harry[m]12 has joined #farmos |
| [23:40:07] | * lordeddi[m] has joined #farmos |
| [23:40:07] | * scrdcow[m] has joined #farmos |
| [23:40:07] | * AllanMacGregor[m has joined #farmos |
| [23:40:07] | * med65[m] has joined #farmos |
| [23:40:07] | * Noaht[m] has joined #farmos |
| [23:40:07] | * oliverp44[m] has joined #farmos |
| [23:40:07] | * MarcosCarballal[ has joined #farmos |
| [23:40:08] | * jgaehring[m] has joined #farmos |
| [23:40:08] | * hra38192639[m] has joined #farmos |
| [23:40:08] | * goldi[m] has joined #farmos |
| [23:40:08] | * skipper_is[m] has joined #farmos |
| [23:40:08] | * shane_aldrich[m] has joined #farmos |
| [23:40:08] | * sgoodall[m] has joined #farmos |
| [23:40:08] | * ChristophWolfes[ has joined #farmos |
| [23:40:09] | * JanSonntag[m] has joined #farmos |
| [23:40:09] | * ludwa6[m] has joined #farmos |
| [23:40:09] | * FreshiesFarmsLLC has joined #farmos |
| [23:49:06] | * spitz234[m] has quit (Quit: Client limit exceeded: 20000) |
| [23:49:32] | * CoilWindernovuso has quit (Quit: Client limit exceeded: 20000) |
| [11:00:20] | * Anonymous[m]12 has quit (Quit: You have been kicked for being idle) |
| [13:48:09] | * raul[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * farmtech[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * harry[m]12 has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * steinfarm[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * aislinnpearson[m has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * matrixtrix[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * postmanpat[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * symbioquine[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * gunter[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * munjoma[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * SpencerOnazi[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * oliverp44[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * MarcosCarballal[ has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * AllanMacGregor[m has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * med65[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * goldi[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * hra38192639[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * FreshiesFarmsLLC has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * gretel[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * qoyyuum[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * IyarkaiTechLab[m has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * mstenta[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * ChristophWolfes[ has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * frederike[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * davd[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * scrdcow[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * jgaehring[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * phantomse[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * kunigunde[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * iuresearcherpw[m has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * mindcls[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * Noaht[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * lordeddi[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * ludwa6[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:09] | * JanSonntag[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:10] | * olaf[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:10] | * paul121[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:16] | * skipper_is[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:16] | * shane_aldrich[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:16] | * sgoodall[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:16] | * and712[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:48:16] | * OmkarEkbote[m] has quit (Quit: Bridge terminating on SIGTERM) |
| [13:51:34] | * calbasi[m] has joined #farmos |
| [14:07:08] | * spitz234[m] has joined #farmos |
| [14:07:09] | * raul[m] has joined #farmos |
| [14:07:09] | * CoilWindernovuso has joined #farmos |
| [14:07:20] | * mstenta[m] has joined #farmos |
| [14:07:20] | * munjoma[m] has joined #farmos |
| [14:07:20] | * kunigunde[m] has joined #farmos |
| [14:07:20] | * davd[m] has joined #farmos |
| [14:07:20] | * and712[m] has joined #farmos |
| [14:07:20] | * OmkarEkbote[m] has joined #farmos |
| [14:07:20] | * frederike[m] has joined #farmos |
| [14:07:20] | * gretel[m] has joined #farmos |
| [14:07:20] | * SpencerOnazi[m] has joined #farmos |
| [14:07:20] | * jgaehring[m] has joined #farmos |
| [14:07:20] | * paul121[m] has joined #farmos |
| [14:07:20] | * goldi[m] has joined #farmos |
| [14:07:20] | * postmanpat[m] has joined #farmos |
| [14:07:20] | * gunter[m] has joined #farmos |
| [14:07:20] | * IyarkaiTechLab[m has joined #farmos |
| [14:07:20] | * farmtech[m] has joined #farmos |
| [14:07:21] | * shane_aldrich[m] has joined #farmos |
| [14:07:21] | * JanSonntag[m] has joined #farmos |
| [14:07:21] | * phantomse[m] has joined #farmos |
| [14:07:21] | * aislinnpearson[m has joined #farmos |
| [14:07:21] | * steinfarm[m] has joined #farmos |
| [14:07:21] | * oliverp44[m] has joined #farmos |
| [14:07:21] | * Noaht[m] has joined #farmos |
| [14:07:21] | * qoyyuum[m] has joined #farmos |
| [14:07:21] | * ChristophWolfes[ has joined #farmos |
| [14:07:21] | * harry[m]12 has joined #farmos |
| [14:07:21] | * ludwa6[m] has joined #farmos |
| [14:07:21] | * skipper_is[m] has joined #farmos |
| [14:07:21] | * iuresearcherpw[m has joined #farmos |
| [14:07:21] | * med65[m] has joined #farmos |
| [14:07:21] | * AllanMacGregor[m has joined #farmos |
| [14:07:21] | * sgoodall[m] has joined #farmos |
| [14:07:21] | * FreshiesFarmsLLC has joined #farmos |
| [14:07:21] | * lordeddi[m] has joined #farmos |
| [14:07:22] | * symbioquine[m] has joined #farmos |
| [14:07:22] | * matrixtrix[m] has joined #farmos |
| [14:07:23] | * MarcosCarballal[ has joined #farmos |
| [14:07:23] | * hra38192639[m] has joined #farmos |
| [14:07:23] | * olaf[m] has joined #farmos |
| [14:07:23] | * mindcls[m] has joined #farmos |
| [14:07:23] | * scrdcow[m] has joined #farmos |
| [14:07:23] | * Anonymous[m]1234 has joined #farmos |
| [14:16:44] | * calbasi[m] has quit (Quit: Client limit exceeded: 20000) |
| [14:25:05] | * spitz234[m] has quit (Quit: Client limit exceeded: 20000) |
| [14:25:20] | * CoilWindernovuso has quit (Quit: Client limit exceeded: 20000) |
| [14:34:47] | * raul[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * kunigunde[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * postmanpat[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * farmtech[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * IyarkaiTechLab[m has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * SpencerOnazi[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * OmkarEkbote[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * and712[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * Anonymous[m]1234 has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * davd[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * goldi[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * steinfarm[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * harry[m]12 has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * aislinnpearson[m has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * hra38192639[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * mindcls[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * olaf[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * iuresearcherpw[m has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * frederike[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * gretel[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * gunter[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * phantomse[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * AllanMacGregor[m has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * JanSonntag[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * ludwa6[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * lordeddi[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * oliverp44[m] has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:36:32] | * ChristophWolfes[ has quit (Quit: You% have% been% kicked% for% being% idle) |
| [14:46:35] | <symbioquine[m]> | Out of curiousity, shouldn't [this code](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) need to honor the field collection item revision id when selecting the animal id tag data? |
| [14:51:00] | <symbioquine[m]> | Also, why can the migration of [plant type taxonomy term parents](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) work recursively, but (presumably) asset parents can't - because they' |
| [14:51:04] | <symbioquine[m]> | s/Also, why can the migration of [plant type taxonomy term parents](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) work recursively, but (presumably) asset parents can't - because they'/Also, why can the migration of [plant type taxonomy term |
| [14:51:04] | <symbioquine[m]> | parents](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) work recursively, but (presumably because they're done in stages with the migration groups) asset parents can't?/ |
| [14:51:08] | <paul121[m]> | Oh, that is because assets can reference other assets as their "parent" |
| [14:51:14] | <paul121[m]> | Oh.. wait 😁 |
| [14:51:21] | <paul121[m]> | * ~Oh, that, * their "parent"~ |
| [14:51:28] | <paul121[m]> | Sorry thought I had a quick answer. But might be because assets are being migrated from areas and asset entities |
| [15:10:26] | <symbioquine[m]> | <paul121[m]> "Sorry thought I had a quick..." <- Yeah, that's one of my top hypotheses too. |
| [15:14:40] | <symbioquine[m]> | Well, actually I think that doesn't totally make sense since in 1.x an area couldn't be the parent of an asset or visa versa so there shouldn't be any relationships of that nature to migrate... |
| [15:55:10] | <mstenta[m]> | > Out of curiousity, shouldn't [this code](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) need to honor the field collection item revision id when selecting the animal id tag data? |
| [15:55:10] | <mstenta[m]> | symbioquine field collections were not revisioned in v1 - so they only had one ID |
| [15:55:34] | <mstenta[m]> | (iirc - speaking from memory here) |
| [15:55:34] | <symbioquine[m]> | Awesome! |
| [15:55:49] | <symbioquine[m]> | Was hoping that wasn't a lurking bug :) |
| [15:57:28] | <mstenta[m]> | > Also, why can the migration of [plant type taxonomy term parents](https://github.com/farmOS/farmOS/blob/04bf771d91cde8276b67090d2b97c4e455...) work recursively, but (presumably because they're done in stages with the migration groups) asset parents can't? |
| [15:57:28] | <mstenta[m]> | yea basically: terms (like plant type) could only reference parents in the same vocabulary, but technically it's possible for an asset to reference a parent of a different type |
| [15:57:47] | <mstenta[m]> | so we migrate all the asset parent relationships after we have migrated all the different asset types |
| [15:58:05] | <mstenta[m]> | in practice, that is probably never the case, but had to cover the possibility... |
| [15:59:10] | <mstenta[m]> | the reason we don't auto-assign parents for areas is because there are potentially multiple area migrations as well (eg: if a module provided a custom area type, they will need to provide a migration for that type too) |
| [15:59:10] | <symbioquine[m]> | Ah, I see. So through the UI you could only create in-bundle parent relationships, but technically the data model supported cross-bundle parent relationships so it seemed prudent to have the migration support those too? |
| [15:59:31] | <mstenta[m]> | actually i think the UI allowed cross-bundle relationships too |
| [15:59:36] | <mstenta[m]> | (and still does) |
| [15:59:38] | <symbioquine[m]> | oh :) |
| [15:59:54] | <mstenta[m]> | that may seem weird, but it actually enables some neat things... |
| [16:00:16] | <mstenta[m]> | eg: in the future, if we create "product" assets that get created from other asset types, they may reference those other assets as their parents |
| [16:00:27] | <symbioquine[m]> | Makes sense |
| [16:00:48] | <mstenta[m]> | or: you might harvest a Material asset from a Plant asset :-) |
| [16:01:04] | <symbioquine[m]> | yeah |
| [16:02:39] | <symbioquine[m]> | I'm trying to figure out whether https://www.drupal.org/project/farm/issues/3190851 is blocking me... In 1.x I had a module that added custom fields to the crop terms like this;... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/a685d67294...) |
| [16:03:14] | <symbioquine[m]> | Am I right in thinking something parallel to `FarmEntityBundlePluginHandler` is the cleanest way to handle that? |
| [16:04:43] | <mstenta[m]> | ah right... did you see how the `plant_type` terms add fields? |
| [16:04:50] | <mstenta[m]> | https://www.drupal.org/project/farm/issues/3190851 should not block you |
| [16:05:23] | <mstenta[m]> | https://github.com/farmOS/farmOS/blob/2.x/modules/taxonomy/plant_type/co... |
| [16:05:30] | <mstenta[m]> | https://github.com/farmOS/farmOS/blob/2.x/modules/taxonomy/plant_type/co... |
| [16:05:58] | <mstenta[m]> | tl;dr: there are technically two ways to add fields in Drupal 9... as "base/bundle" fields or as "config fields" |
| [16:06:05] | <mstenta[m]> | (terrible names, very confusing) |
| [16:06:18] | <symbioquine[m]> | Perfect! I'll try that :) |
| [16:07:02] | <mstenta[m]> | "config fields" are sort of the "normal" way to add fields... and that's possible for all entity types |
| [16:07:48] | <mstenta[m]> | for `asset`, `log`, `plan`, (and i think `quantity`?) we leverage the contrib `entity` module so that we have the option of defining fields in PHP code/classes instead |
| [16:08:46] | <mstenta[m]> | https://www.drupal.org/project/farm/issues/3190851 is basically to consider doing the same for `taxonomy_term` entities... although i don't know if the complexity will justify it |
| [16:10:14] | <mstenta[m]> | symbioquine[m]: the best way to add config fields is actually through the UI! enable the `field_ui` module and go to `/admin/structure/taxonomy` and "Manage fields" on the vocabulary you want |
| [16:10:38] | <mstenta[m]> | then, you can export their config to YML files in your module's `config/install` directory |
| [16:11:08] | <mstenta[m]> | (via `/admin/config/development/configuration/single/export`) |
| [16:11:34] | <mstenta[m]> | fields have two config entities: "field storage" and "field", which are equivalent to D7's "field storage" and "field instance" concepts |
| [16:11:47] | <mstenta[m]> | s/storage/base/ |
| [16:11:53] | <symbioquine[m]> | Yep, got it :) |
| [16:13:13] | <mstenta[m]> | you will also need to export two other config entities, if you want your new fields to be visible in the UI... |
| [16:13:24] | <mstenta[m]> | "entity form display" and "entity view display" |
| [16:14:15] | <mstenta[m]> | those basically configure the order of fields in form/display, as well as what widgets should be used |
| [16:14:35] | <mstenta[m]> | the annoying thing about those is: they include all fields on the bundle... not just the field you're adding |
| [16:15:13] | <mstenta[m]> | this is the core reason why we went with base/bundle fields instead of config fields for most things in farmOS core... to avoid the need to provide those entity form/view display config entities |
| [16:15:41] | <mstenta[m]> | this is probably one of the more complicated/annoying aspects of v2, IMO :-) |
| [16:16:16] | <mstenta[m]> | perhaps "less elegant that i would like" is a better descriptor :-) |
| [16:16:54] | <mstenta[m]> | but the hope is that some of this stuff will get ironed out in Drupal core upstream eventually... |
| [16:19:03] | <symbioquine[m]> | Hmmm, so without something like Config Rewrite, I'm stuck maintaining a copy (plus my fields) of those form/view display yml files? |
| [16:19:46] | <symbioquine[m]> | And if two modules needed to provide fields to the same entity, the changes couldn't be encapsulated within the module itself? |
| [16:20:14] | <mstenta[m]> | exactly |
| [16:20:21] | <symbioquine[m]> | Darn |
| [16:20:22] | <mstenta[m]> | that's why we avoided those for all the entity types we could |
| [16:20:34] | <symbioquine[m]> | I guess I've been spoiled by `hook_farm_entity_bundle_field_info` |
| [16:21:39] | <mstenta[m]> | yeaaa |
| [16:21:40] | <mstenta[m]> | :-/ |
| [16:22:01] | <mstenta[m]> | that only works for entity types with the bundle plugin handler stuff |
| [16:22:12] | <mstenta[m]> | so yea... if you wanted that then https://www.drupal.org/project/farm/issues/3190851 *is* a blocker |
| [16:33:30] | <symbioquine[m]> | Would there be any downside to adding the form/view display stuff with alter hooks? e.g. `hook_entity_form_display_alter` |
| [16:51:50] | <mstenta[m]> | huh - i can't remember but i think i looked into that... it was a long time ago |
| [16:52:35] | <mstenta[m]> | my gut memory is telling me "something doesn't work as expected with those hooks" haha but i could be wrong! worth a try if you want to test it out! |
| [16:53:49] | <symbioquine[m]> | Yeah, I'll see what happens :) |