| [11:24:12] | <symbioquine[m]> | Was it a conscious decision not to make the crop reference(s) on plant/seed assets not link to the term page? |
| [11:24:13] | <symbioquine[m]> | (In 2.x that is) |
| [11:24:20] | <symbioquine[m]> | It seems like this page is pretty useful; |
| [11:24:25] | <symbioquine[m]> | ACTION uploaded an image: (125KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/jegujHRCUca... > |
| [11:25:02] | <mstenta[m]> | we just haven't prioritized that page basically |
| [11:25:35] | <mstenta[m]> | there's also the "Crops/varieties" tab under Assets > Plantings (in 1.x) that we haven't replicated |
| [11:25:53] | <mstenta[m]> | but that one can basically be accomplished just with filters on the Plant asset list anyway, so it felt kind of unnecessary |
| [11:27:16] | * farmBOT has joined #farmos |
| [11:27:38] | <symbioquine[m]> | `/farm/assets/plantings/crops` in 1.x is more like `/admin/structure/taxonomy/manage/plant_type/overview` in 2.x than filtering in the plant asset list... |
| [11:28:12] | <mstenta[m]> | yea, and it had the counter next to each term to let you know how many active plantings were there |
| [11:28:23] | <mstenta[m]> | there isn't a way to get that count currently |
| [11:29:21] | <mstenta[m]> | "Term view page templating" might be a good general feature request |
| [11:29:37] | <mstenta[m]> | we could think about how to handle it in a way that works for all vocabs potentially |
| [11:29:42] | <symbioquine[m]> | mstenta[m]: It also would be ambiguous now that both plant and seed assets reference the crop terms. |
| [11:29:47] | <mstenta[m]> | and then enable linking to those pages |
| [11:30:23] | <mstenta[m]> | true - and iirc the count query wasn't perfect... although that was a LOOONG time ago so i forget |
| [11:30:24] | <symbioquine[m]> | Cool, makes sense |
| [11:31:30] | <mstenta[m]> | (it would also be nice to have those term pages so you could quickly find things that reference them... eg if you are trying to delete a term and the reference integrity constraint prevents you) |
| [11:31:43] | <symbioquine[m]> | mstenta[m]: It only shows unarchived assets, for one so it isn't helpful for finding/deleting unused terms. |
| [11:32:13] | <mstenta[m]> | yea i was never super satisfied with that page |
| [11:32:27] | <mstenta[m]> | we had the same sort of thing for animal species/breed too - with same limitations |
| [11:32:42] | <mstenta[m]> | so i figured if anyone asked about it, we could reconsider and maybe redesign |
| [11:32:57] | <symbioquine[m]> | mstenta[m]: Agreed. It's also nice to have a way to link to a single page that has a summary of the animal/plant type. |
| [11:34:52] | <symbioquine[m]> | I'll look into it... |
| [11:36:01] | <mstenta[m]> | cool! |
| [11:36:44] | <mstenta[m]> | for consistency, it would probably make the most sense to add "Assets" and "Logs" tabs to term pages that show assets/logs that reference them |
| [11:37:03] | <mstenta[m]> | with maybe sub-tabs under them for each asset/log type |
| [11:39:04] | <mstenta[m]> | the term pages themselves will probably be pretty sparse, since there aren't many fields on most of them |
| [11:39:08] | <mstenta[m]> | but i think that's OK |
| [11:40:34] | <mstenta[m]> | fwiw i think you would just need to change this line to make the term names into links to their pages: https://github.com/farmOS/farmOS/blob/2ec41cbe1cd821bfabc6020d37e57f71e0... |
| [11:51:29] | <symbioquine[m]> | <mstenta[m]> "fwiw i think you would just need..." <- Ah! That's what I was just looking for... |
| [11:53:52] | <mstenta[m]> | (plus a `drush cr`) |
