| [11:14:38] | <mstenta[m]> | symbioquine: hey @pcambra and I discovered a bug today... i'm not sure if it's a bug with farmOS-map.js or something else, but it is related to the way the `farmOS-map-chunk-*` files are being loaded |
| [11:15:01] | <mstenta[m]> | Wondering if you're around and could help us understand that a bit |
| [11:15:24] | <symbioquine[m]> | Sure :) |
| [11:15:52] | <mstenta[m]> | We are in Zoom - would you like to join for a second? No pressure if you're busy |
| [11:17:02] | <symbioquine[m]> | I can join |
| [17:19:24] | <symbioquine[m]> | fyi mstenta & @pcambra: I opened an issue for that farmOS-map + off-canvas dialog problem: https://www.drupal.org/project/farm/issues/3243922 |
| [17:20:04] | <symbioquine[m]> | I think i have a vague idea what's going on and will hopefully get a chance to summarize it on that issue soon... |
| [17:22:45] | <mstenta[m]> | symbioquine oh I'm very curious! Does it seem to be a Drupal/gin issue? Or still hard to say? |
| [17:22:59] | <mstenta[m]> | Thanks for investigating and opening an issue! |
| [17:24:53] | <symbioquine[m]> | Something about how `farmOS-map.js` itself is getting loaded as part of the off-canvas dialog defeats Webpack's mechanism for constructing the relative path. |
| [17:25:11] | <symbioquine[m]> | It's unclear if it's a bug with the off-canvas dialog per-se. |
| [17:25:27] | <symbioquine[m]> | Possibly more like an incompatibility... |
| [17:27:13] | <mstenta[m]> | Oh interesting |
| [17:27:25] | <symbioquine[m]> | In the off-canvas dialog the stacktraces for the requests to the chunks show "injectedScript"; |
| [17:27:30] | <symbioquine[m]> | ACTION uploaded an image: (405KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/PNieGpVcfHM... > |
| [17:28:12] | <mstenta[m]> | Well fwiw it would be cool to start using off canvas in farmOS core, but we don't have any immediate plans yet ... |
| [17:28:52] | <symbioquine[m]> | Whereas in a dedicated tab, the requests show "farmOS-map.js"; |
| [17:28:57] | <symbioquine[m]> | ACTION uploaded an image: (342KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/TXtFPGsHSrZ... > |
| [17:28:58] | <mstenta[m]> | Hmm interesting |
| [17:30:23] | <mstenta[m]> | Maybe it's a core off canvas issue? |
| [17:30:32] | <mstenta[m]> | (Drupal core) |
| [17:30:39] | <symbioquine[m]> | I have a work-around;... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/4736c3f409...) |
| [17:30:45] | <symbioquine[m]> | But it's not super elegant :( |
| [17:32:36] | <mstenta[m]> | So what's the deal with "injectedScript"? |
| [17:32:47] | <mstenta[m]> | Is drupal doing something odd? |
| [17:33:15] | <mstenta[m]> | 🤔 |
| [17:34:48] | <symbioquine[m]> | mstenta[m]: It doesn't look especially odd. It's just doing an [AJAX append command](https://www.drupal.org/docs/drupal-apis/ajax-api/core-ajax-callback-comm...) to add the script tag for `farmOS-map.js` to the body... |
| [17:35:09] | <symbioquine[m]> | Which yields an almost identical script tag to the non-off-canvas-dialog case. |
| [17:35:35] | <mstenta[m]> | Hmm ok |
| [17:36:23] | <symbioquine[m]> | The main differences in the script tag attributes are;... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/601f537cfa...) |
| [17:37:40] | <symbioquine[m]> | It could have something to do with the `async` attribute, but I haven't come up with a good way to test that easily yet... |
| [17:39:59] | <mstenta[m]> | I wonder if there's any open issues for similar things in the webpack community |
| [17:40:27] | <mstenta[m]> | s/I wonder if there's any open issues for similar things in the webpack community/I wonder if there are any open issues for similar things in the webpack community/ |
| [17:43:46] | <symbioquine[m]> | I did a little searching - by no means exhaustive. There's lots of similar kinds of issues, but none that looked like the same thing exactly... |
| [17:45:09] | <mstenta[m]> | Ah hmm |
| [17:46:06] | <paul121[m]> | <mstenta[m]> "Well fwiw it would be cool to..." <- yes plz :-) |
| [17:46:35] | <paul121[m]> | a goal for christmas |
| [18:02:58] | <symbioquine[m]> | I believe it is hitting this case in the dynamic path resolution and pulling a path from another script tag on the page; https://github.com/webpack/webpack/blob/8a6d156c156282dd3d0ba001187c2824... |
