| [11:48:50] | <symbioquine[m]> | The private file system path is supposed to be set automatically in farmOS 2.x right? |
| [11:49:22] | <symbioquine[m]> | ACTION uploaded an image: (186KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/MISmHNBHmdF... > |
| [11:50:13] | <symbioquine[m]> | ^ That's what I got with a fresh install on the latest image - though I'm just now testing image uploads again so it might have been this way for a while... :) |
| [11:52:03] | <paul121[m]> | I don't think we added anything to do that.. but should be in the docs? |
| [11:53:54] | <paul121[m]> | https://docs.farmos.org/development/environment/#configure-private-files... |
| [11:54:23] | <paul121[m]> | Maybe it should be included in the "hosting" docs too |
| [11:55:30] | <symbioquine[m]> | paul121[m]: Oh, yeah. That's what I need... :) |
| [11:57:48] | <paul121[m]> | Maybe we need a Drupal hosting 101 page. There's probably other general Drupal things that could be lumped together |
| [11:59:23] | <symbioquine[m]> | I'd argue that file uploads should work out of the box with a trivial `docker-compose.yml` file. |
| [15:38:13] | <mstenta[m]> | Hey just seeing this |
| [15:38:43] | <mstenta[m]> | I think the challenge with private file path is it needs to be added to settings.php, which Drupal generates during install |
| [15:39:17] | <mstenta[m]> | I wonder if we could add an install step that does that 🤔 |
| [15:40:40] | <mstenta[m]> | Or maybe there's some other way we can set that outside of settings.php - as a default fallback at least |
| [15:41:32] | <mstenta[m]> | Either way I agree we should mention it in the hosting docs 👍 |
| [15:42:28] | <mstenta[m]> | At the bottom of https://docs.farmos.org/hosting/install/ probably |
| [15:43:09] | <paul121[m]> | Reminds me of the drupal/core-composer-scaffold plugin - read these docs recently: https://github.com/drupal/core-composer-scaffold#overwrite |
| [15:43:37] | <paul121[m]> | It seems possible to overwrite the settings.php |
| [15:43:48] | <mstenta[m]> | Ah perhaps |
| [15:43:58] | <paul121[m]> | that's prob too much - but appending would be cool? |
| [15:44:18] | <mstenta[m]> | But the composer install happens before the settings.php is created. I think that's the main issue |
| [15:44:42] | <mstenta[m]> | Yea I wonder if we could use a hook install tasks |
| [15:45:02] | <mstenta[m]> | s/a hook install tasks/hook_install_tasks()/ |
| [15:45:25] | <mstenta[m]> | That might fire after settings.php is created |
| [15:45:47] | <mstenta[m]> | But... |
| [15:45:48] | <mstenta[m]> | We can't assume that everyone is using docker |
| [15:45:57] | <mstenta[m]> | So the absolute path might be different |
| [15:46:32] | <mstenta[m]> | (path to the private files) |
| [15:46:58] | <mstenta[m]> | I think that's why it might need to be a manual step |
| [15:47:29] | <mstenta[m]> | a) in docker contexts we know the path but settings.php doesn't exist yet |
| [15:47:58] | <mstenta[m]> | b) in hook install we have settings.php but we can't assume the path |
| [15:48:39] | <mstenta[m]> | (there might be a clever solution) :-) |
| [15:48:54] | <mstenta[m]> | But at the very least let's document the manual step |
| [16:00:26] | <paul121[m]> | maybe a composer script: https://getcomposer.org/doc/articles/scripts.md |
| [16:00:26] | <paul121[m]> | on the `post-drupal-scaffold-cmd` hook: https://github.com/drupal/core-composer-scaffold#altering-scaffold-files |
| [16:01:35] | <paul121[m]> | don't know much about these composer scripts, but seems useful. kinda like a docker entrypoint? |
| [19:07:17] | * farmBOT has joined #farmos |
