| [20:12:14] | <shane_aldrich[m]> | So I think it might be related to me not having the xml file loaded there yet. I'll investigate further when I can. Updates to my modules probably won't happen until Thursday. |
| [20:25:37] | <mstenta[m]> | ACTION posted a file: (1KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/MQFPMAaYmVR... > |
| [20:28:42] | <mstenta[m]> | That's the config file from my local setup (which was generated in the Dockerfile build) |
| [20:28:56] | <mstenta[m]> | It's in the same directory as my `composer.json` |
| [20:31:27] | <mstenta[m]> | The Dockerfile runs `/var/farmOS/vendor/bin/phpcs --config-set installed_paths /var/farmOS/vendor/drupal/coder/coder_sniffer` to ensure that the path to the drupal `coder` module is included (you would change `/var/farmOS` to the location of your farmOS directory) |
| [20:31:51] | <mstenta[m]> | https://github.com/farmOS/farmOS/blob/a00edf93cd82f860dbbd2cf1b5c8c25cd2... |
| [20:34:43] | <mstenta[m]> | And then to run codesniffer in terminal, you can do: `vendor/bin/phpcs web/profiles/farm` (I think?) |
| [20:35:20] | <mstenta[m]> | In the Docker context, you can run codesniffer with: `docker exec -it -u www-data farmos_www_1 phpcs /opt/drupal/web/profiles/farm` |
| [20:37:26] | <mstenta[m]> | (The `docker exec -it -u www-data farmos_www_1` part is just saying "run this command as the `www-data` user in the `farmos_www_1` container... and then the second part is just the command to run: `phpcs /opt/drupal/web/profiles/farm`, which runs the codesniffer on the farmOS installation profile directory) |
| [20:37:38] | <mstenta[m]> | * (The `docker exec -it -u www-data farmos_www_1` part is just saying "run this command as the `www-data` user in the `farmos_www_1` container"... and then the second part is just the command to run: `phpcs /opt/drupal/web/profiles/farm`, which runs the codesniffer on the farmOS installation profile directory) |
| [20:38:58] | <mstenta[m]> | This is how I do it locally, and how the automated tests run in GitHub Actions: https://github.com/farmOS/farmOS/blob/a00edf93cd82f860dbbd2cf1b5c8c25cd2... |
| [20:39:24] | <mstenta[m]> | I haven't ever tried hooking it up to run directly in PHPStorm, so I'm not sure what's involved with that |
| [20:42:40] | <mstenta[m]> | I actually have a bash alias for it :-) |
| [20:42:40] | <mstenta[m]> | `alias fcode='sudo docker exec -it -u www-data farmos_www_1 vendor/bin/phpcs /opt/drupal/web/profiles/farm'` |
| [20:42:40] | <mstenta[m]> | So I can just run `fcode` to scan the farmOS codebase I'm working on locally |
| [12:49:25] | <symbioquine[m]> | The `farm_map_google` module for 2.x is now functional: https://github.com/symbioquine/farm_map_google |
| [12:55:22] | <mstenta[m]> | Awesome!!! |
| [12:57:06] | <symbioquine[m]> | ... and its installable via `composer require drupal/farm_map_google` |
| [12:59:17] | <paul121[m]> | very nice!! |
| [12:59:17] | <paul121[m]> | how can I safely archive my repo ? :-) |
| [12:59:22] | <symbioquine[m]> | https://github.com/symbioquine/farm_map_google/blob/aa57bbd4953d1b88e86b... |
| [12:59:22] | <symbioquine[m]> | The main bit that isn't automated is creating the actual installable releases on the drupal.org project - but that's arguably a good thing... |
| [12:59:53] | <symbioquine[m]> | <paul121[m] "how can I safely archive my repo"> I don't think there'll be any problem if you just go ahead and archive it :) |
| [13:00:41] | <symbioquine[m]> | I think https://github.com/symbioquine/farm_map_google will continue to say that it was forked from that one, but that's accurate. |
| [18:03:15] | <shane_aldrich[m]> | <mstenta[m] "phpcs.xml"> That's the exact code I copied from your Docker link. ;) I have the xml file in PhpStorm as a custom `ruleset` but I'm getting an error: `phpcs: ERROR: Referenced sniff "Drupal" does not exist` |
| [18:04:37] | <mstenta[m]> | Oh yes... |
| [18:04:56] | <mstenta[m]> | `composer require drupal/coder` |
| [18:05:06] | <mstenta[m]> | That should fix it |
| [18:07:21] | <shane_aldrich[m]> | What version of coder should I use? Right now I have that in the `composer.json` file as `^8.3.10`. From PhpStorm I can open the `composer.json` file and click install, then it installs all dependencies. But still get the error. |
| [18:08:24] | <shane_aldrich[m]> | And it says to open "Open PHPCodeSniffer Inspection Settings" |
| [18:08:45] | <mstenta[m]> | > `composer require drupal/coder` |
| [18:08:46] | <mstenta[m]> | This should install it |
| [18:08:59] | <mstenta[m]> | But I'm getting to the edge of my usefulness here :-) |
| [18:09:27] | <mstenta[m]> | Like I said I've never used it directly in phpstorm |
| [18:09:40] | <mstenta[m]> | Just command kind y |
| [18:09:41] | <mstenta[m]> | Line* |
| [18:10:06] | <shane_aldrich[m]> | No worries! This is the last thing I want to configure properly there. Tomorrow is more open for working on the modules. |
| [18:13:16] | <shane_aldrich[m]> | Damn. I'm getting the `drupal/state_machine` error again. |