| [08:05:27] | * Kingdutch has joined #farmos |
| [08:07:36] | * The_Kingdutch has quit (Ping timeout: 256 seconds) |
| [11:26:59] | <mstenta[m]> | symbioquine: we're updating to Composer 2, but it appears that `nathandentzau/composer-patches-dev` doesn't support it yet |
| [11:27:26] | <mstenta[m]> | iirc, the only reason we have that is to patch drupal core for paratest, and only in the dev environment |
| [11:27:39] | <mstenta[m]> | so i think i may just move it from `patches-dev` to `patches` and remove that dependency |
| [11:27:42] | <mstenta[m]> | what do you think? |
| [11:27:54] | <symbioquine[m]> | Hmmm, weren't there other patches... |
| [11:28:18] | <mstenta[m]> | We do already include `cweagans/composer-patches` |
| [11:28:20] | <symbioquine[m]> | https://github.com/farmOS/farmOS/blob/2cd058167f7e0534357edd446dd526c693... |
| [11:28:33] | <symbioquine[m]> | ah, so just the patches-dev part doesn't work? |
| [11:28:38] | <mstenta[m]> | We only added `nathandentzau/composer-patches-dev` for `patches-dev` |
| [11:28:41] | <mstenta[m]> | yea |
| [11:28:44] | <symbioquine[m]> | yeah, I see |
| [11:28:59] | <symbioquine[m]> | Cool, I think that makes sense then |
| [11:29:10] | <mstenta[m]> | I'll push a test to my fork and see how it goes |
| [11:32:46] | <symbioquine[m]> | It would be nice if they'd get back to me with a review on https://www.drupal.org/project/drupal/issues/3192365 sometime soon... |
| [11:33:13] | <symbioquine[m]> | I don't have a sense for how long changes like that normally take though. |
| [11:33:41] | <mstenta[m]> | maybe i'll set it to "Reviewed and Tested by the Community" ... see if that nudges them :-) |
| [11:34:40] | <symbioquine[m]> | Thanks! |
| [11:35:50] | <mstenta[m]> | but yea in general molasses moves faster than core issues |
| [11:42:54] | <mstenta[m]> | wow @longwave responded pretty quickly after that :-) |
| [11:43:02] | <mstenta[m]> | he's a long time drupal contributor |
| [11:46:16] | <symbioquine[m]> | Yeah, that's a good question he raises... I definitely haven't tested it under windows. |
| [11:51:16] | <mstenta[m]> | blarg - hitting some other issues with composer 2 now |
| [11:51:37] | <mstenta[m]> | (should have known this would be a rabbit hole) |
| [11:51:48] | <symbioquine[m]> | :) |
| [12:37:18] | <mstenta[m]> | symbioquine paul121 fyi i'm doing a bit of force-pushing on `composer-project` to try to figure out the composer 2 issue... (poor form i know.. sorry) |
| [12:38:24] | <mstenta[m]> | (maybe i'll try to right it up so i can test without doing that...) |
| [12:38:30] | <mstenta[m]> | * (maybe i'll try to rig it up so i can test without doing that...) |
| [12:39:08] | <symbioquine[m]> | Wouldn't that mean that folks building their own images at the same time might get unpredictable results? |
| [12:39:42] | <mstenta[m]> | yes. (poor form) |
| [12:39:50] | <mstenta[m]> | i'll undo and find a better way. |
| [12:41:13] | <symbioquine[m]> | Can't you just set `PROJECT_REPO` for the docker build? |
| [12:41:43] | <mstenta[m]> | yea doing that now (admittedly i was being lazy. and optimistic that it was going to work on the first try) |
| [12:42:19] | <mstenta[m]> | thank you for shaking sense into me |
| [12:43:30] | <mstenta[m]> | on a related note... i'd love to merge the `composer-project/composer.json` file into the farmOS repo at some point... and automate subtree-splitting it out to its own repo via github actions or something |
| [12:44:17] | <symbioquine[m]> | <mstenta[m] "on a related note... i'd love to"> Sounds interesting... is there an issue for that already? |
| [12:44:28] | <mstenta[m]> | i don't think so |
| [12:45:02] | <paul121[m]> | `composer repositories.farmos git $path_to_repo` |
| [12:45:03] | <mstenta[m]> | i did some digging a while back... Drupal core does this for it's own https://github.com/drupal/recommended-project |
| [12:46:17] | <mstenta[m]> | (i believe... or maybe that's just for https://github.com/drupal/core) |
| [12:46:29] | <mstenta[m]> | i think this is the related issue: https://www.drupal.org/project/infrastructure/issues/2352091 |
| [12:47:59] | <paul121[m]> | I did something similar for the tugboat config. But doesn't solve the problem of how to organize our farmos repo |
| [16:34:57] | <mstenta[m]> | Got Composer 2 working :-) |
| [16:41:53] | <mstenta[m]> | Now we just need to get onto PHP 8 ;-) |
| [16:42:04] | <mstenta[m]> | (https://www.drupal.org/project/farm/issues/3186530) |
| [16:58:00] | <mstenta[m]> | symbioquine: do you know if it's possible to use `matrix.strategy` *in-between* sets of steps in github actions? |
| [16:59:02] | <mstenta[m]> | ACTION < https://matrix.org/_matrix/media/r0/download/matrix.org/dBXxjWMQFrJPzgDy... > |
| [16:59:20] | <mstenta[m]> | (where only step 2 would run in parallel) |
| [16:59:34] | <mstenta[m]> | * (where only step 2 would run the tests in three databases in parallel) |
| [17:01:03] | <mstenta[m]> | the reason I ask: i'm thinking about moving to using github actions to build our Docker images and then push to Docker Hub, instead of having Docker Hub do that itself... for a couple of reasons |
| [17:01:29] | <mstenta[m]> | and it would be cool if we could set it up to only push to docker hub if the tests pass |
| [17:01:39] | <mstenta[m]> | but we wouldn't want to build/push three times |
| [17:02:42] | <mstenta[m]> | one of the reasons for building via GitHub Actions is we could build ARM images :-) |
| [17:02:44] | <mstenta[m]> | https://github.com/farmOS/farmOS/issues/339 |
| [17:02:48] | <symbioquine[m]> | Hmmm, I don't think it's easy without pushing the image somewhere between the steps... But I can take a look this evening once I'm back at my computer. |
| [17:03:10] | <mstenta[m]> | oh no worries - just curious - not something i'm planning on doing soon :-) |
| [17:03:38] | <mstenta[m]> | that github issue just got my gears turning - it would be cool to pull some of these things together into github actions |
| [17:04:03] | <symbioquine[m]> | Yeah! |
| [17:04:27] | <mstenta[m]> | it would improve the docker hub images too - by ensuring they are always passing tests before they get published |
| [17:06:12] | <mstenta[m]> | Alternatively, I wonder if it's possible for one GitHub Action workflow to trigger a different workflow? |
| [17:07:12] | <mstenta[m]> | and then split them up - eg: have one master that runs whenever something is pushed, which builds the images, runs the tests in a different workflow, and then continues if it passes |
| [17:08:40] | <symbioquine[m]> | I think that's possible, but it requires pushing the image somewhere in between them |
| [17:08:54] | <mstenta[m]> | mmm interesting - ok |
| [17:08:59] | <mstenta[m]> | github has a container registry |
| [17:09:17] | <mstenta[m]> | maybe we could use that as a temporary in-between, but delete the images automatically after they are pushed to docker hub |
| [17:09:27] | <symbioquine[m]> | Yeah something like that could work |
| [17:09:43] | <mstenta[m]> | ⚙️🤔 |
| [17:12:58] | <mstenta[m]> | i'll spin up an issue for future explorations... |
| [17:35:59] | <mstenta[m]> | https://www.drupal.org/project/farm/issues/3203129 |
| [18:15:20] | * justanormalguy has joined #farmos |