| [19:15:31] | * calbasi_matrix has quit (Ping timeout: 265 seconds) |
| [19:15:54] | * linus0[m] has quit (Ping timeout: 246 seconds) |
| [19:17:54] | * calbasi_matrix has joined #farmos |
| [19:19:33] | * linus0[m] has joined #farmos |
| [20:45:25] | * botlfarm[m] has quit (Ping timeout: 265 seconds) |
| [20:45:25] | * paul121[m] has quit (Ping timeout: 265 seconds) |
| [20:45:26] | * zedrckr[m] has quit (Ping timeout: 265 seconds) |
| [20:45:26] | * stevemwai[m] has quit (Ping timeout: 265 seconds) |
| [20:45:29] | * linus0[m] has quit (Ping timeout: 246 seconds) |
| [20:45:30] | * calbasi_matrix has quit (Ping timeout: 246 seconds) |
| [20:46:28] | * jgaehring[m] has quit (Ping timeout: 240 seconds) |
| [20:46:28] | * julianorman[m] has quit (Ping timeout: 240 seconds) |
| [20:46:28] | * wombat83[m] has quit (Ping timeout: 240 seconds) |
| [20:48:14] | * arvidsjaur[m] has quit (Ping timeout: 258 seconds) |
| [20:48:14] | * rationaljohn[m] has quit (Ping timeout: 258 seconds) |
| [20:48:19] | * generalredneck[m has quit (Ping timeout: 244 seconds) |
| [20:48:19] | * braught[m] has quit (Ping timeout: 244 seconds) |
| [20:48:26] | * rocoroc[m] has quit (Ping timeout: 240 seconds) |
| [20:48:26] | * trishlatalera[m] has quit (Ping timeout: 240 seconds) |
| [20:48:27] | * frakman1[m] has quit (Ping timeout: 240 seconds) |
| [20:48:27] | * localisticepicur has quit (Ping timeout: 240 seconds) |
| [20:49:20] | * dazinism has quit (Ping timeout: 244 seconds) |
| [20:55:13] | * botlfarm[m] has joined #farmos |
| [20:55:52] | * paul121[m] has joined #farmos |
| [20:57:27] | * zedrckr[m] has joined #farmos |
| [20:58:46] | * stevemwai[m] has joined #farmos |
| [21:01:53] | * wombat83[m] has joined #farmos |
| [21:04:12] | * julianorman[m] has joined #farmos |
| [21:04:18] | * jgaehring[m] has joined #farmos |
| [21:06:36] | * linus0[m] has joined #farmos |
| [21:07:13] | * calbasi_matrix has joined #farmos |
| [21:11:35] | * jgaehring[m] has quit (Ping timeout: 240 seconds) |
| [21:18:56] | * arvidsjaur[m] has joined #farmos |
| [21:18:56] | * rationaljohn[m] has joined #farmos |
| [21:19:30] | * generalredneck[m has joined #farmos |
| [21:31:53] | * dazinism has joined #farmos |
| [21:33:00] | * rocoroc[m] has joined #farmos |
| [21:39:28] | * braught[m] has joined #farmos |
| [21:42:55] | * frakman1[m] has joined #farmos |
| [21:43:01] | * localisticepicur has joined #farmos |
| [21:43:06] | * trishlatalera[m] has joined #farmos |
| [21:46:16] | * jgaehring[m] has joined #farmos |
| [10:15:45] | <mstenta[m]> | symbioquine jgaehring what's the etiquette around "resolving" github pr review conversations? :-) |
| [10:16:13] | <mstenta[m]> | it feels like i should click "resolve", but that also hides all the nice conversation :-) |
| [10:16:33] | <mstenta[m]> | (i know you can expand them again - just curious what your patterns/preferences are, perhaps in this PR specifically too) |
| [10:16:53] | <mstenta[m]> | (i've only "resolved" ones that were simple fixups so far) |
| [10:18:49] | <symbioquine[m]> | I don't know in general. Perhaps jgaehring 's comments represent important ongoing context, but I feel fine about the ones I've left being resolved as the corresponding changes are incorporated in the docs... |
| [10:20:16] | <symbioquine[m]> | As far as I'm concerned, the review comments only have archeological value at that point. |
| [10:21:04] | <mstenta[m]> | 👍️ that was sort of my thought too - some of the more lengthy conversations are valuable to leave open i think |
| [10:21:24] | <symbioquine[m]> | Seems reasonable |
| [10:22:08] | <mstenta[m]> | great stuff so far! i hope we get some more folks from outside our immediate circle commenting too :-) |
| [10:22:24] | <symbioquine[m]> | Yeah, that would be good |
| [10:22:35] | <symbioquine[m]> | Easy to have a bit of an echo chamber... |
| [10:59:09] | <mstenta[m]> | Might need to figure out a different way to "host" the `2.x-model` branch while this PR is open though... i just realized anytime I push `2.x` to my fork it overwrites the `gh-pages` branch, so the preview at https://mstenta.github.io/farmOS/model disappears |
| [10:59:32] | <mstenta[m]> | i guess I'll just have to keep pushing fixup commits until we merge ;-) |
| [10:59:39] | <symbioquine[m]> | :) |
| [11:00:25] | <mstenta[m]> | i wish github supported multiple GitHub Pages deployments in a single repo |
| [11:00:48] | <mstenta[m]> | (@jgaehring would tell me that's what netlify is for) :-) |
| [11:03:16] | <symbioquine[m]> | Could you use a subdirectory? https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-deploy-to-subdir... |
| [11:04:06] | <symbioquine[m]> | I haven't tested it, just an idea... |