| [21:57:43] | <symbioquine[m]> | Is there already an issue for the asset links from the map on the `/farm/assets/animals` page rendering with commas in them? |
| [21:57:59] | <symbioquine[m]> | ACTION uploaded an image: image.png (90KiB) < https://matrix.org/_matrix/media/r0/download/matrix.org/zXnuFMSFPLsAWifk... > |
| [21:58:44] | <symbioquine[m]> | See the url in the bottom left of the screenshot from hovering over the "Unnamed Champagne 12" link. |
| [21:59:25] | <mstenta[m]> | Ah! No but I know where that's coming from... |
| [21:59:28] | <mstenta[m]> | Views |
| [21:59:44] | <symbioquine[m]> | :) |
| [21:59:59] | <mstenta[m]> | I forget what View generates that |
| [22:00:26] | <mstenta[m]> | But in Views there's a formatting option to exclude the comma from numbers in the 1000s |
| [22:00:38] | <mstenta[m]> | (should be applied to all IDs but missed that one I guess) |
| [22:01:25] | <symbioquine[m]> | Yeah, I couldn't quite see how those links are getting generated... I found [https://github.com/farmOS/farmOS/blob/7.x-1.x/modules/farm/farm_map/js/f...(https://github.com/farmOS/farmOS/blob/f93d4bef58a045d53d1c6583de52954a39...), but it isn't directly adding links. |
| [22:01:51] | <mstenta[m]> | Mm yea I forget too - can check later |
| [22:01:58] | <symbioquine[m]> | No rush |
| [22:02:20] | <symbioquine[m]> | Happy to open an issue if it's a distinct problem too |
| [22:02:48] | <mstenta[m]> | admin/structure/views -> farm_asset_geojson View I believe? |
| [22:03:22] | <symbioquine[m]> | ah, cool! I'll dig a bit deeper, maybe if I'm lucky the issue with come with a patch... |
| [22:03:55] | <mstenta[m]> | yea you can edit the setting through the Views UI... then export to code |
| [23:31:57] | * rocoroc[m] has joined #farmos |
| [01:08:42] | <paul121[m]> | Those links might be added to the popup via hook_farm_area_detail_info? (Not sure which module is the one that provides that tho...) |
| [01:09:11] | <symbioquine[m]> | Yeah thanks! I think I'm on the right track... |
| [01:10:21] | <paul121[m]> | Cool! |
| [01:25:54] | <symbioquine[m]> | I didn't open a Drupal.org issue cause it's a super tiny change and on further reflection maybe a bit of an edge case, let me know if you need me to open one. https://github.com/farmOS/farmOS/pull/406 |
| [01:33:53] | <paul121[m]> | Ohh I was mistaken. It's a cluster, so area details aren't added. Makes sense! |
| [09:35:18] | * farmBOT has joined #farmos |
