| [21:38:00] | * JustTB has quit (Quit: Leaving.) |
| [21:41:11] | * JustTB has joined #farmos |
| [01:38:06] | * svenn has quit (Ping timeout: 265 seconds) |
| [01:38:38] | * svenn has joined #farmos |
| [06:25:41] | * AngelicaSanti has joined #farmos |
| [06:27:54] | * JustTB has quit (Quit: Leaving.) |
| [06:29:32] | * AngelicaSanti has quit (Client Quit) |
| [06:30:34] | * JustTB has joined #farmos |
| [10:43:43] | * JustTB has quit (Ping timeout: 246 seconds) |
| [10:44:21] | <mstenta[m]> | Anyone interested in helping with a (hopefully) straightforward bug? :-D |
| [10:44:25] | <mstenta[m]> | https://github.com/farmOS/farmOS/issues/311 |
| [10:44:51] | <mstenta[m]> | It would just require a local testing instance, and some time... need to test/confirm that the issue is what I think it is... and then confirm that the fix i suggested works |
| [10:46:18] | <mstenta[m]> | (eg: install a new farmOS instance locally from scratch - check that the issue did indeed occur, then make the suggested change, and test a new install from scratch to confirm it fixes it) |
| [10:58:24] | * JustTB has joined #farmos |
| [11:03:52] | * kirsten-mc[m] has joined #farmos |
| [11:03:53] | <kirsten-mc[m]> | Howdy everyone :-) |
| [11:03:53] | <kirsten-mc[m]> | Is there a standard format for commit messages? |
| [11:04:46] | <mstenta[m]> | Hi kirsten-mc we don't have a prescriptive standard, no - but if you look back at the log of old messages you can probably get a general sense and use your best judgement :-) |
| [11:05:05] | <mstenta[m]> | I'd be happy to consider adopting a standard, as well |
| [11:05:31] | <mstenta[m]> | But generally I write commit messages so that I can read them in `git blame`s in the future :-) |
| [11:05:56] | <symbioquine[m]> | https://chris.beams.io/posts/git-commit/ |
| [11:06:06] | <mstenta[m]> | (That isn't as important for documentation, of course) |
| [11:06:40] | <symbioquine[m]> | https://git-scm.com/docs/git-commit#_discussion |
| [11:07:05] | <symbioquine[m]> | ^ Those are my two favorite references - though I follow them with varying degrees of faithfulness depending on the circumstances :) |
| [11:07:12] | <mstenta[m]> | +1 |
| [11:07:53] | <mstenta[m]> | I particularly like this line: |
| [11:07:53] | <mstenta[m]> | > But a well-cared for log is a beautiful and useful thing. git blame, revert, rebase, log, shortlog and other subcommands come to life. |
| [11:08:18] | <kirsten-mc[m]> | As someone who has written change logs before - good commit messages are really important for documentation! |
| [11:08:49] | <mstenta[m]> | Haha yes!! I usually write farmOS release notes by skimming the commit messages and picking out the important ones |
| [12:32:15] | <kirsten-mc[m]> | OK, pull request created. It's just your Navigation script, @mstenta - I wanted to be sure I had the workflow ok and all the bits on my machine. |
| [19:02:12] | <paul121[m]> | hey all, I have a Drupal Views question.. |
| [19:03:21] | <paul121[m]> | using the Views UI I created a custom view that lists Activity Logs meeting a certain criteria (logs that are `done` and in a certain category) |
| [19:03:51] | <paul121[m]> | I'm able to add this view to the farmOS dashboard using `hook_dashboard_panes` |
| [19:04:14] | <paul121[m]> | * using the Views UI I created a custom "block" view that lists Activity Logs meeting a certain criteria (logs that are `done` and in a certain category) |
| [19:05:22] | <paul121[m]> | now I want to add a collapsed fieldset with a custom form within this block on the dashboard |
| [19:06:15] | <paul121[m]> | do I need to use `hook_view_alter` to add this fieldset? |
| [19:07:14] | <paul121[m]> | I don't imagine I can do all this via Views UI (this form will be used to create Activity Logs meeting this criteria) |