| [20:22:19] | * JustTB has quit (Quit: Leaving.) |
| [20:36:01] | * JustTB has joined #farmos |
| [00:24:34] | * sidepocket_ has joined #farmos |
| [00:32:52] | * JustTB has quit (Quit: Leaving.) |
| [02:19:22] | * sidepocket_ has quit (Quit: Leaving) |
| [03:31:17] | * farmBOT has joined #farmos |
| [04:02:51] | * JustTB has joined #farmos |
| [05:02:45] | * JustTB has quit (Quit: Leaving.) |
| [05:17:34] | * JustTB has joined #farmos |
| [09:47:38] | * JustTB has quit (Quit: Leaving.) |
| [09:51:44] | <skipper_is[m]> | `Notice: Undefined variable: options in farm_livestock_weight_group_report_form() (line 189 of profiles/farm/modules/farm/farm_livestock/farm_livestock_weight/farm_livestock_weight.module).` |
| [09:51:44] | <skipper_is[m]> | Is this because I have no farm livestock weights, or that the module isn't installed? |
| [09:55:05] | <skipper_is[m]> | Also, the map not saving which layer you set (eg OSM/Google Sat) there were some other people who had that issue wasn't there? What was the resolution? I can't seem to see it on Git |
| [10:04:43] | <symbioquine[m]> | Unrelated to that... probably my favorite UI bug in a while; (watch the top menu icons) |
| [10:04:53] | <symbioquine[m]> | ACTION uploaded an image: Peek 2020-04-16 07-00.gif (656KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/eXUCnUNOHsNOdSDz... > |
| [10:07:51] | <mstenta[m]> | > Is this because I have no farm livestock weights, or that the module isn't installed? |
| [10:07:51] | <mstenta[m]> | That's just a PHP Notice... safe to ignore. But we should fix. We just need to add `$options = array();` before this line: https://github.com/farmOS/farmOS/blob/7.x-1.x/modules/farm/farm_livestoc... |
| [10:08:45] | <skipper_is[m]> | I've only just got user 1 access, they're not going to let me poke around in their server files |
| [10:08:52] | <mstenta[m]> | > Also, the map not saving which layer you set (eg OSM/Google Sat) there were some other people who had that issue wasn't there? What was the resolution? I can't seem to see it on Git |
| [10:08:52] | <mstenta[m]> | here is the related issue: https://github.com/farmOS/farmOS-map/issues/65 |
| [10:10:06] | <mstenta[m]> | iirc, that issue seems to be related to the OS+browser being used. are you using windows+chrome? |
| [10:10:40] | <skipper_is[m]> | Yea |
| [10:10:54] | <mstenta[m]> | > Unrelated to that... probably my favorite UI bug in a while; (watch the top menu icons) |
| [10:10:54] | <mstenta[m]> | AHH! that's weird haha |
| [10:11:00] | <mstenta[m]> | I think I know why though... |
| [10:12:36] | <mstenta[m]> | symbioquine: this code needs to use jQuery `.once()`: https://github.com/farmOS/farmOS/blob/7.x-1.x/themes/farm_theme/js/glyph... |
| [10:13:23] | <skipper_is[m]> | Weird that the map bug is not there on my FarmOS, but the other one, also running 1.3 it is. Same browser, same OS.. |
| [10:13:49] | <mstenta[m]> | skipper_is: Oh yea? Hmm |
| [10:14:15] | <mstenta[m]> | Can you open dev tools in your browser in both and look at the local storage? |
| [10:15:10] | <mstenta[m]> | ACTION uploaded an image: Screenshot from 2020-04-16 10-14-44.png (99KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/OtuXGDAAFABSypgV... > |
| [10:15:19] | <mstenta[m]> | also: test that page https://farmos.github.io/farmOS-map/ |
| [10:15:23] | <mstenta[m]> | does the problem happen there too? |
| [10:17:41] | <mstenta[m]> | skipper_is: worth noting... i pushed a few minor changes (fixes) to the localstorage code to farmOS-map.js... but they are not included in farmOS 1.3 |
| [10:17:57] | <mstenta[m]> | you might be able to ask the sysadmins to replace the farmOS-map.js file manually on their server to see if that helps |
| [10:18:09] | <mstenta[m]> | (i would actually love to know if that fixes it for you) |
| [10:22:29] | <mstenta[m]> | https://github.com/farmOS/farmOS-map/releases/tag/v1.1.0 |
| [10:24:52] | * JustTB has joined #farmos |
| [10:35:16] | <symbioquine[m]> | <mstenta[m] "symbioquine: this code needs to "> I didn't see an obvious place to put `.once()` in there, but this fixes it; https://github.com/farmOS/farmOS/pull/275 |
| [10:36:26] | <mstenta[m]> | cool! thanks symbioquine ! |
| [10:36:36] | <mstenta[m]> | I'll comment on that with some ideas |
| [10:36:53] | <mstenta[m]> | i think using `.once()` is the "proper" solution... and should have been done that way from the beginning (my bad) |
| [10:36:58] | <mstenta[m]> | i'll explain in the PR |
| [10:37:46] | <symbioquine[m]> | Cool. I'd be interested to see. I don't use jQuery much these days... |
| [10:44:49] | <mstenta[m]> | https://github.com/farmOS/farmOS/pull/275#issuecomment-614697939 |
| [10:47:37] | <mstenta[m]> | skipper_is: I am committing a fix to the PHP notice... FYI |
| [11:01:02] | <symbioquine[m]> | <mstenta[m] "i think using `.once()` is the ""> Thanks for the explanation on the PR! Here's the improved version :) https://github.com/farmOS/farmOS/pull/276 |
| [11:02:16] | <mstenta[m]> | Cool! Thanks! Were you able to test if that worked? |
| [11:03:02] | <symbioquine[m]> | Yeah it does |
| [11:03:50] | <mstenta[m]> | merged! |
| [11:07:53] | <symbioquine[m]> | Thanks! |
| [12:12:46] | * JustTB has quit (Ping timeout: 256 seconds) |
| [12:37:45] | * JustTB has joined #farmos |
| [12:47:11] | * JustTB has quit (Quit: Leaving.) |
| [13:02:10] | * JustTB has joined #farmos |
| [13:12:24] | * JustTB has quit (Quit: Leaving.) |
| [13:23:09] | * JustTB has joined #farmos |
| [13:25:54] | * JustTB has quit (Client Quit) |
| [14:01:09] | * JustTB has joined #farmos |