| [19:43:50] | * Fosten has quit (Quit: Leaving.) |
| [19:44:06] | * Fosten has joined #farmos |
| [19:44:14] | * Fosten has quit (Client Quit) |
| [00:43:58] | * Fosten has joined #farmos |
| [01:07:48] | * Fosten has quit (Quit: Leaving.) |
| [04:38:12] | * JustTB has joined #farmos |
| [09:43:18] | * JustTB has quit (Quit: Leaving.) |
| [09:56:36] | <mstenta[m]> | Opportunity for anyone based in the UK: http://forum.goatech.org/t/funding-3k-for-software-sustainability/429 |
| [09:56:59] | <mstenta[m]> | Could be a great opportunity to grow the farmOS community in the UK! |
| [10:19:41] | * Fosten has joined #farmos |
| [10:19:41] | * Fosten has quit (Client Quit) |
| [11:16:06] | * JustTB has joined #farmos |
| [12:59:59] | * Fosten has joined #farmos |
| [13:14:44] | <paul121[m]> | Submitted a pull request, adds the ability to override planting quick form asset names |
| [13:16:45] | <mstenta[m]> | paul121: Awesome!!! I'll check it out soon! Thanks! |
| [13:17:56] | <paul121[m]> | Ran into a few issues. The forms API doesn't allow you to reset the #default_value of a form on an ajax callback. I would update this when a crop/season are added. Updating the #value of the form doesn't allow the user to make changes. There is a workaround I used, just seems like a limitation of the forms API.. ran into this @mste |
| [13:18:14] | <paul121[m]> | Have you ran into that mstenta ? |
| [13:22:19] | <mstenta[m]> | Ah yea - I've run into that too. I actually use the same solution in a few other places, if I remember correctly. |
| [13:41:50] | <mstenta[m]> | Great job paul121 - looks and works great! |
| [13:42:00] | <mstenta[m]> | I merged it in. :-) |
| [14:13:31] | <paul121[m]> | mstenta: great! Adding the locations while I'm here, too.. |
| [14:15:41] | <paul121[m]> | I wanted to ask, how would you manage your development for this? I'm working on the repository inside docker at profiles/farm. I added my remote fork to the local repo, and managed that way. Is this the easiest way? |
| [14:16:21] | <paul121[m]> | Would you have a different approach if you were working on a module not included in farmOS? |
| [14:19:41] | <mstenta[m]> | paul121: Great! You're on a roll! |
| [14:20:09] | <mstenta[m]> | Yea, for farmOS core development, I work inside .data/www/profiles/farm (where the Git repository gets checked out during Docker setup) |
| [14:20:34] | <mstenta[m]> | The Drupal convention for non-core modules and themes is to put them under the sites/ directory |
| [14:20:59] | <mstenta[m]> | So I generally put farm_* module in .data/www/sites/all/modules/farm |
| [14:21:39] | <mstenta[m]> | The reason you're encouraged to put everything under sites/ is to make Drupal/farmOS core updates easier |
| [14:21:52] | <mstenta[m]> | You can basically download the new version's zip or tar.gz and replace everything except sites/ |
| [14:22:23] | <mstenta[m]> | (Hence why you wouldn't want to put anything non-core inside profiles/farm/ - because it would be replaced during an update.) |
| [14:25:04] | <mstenta[m]> | PS: If you're curious about why farmOS gets checked out again inside .data/www, these two issues might be of interest: |
| [14:25:09] | <mstenta[m]> | https://github.com/farmOS/farmOS/issues/36 |
| [14:25:10] | <mstenta[m]> | https://github.com/farmOS/farmOS/issues/114 |
| [14:28:57] | <paul121[m]> | Hmmm okay. Lots of pieces there! |
| [14:31:55] | <paul121[m]> | It took me awhile to figure out how that git repository was being checked out. Just took a while going through the Development/Docker documentation at farmos.org. All the information is there, but I think it could be simplified |
| [14:32:56] | <paul121[m]> | Maybe not simplified, but explicit-fied... add a section that more explicitly says 'It is recommended to do development --here--' |
| [14:33:31] | <paul121[m]> | I'm starting to see the benefits of multiple repos for things, but also the value of just one... It makes coming onto the project easier, I think... |
| [14:33:35] | <paul121[m]> | Thanks!! |
| [14:45:22] | <mstenta[m]> | Yea I agree - the Docker documentation page could be reorganized, especially with regard to how to use it for development vs actual hosting |
| [14:45:27] | <mstenta[m]> | I think I made some todos for that... |
| [14:46:13] | <mstenta[m]> | Eh maybe not... this is semi-related: https://github.com/farmOS/farmOS.org/issues/20 |
| [14:46:29] | <mstenta[m]> | If you want to take a stab at some edits, please feel free! |
| [14:55:42] | <paul121[m]> | Is docker a good candidate for production now? Or nearly? |
| [15:05:21] | <mstenta[m]> | paul121: Yes I would say so. |
| [15:05:55] | <mstenta[m]> | I use it for Farmier hosting. |
| [15:06:23] | <mstenta[m]> | Although I do not put the database in Docker in production. |
| [15:06:31] | <mstenta[m]> | It works great for the www container. |
| [15:07:17] | <mstenta[m]> | But if you are doing production hosting of farmOS, don't use the docker-compose.yml that comes with farmOS - that is intended only for development. |
| [15:08:28] | <paul121[m]> | Yeah, makes sense. Oh - that's where DEV is set to true, etc, right? |
| [15:08:37] | <mstenta[m]> | Yea |
| [15:08:45] | <mstenta[m]> | And where the database root password gets set to "farmos" ;-) |
| [15:08:50] | <mstenta[m]> | Wouldn't want that in production... |
| [15:09:59] | <mstenta[m]> | So the Dockerfile can be considered ready for production... but it's up to you to decide how you want to run that. If you want to use Docker Compose, then you'll need to write your own docker-compose.yml (or adapt the dev one) |
| [15:11:04] | <paul121[m]> | Ah yes, important things! |
| [15:14:34] | <mstenta[m]> | paul121: PS this pull request looks great too! |
| [15:14:45] | <mstenta[m]> | Will merge in a moment... |
| [15:15:23] | <mstenta[m]> | I'm just going to change the transplanting vs seeding description a bit to try to make it more clear how that works. |
| [15:15:40] | <mstenta[m]> | What do you think about this? |
| [15:15:40] | <mstenta[m]> | > The planting asset name will default to "[Season] [Location] [Crop(s)]" but can be modified here. If both a seeding and a transplanting log are created, the transplanting location will be used. |
| [15:16:54] | <paul121[m]> | That's great! |
| [15:17:31] | <paul121[m]> | Tried a few things in my head, didn't know what was best |
| [15:18:09] | <mstenta[m]> | Yea that's a tricky one to summarize easily :-) |
| [15:18:25] | <mstenta[m]> | Alright! Committed and pushed! |
| [15:18:28] | <mstenta[m]> | Thanks again! |
| [15:24:25] | <paul121[m]> | Awesome. I'll keep an eye out for other little tasks that come up! |
| [15:26:02] | <mstenta[m]> | Great! Thanks Paul! There's a long list over here if you want to poke around: https://www.drupal.org/project/issues/farm?categories=All |
| [15:28:51] | <mstenta[m]> | paul121: PS can I add your name to https://farmos.org/community/supporters/ ? |
| [15:31:04] | <paul121[m]> | Sure, please do! |
| [16:38:23] | * Fosten has quit (Quit: Leaving.) |
| [17:33:58] | * Fosten has joined #farmos |
| [17:46:33] | * Fosten has quit (Quit: Leaving.) |