| [20:14:27] | * EThorn has joined #farmos |
| [21:07:19] | * farmBOT has joined #farmos |
| [21:08:06] | * EThorn has quit (Ping timeout: 240 seconds) |
| [21:31:42] | * EThorn has joined #farmos |
| [21:32:55] | * EThorn has quit (Client Quit) |
| [22:49:34] | * mstenta has quit (Ping timeout: 250 seconds) |
| [09:06:21] | * EThorn has joined #farmos |
| [09:09:54] | * mstenta has joined #farmos |
| [09:21:07] | <mstenta> | EThorn: Hey! Sorry, been running around a bunch this weekend... saw your message about the gray lines not showing though... |
| [09:21:13] | <mstenta> | EThorn: I have a hypothesis... |
| [09:21:26] | <mstenta> | EThorn: when you created your areas, did you set the "Area Type" on them? |
| [09:21:50] | <EThorn> | if I change line 194 of area views default to full path it is fixed |
| [09:22:04] | <mstenta> | Oh! |
| [09:22:14] | <mstenta> | Ok... so maybe related to the other bug you found? |
| [09:22:17] | <EThorn> | they all have area type....it is another path issue, but I can't seem to get url() towork |
| [09:22:23] | <mstenta> | OK... |
| [09:22:37] | <mstenta> | Yea, because you have farmOS installed in a subdirectory... ok... want to file a new bug report? |
| [09:23:09] | <mstenta> | I'll take a quick look... gotta jump off in a minute though - getting my field plowed today for winter rye |
| [09:23:45] | <EThorn> | the really weird thing is if I view source it is actually looking for the path as /FarmOS/Farmos/farm/area/json so it doubles the directory |
| [09:23:47] | <EThorn> | I will file bug |
| [09:25:57] | <mstenta> | line 194 of what file? |
| [09:26:06] | <mstenta> | farm_area.views_default.inc? |
| [09:26:56] | <mstenta> | hmm - if so... that shouldn't be an issue... that's just exported from the Views module - which knows how to handle paths correctly... hmmmm |
| [09:27:13] | <mstenta> | oh i have an idea... |
| [09:27:36] | <mstenta> | there is some openlayers config code that actually references that path, however... to suck in the JSON... so maybe THAT'S where the issue is... |
| [09:28:18] | <mstenta> | Line 31 of farm_area.default_openlayers_sources.inc |
| [09:28:44] | <mstenta> | try making the change there instead.. |
| [09:28:53] | <mstenta> | If that works, then this is probably a bug in the Openlayers module |
| [09:29:19] | <mstenta> | I know the developer in charge of that module, and I've helped him fix a number of bugs, so I can escalate that up |
| [09:32:43] | <EThorn> | was looking at the line 31 thing and it does not seem to be where the path is coming from. |
| [09:35:21] | <mstenta> | EThorn: the path itself is defined by the Views export code you found (line 194 of farm_area.views_default.inc) - but that path is being requested when the map is built - by the code in farm_area.default_openlayers_sources.inc |
| [09:35:33] | <mstenta> | EThorn: did you try just going to the path itself? outside of the map? |
| [09:35:57] | <mstenta> | You can do that to make sure that the View is working properly to produce the JSON |
| [09:36:13] | <EThorn> | I think in this case it is an issue with the json file generating in the format href=\u0022\/FarmOS\/farm\/area\/high-tunnel so FarmOS is tacked on in json and in generating path |
| [09:36:22] | <mstenta> | But make sure you revert line 194 if you changed it (and make sure you revert the View in the UI because it may be overridden now) |
| [09:36:25] | <EThorn> | yea the json is there |
| [09:36:45] | <mstenta> | oh ok cool - and what's the path now? is it still what it was originally or did you change it? |
| [09:37:16] | <EThorn> | well...what I just said doesn't make sense either cause it can't even get to the json file |
| [09:37:36] | <mstenta> | what can't? |
| [09:38:47] | <EThorn> | so the path the editing map uses to look for the json file to get the geometry is generated wrong. So the problem isn't in the json, because if I tell it an exact path it finds the json and the geometry works gine |
| [09:38:51] | <EThorn> | fine* |
| [09:39:08] | <mstenta> | ok cool - that's what i suspected - a bug in the openlayers code |
| [09:39:18] | <mstenta> | that module is great - but i have definitely found a number of bugs in it ;-) |
| [09:39:26] | <EThorn> | it has a lot going on |
| [09:39:28] | <mstenta> | for little edge cases like this |
| [09:39:31] | <mstenta> | yes it does |
| [09:40:00] | <EThorn> | I might just go back and reinstall in server root...ha |
| [09:40:14] | <mstenta> | so let's start an issue in the farmOS issue queue... i'll try to find the exact bug and then move it to the Openlayers queue |
| [09:40:28] | <mstenta> | haha - yea if you're not interested in finding these subdirectory bugs :-) |
| [09:40:37] | <mstenta> | that might be easier |
| [09:41:12] | <EThorn> | it would at least be helpful to see the unbugged version to compare |
| [09:41:44] | <EThorn> | u want bug in farmarea or farmos |
| [09:45:16] | <mstenta> | farm_area please :-) |
| [09:48:53] | <mstenta> | oh... so actually i think this is a bug in farm_area... not in openlayers core |
| [09:49:08] | <mstenta> | i'm looking closer at it... |
| [09:50:20] | <mstenta> | here... i've got a fix you can try... |
| [09:51:07] | <mstenta> | change line 31 to: |
| [09:51:09] | <mstenta> | 'url' => url('farm/areas/json/' . $key, array('absolute' => TRUE)), |
| [09:54:48] | <mstenta> | if you do that... you will have to clear your cache... and you will also want to check the Openlayers > Sources tab to see if any are "overridden" |
| [09:55:01] | <mstenta> | and make sure that they are reverted to default |
| [09:55:14] | <EThorn> | so is line 31 generating the json? |
| [09:55:55] | <mstenta> | no - but line 31 is the url that Openlayers is trying to use to access the JSON form |
| [09:56:06] | <mstenta> | and it's wrong, because it's assuming that the site is installed in the root directory |
| [09:56:11] | <mstenta> | so Openlayers can't find the JSON |
| [09:56:39] | <mstenta> | by making the change I pasted above, it will change the URL to be absolute, which means Openlayers will be looking for it in the correct place |
| [09:57:48] | <mstenta> | i'll be right back... need to move some stuff outside real quick |
| [10:08:02] | <EThorn> | Line 31 is not at work in the case of the editing/adding geometry views. as an experiment I changed path to jxson on line 31 and it happily changes json path for main area map, but is found nowhere in add/edit map. path is set by line 192 and your url() works there...so that will fix that. I'm not sure why my attempt to use url() there failed before...oh well |
| [10:08:48] | <EThorn> | sorry line 194: $handler->display->display_options['path'] = url('farm/areas/json/' , array('absolute' => TRUE)); |
| [10:19:08] | <EThorn> | no...something else broke so neither works again. I gotta get goin, but I will get to the bottom of this |
| [10:30:06] | * EThorn has quit (Ping timeout: 240 seconds) |
| [14:47:10] | * EThorn has joined #farmos |
| [15:48:45] | * EThorn has quit (Ping timeout: 240 seconds) |
| [17:25:43] | * EThorn has joined #farmos |
| [17:49:25] | * EThorn has quit (Ping timeout: 240 seconds) |
| [19:37:21] | * EThorn has joined #farmos |